From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 331E9A054A; Thu, 11 Feb 2021 11:43:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A6AE1CC38A; Thu, 11 Feb 2021 11:43:32 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C5F181CC344 for ; Thu, 11 Feb 2021 11:43:30 +0100 (CET) IronPort-SDR: Rz3b4/LRoO0xM+j/rYH+2D6KNCKTXCh1184+KLrsqXIBvZYRPAkYSvudugKix0x1mfJZsxhVxE EwjQ0f/0cX8g== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="182356173" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="182356173" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:43:23 -0800 IronPort-SDR: tuq+QXecX0bx9B0yDszyxoNJQDhHyfARU0AqA2NecD3JOSImtiQ4SwCoA0NkqmR0YBIF7qD90F RGp2App6HiJQ== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="397205930" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.21.217]) ([10.252.21.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:43:22 -0800 To: "Liu, Yongxin" , dev@dpdk.org References: <20201118025854.13455-1-yongxin.liu@windriver.com> <20201123030533.17944-1-yongxin.liu@windriver.com> From: "Burakov, Anatoly" Message-ID: <4fedb4c2-9891-bdfc-588e-2d047b70bca1@intel.com> Date: Thu, 11 Feb 2021 10:43:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] usertools/devbind: fix binding for built-in kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03-Dec-20 8:25 AM, Liu, Yongxin wrote: > Hi Anatoly, > > Do you have any further comments on this v5? > Or you can submit your own patch directly. > > I am really expecting this issue to be fixed. > > > Thank you very much. > > Yongxin > >> -----Original Message----- >> From: dev On Behalf Of Yongxin Liu >> Sent: Monday, November 23, 2020 11:06 >> To: dev@dpdk.org; anatoly.burakov@intel.com; thomas@monjalon.net >> Subject: [dpdk-dev] [PATCH v5] usertools/devbind: fix binding for built-in >> kernel drivers >> >> A driver can be loaded as a dynamic module or a built-in module. >> In commit 681a67288655 ("usertools: check if module is loaded before >> binding"), script only checks modules in /sys/module/. >> >> However, for built-in kernel driver, it only shows up in /sys/module/, if >> it has a version or at least one parameter. So add check for modules in >> /lib/modules/$(uname -r)/modules.builtin. >> >> Signed-off-by: Yongxin Liu >> --- >> >> v5: >> - Make code robust and more memory efficient. >> >> v4: >> - Replace shell call with platform.uname(). Check file existence >> before reading. >> >> v3: >> - Add built-in module list in loaded_modules for checking >> instead of removing error check. >> >> v2: >> - fix git commit description style in commit log >> - fix typo spelling >> >> --- Apologies for the delay. Reviewed-by: Anatoly Burakov -- Thanks, Anatoly