From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 40D2B6895 for ; Wed, 21 May 2014 15:38:35 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id x48so2063038wes.36 for ; Wed, 21 May 2014 06:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=oc14W9vBI0R8sXEt3eX6o/R1uALQZfJpYZCTd/Xeeyg=; b=i+ztdLJOzFj4pPUYEJcP1PHIJ7NvT0F2yen4m9DcmeRDKd8XSQTuYJtX3N8kCo8Ud/ ekvzLM6Tz90zmC4tceSX/9vMgtYHXiDUnDO46Z+/6HUQXoHjTv1L7HVAIk2+MnE4iiY+ BoaNmRvt1Gto+mVuh0ysIgYv82yFPv4UrbyXjYqU6pKRamdMTeS/LHoozgMe/43H226A rD0YrLxSGj18+1Ylfv5lzRi/jqJOWQS47BDTDG8eXIEbctxKHHLZXBARyR7lUWgv7+Dh xeXQaESlGHwy/h4udtsWCBUpU/X3OlR4fpjbUROEmDVO73erRQsh8/SN5Eroi6RA1JQD j+MQ== X-Gm-Message-State: ALoCoQntasZGr3p7CAiYoDZ1FTEY2c47E/0omQNjiVHL4TGuq//t29T6VcKG8cKkY8AtjHHkFq7l X-Received: by 10.180.93.101 with SMTP id ct5mr10478684wib.23.1400679523987; Wed, 21 May 2014 06:38:43 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id dk10sm1343435wib.1.2014.05.21.06.38.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 May 2014 06:38:42 -0700 (PDT) From: Thomas Monjalon To: Anatoly Burakov Date: Wed, 21 May 2014 15:38:39 +0200 Message-ID: <5003333.VJxjNhveko@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400514709-24087-6-git-send-email-anatoly.burakov@intel.com> References: <1400514709-24087-6-git-send-email-anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 05/16] Moved interrupt type out of igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 May 2014 13:38:35 -0000 2014-05-19 16:51, Anatoly Burakov: > Moving interrupt type enum out of igb_uio and renaming it to be more > generic. Such a strange header naming and separation is done mostly to > make coming virtio patches easier to port to dpdk.org tree. > > Signed-off-by: Anatoly Burakov > +++ b/lib/librte_eal/common/include/rte_pci_dev_feature_defs.h [...] > +++ b/lib/librte_eal/common/include/rte_pci_dev_features.h [...] > +#include Why are you splitting things in 2 files? +#define RTE_INTR_MODE_MAX_MAX "max" What is this constant for? Thanks -- Thomas