From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, jerinj@marvell.com, weiyuanx.li@intel.com,
ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage
Date: Wed, 12 Oct 2022 15:05:42 +0200 [thread overview]
Message-ID: <5006490.PYKUYFuaPT@thomas> (raw)
In-Reply-To: <20221012123419.182631-1-harry.van.haaren@intel.com>
12/10/2022 14:34, Harry van Haaren:
> The eventdev xstats reset API takes an ID of "uint32_t", while
> the rest of the xstats APIs require an "unsigned int". On some
> platforms these might not be the same bitwidth, however this was
> assumed in the code.
>
> Fix by providing a uint32_t to the xstats_reset() function.
Why adding a comment about the type in the code?
We are not adding /* using the right type */ in each line of code.
[...]
> - /* reset to zero */
> + /* reset to zero: note API requires uint32_t not unsigned int */
> + uint32_t reset_id = id;
> int reset_ret = rte_event_dev_xstats_reset(evdev,
next prev parent reply other threads:[~2022-10-12 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 12:34 Harry van Haaren
2022-10-12 13:05 ` Thomas Monjalon [this message]
2022-10-12 13:08 ` Van Haaren, Harry
2022-10-12 15:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5006490.PYKUYFuaPT@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=weiyuanx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).