From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A134A00C4; Wed, 12 Oct 2022 15:05:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BC0843053; Wed, 12 Oct 2022 15:05:50 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id ABFCC4303E for ; Wed, 12 Oct 2022 15:05:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 65DBC320051E; Wed, 12 Oct 2022 09:05:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 12 Oct 2022 09:05:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665579945; x= 1665666345; bh=Qnf4bRIIBo93GKtQAF4qcE3CXAXw9T710/3/i/Bj3zk=; b=m /BzRznDnZmZOeZT0Zz9PGTgFxAUEaLmRJNaYSFA2rD5s9tUO+3zdGatxwupVpQpP I0yf0egz4yoPI2lqISMU8kTpTk6GhB8ZW6wWkwaY9uMu66u9ALNDEjIm4fqi+NNJ phjLdKxYo4719IBsz4Fo/AUxRXwruWrbVqI1TRUs/S+bEUAQEDEsmbOKfqtSGm2Z Gvr26/0SL4PrnqbaH8cix6NSKq7+hJTf0SRlIfDhBNUfTIhyZcoU/Gj+fvYF4Xdw OnrO9krqOhiF3PanvIXqC5bBAXUWG0upM7fWHKh5eVeJaMhKaNn38MfNzrBzK3km a3OkLfuylRv+/sGF4MHag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665579945; x= 1665666345; bh=Qnf4bRIIBo93GKtQAF4qcE3CXAXw9T710/3/i/Bj3zk=; b=f 0B6xSszDp/Va5oVgvgqXyk5ZUgdBrJt5i6ot5TDzH7CFrUcEyyJI5PFW3g32f4j1 5p1wY2LOhLViJSqVBvzqvuz1fqeQs4IyhGGsPKBk29Y+K6tuhCz6428v3I911BVS HlmwRPzJ3l/Mzvp2fvTKH3rM9/xvDb3T4DC5oUhaQicH8qqWwR2Agmc3w5e/m8V0 k94GTIbajm9NWmKFY2IgxnI9t4h4nOCXN/MYC5Mkb2u+tTL7LolC8JiTcxtD+WC1 qdiWXOZZzctvyfJJDwtuKRcXSksnkVtbpJX96VUfz6Q3VlOGlXoqFF65FsAsmxCM TDrL9A80XGy1gc1xJosSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 09:05:43 -0400 (EDT) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, jerinj@marvell.com, weiyuanx.li@intel.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage Date: Wed, 12 Oct 2022 15:05:42 +0200 Message-ID: <5006490.PYKUYFuaPT@thomas> In-Reply-To: <20221012123419.182631-1-harry.van.haaren@intel.com> References: <20221012123419.182631-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/10/2022 14:34, Harry van Haaren: > The eventdev xstats reset API takes an ID of "uint32_t", while > the rest of the xstats APIs require an "unsigned int". On some > platforms these might not be the same bitwidth, however this was > assumed in the code. > > Fix by providing a uint32_t to the xstats_reset() function. Why adding a comment about the type in the code? We are not adding /* using the right type */ in each line of code. [...] > - /* reset to zero */ > + /* reset to zero: note API requires uint32_t not unsigned int */ > + uint32_t reset_id = id; > int reset_ret = rte_event_dev_xstats_reset(evdev,