From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Flavio Leitner <fbl@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net: get rid of SET_ETHTOOL_OPS
Date: Wed, 02 Jul 2014 11:48:51 +0200 [thread overview]
Message-ID: <5006516.KlozUPNl4J@xps13> (raw)
In-Reply-To: <1404238780-19596-1-git-send-email-fbl@redhat.com>
Hi Flavio,
2014-07-01 15:19, Flavio Leitner:
> The SET_ETHTOOL_OPS has been removed from upstream, so it
> breaks the dpdk build with recent kernels.
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
You are removing SET_ETHTOOL_OPS calls.
In a previous patch, Aaro Koskinen made the choice to redefine the macro
in kcompat files.
I don't know what will be the choice of Intel in the sourceforge base driver.
So I've applied Aaro's patch as there are less modifications of the base
driver:
http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411
It would be better to have patches from people working on the base driver.
So upgrades from sourceforge driver to KNI would be smoother.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-07-02 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 18:19 Flavio Leitner
2014-07-02 9:48 ` Thomas Monjalon [this message]
2014-07-02 13:07 ` Flavio Leitner
2014-07-02 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5006516.KlozUPNl4J@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=fbl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).