From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id 5F74DAB06 for ; Wed, 2 Jul 2014 11:48:38 +0200 (CEST) Received: by mail-we0-f170.google.com with SMTP id w61so10814130wes.1 for ; Wed, 02 Jul 2014 02:48:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hCVWWbN5fDlbVlTJy3myC+0kepg5fu4Z+bGCdRtsYgc=; b=K9fAoAQzxUhtLUpWmMxvJJUlHcIEvb3GVGAIlN1ID85A8b5pRvV6fcoQvijgp/erF4 PUdAf8pwAxqhXWcSxT9gMjRJFzVyYZ+FWuRNcEHGIyGtAKDRnu68zTmvIDCNoUIfjDlV 9tS7L1nAlZp4YpHp+23nYzGu+Z3dVl+86r3qx3Vdt116YZnr/LFRXfpfqx1sxnqRO4SF kqtzGuR8neH3r+pQwhCoCa3aK6RSWv78EV/XwwrtvjmRsQ57Q0KpDzX8bsrIqZtRH6gb I1cDddxgH2KZ8XYIAJ2XrneBg76shi/fSaRkqDYU07xPSs9IrmUZF3mibonR2ZssU2xv 9iFQ== X-Gm-Message-State: ALoCoQlwor1clv7SPGeP87uxX9WCLlW9jtgpYNpy9cOWMy83uMTVztOQ+11wPgE8Ql/MZlh5Sqa3 X-Received: by 10.194.77.238 with SMTP id v14mr2643475wjw.103.1404294538560; Wed, 02 Jul 2014 02:48:58 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ja9sm53358857wic.8.2014.07.02.02.48.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jul 2014 02:48:57 -0700 (PDT) From: Thomas Monjalon To: Flavio Leitner Date: Wed, 02 Jul 2014 11:48:51 +0200 Message-ID: <5006516.KlozUPNl4J@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1404238780-19596-1-git-send-email-fbl@redhat.com> References: <1404238780-19596-1-git-send-email-fbl@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net: get rid of SET_ETHTOOL_OPS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2014 09:48:38 -0000 Hi Flavio, 2014-07-01 15:19, Flavio Leitner: > The SET_ETHTOOL_OPS has been removed from upstream, so it > breaks the dpdk build with recent kernels. > > Signed-off-by: Flavio Leitner You are removing SET_ETHTOOL_OPS calls. In a previous patch, Aaro Koskinen made the choice to redefine the macro in kcompat files. I don't know what will be the choice of Intel in the sourceforge base driver. So I've applied Aaro's patch as there are less modifications of the base driver: http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411 It would be better to have patches from people working on the base driver. So upgrades from sourceforge driver to KNI would be smoother. Thanks -- Thomas