From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1960B1B2A9
 for <dev@dpdk.org>; Wed, 14 Feb 2018 01:09:45 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B4D6820FE2;
 Tue, 13 Feb 2018 19:09:44 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 13 Feb 2018 19:09:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ZC+/ODGnV0bytELxv2E2yHu00q
 sDfLFkbvgtxQ4wtfU=; b=qu+drn8UvTL4CSY72oVMHhZQ3J0fMC/Erx+jplfZbw
 ZNqtVMzJNqiuiwrlzXe0C5AkQaCX1Q6xznBk/FFb/UiliKt/mLe+sWkEG3KRHPaS
 qWR87WGNaqm4ecyUTQ3AGFNsXbQkRkppIpwPkF5QEicXD8ElGjqf84xjCgAHV1ug
 o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZC+/OD
 GnV0bytELxv2E2yHu00qsDfLFkbvgtxQ4wtfU=; b=GONMgvFPgVTOY7HAAlUx3e
 c/rT3n3nenCIxRRCQILSWfMsVK+Bn6CDLNPXfoMwkbG8jCy2CeC2vL8iaJiwiHMT
 q4IaRW2XqIQuEkeymUiwUksBwcG1seQiTvRxI6I/NSjisfR0cUhHGK/kxByDBEiq
 QcpUF5VM5zochvoklMwdh1WbMuhaWmGiWraEYiBpdMGAAPYjnznjM2uMrG/BI4zE
 qEvYp9ip0NDV89OemSbuJKYm9CNngKttWbmgnCp1YlKx9exKi5ZoXp9H6mkuT708
 b5vt9BWnyQTBtMXs5flBrdvKJE6RVyfW3/jvSR25pyBQz2xey7RlIIrEEDpvCtMg
 ==
X-ME-Sender: <xms:SH6DWtTIPcKjWhqMXUBihaEL-53uCxYpC2zIc9HMyKeUXi9s5EE2Yw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 697C67E4E9;
 Tue, 13 Feb 2018 19:09:44 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org, nhorman@tuxdriver.com, pbhagavatula@caviumnetworks.com,
 aconole@redhat.com
Date: Wed, 14 Feb 2018 01:09:34 +0100
Message-ID: <5006829.4uDuJ5LzRD@xps>
In-Reply-To: <1515789935-3794-1-git-send-email-erik.g.carrillo@intel.com>
References: <1515789935-3794-1-git-send-email-erik.g.carrillo@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role
	function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2018 00:09:45 -0000

12/01/2018 21:45, Erik Gabriel Carrillo:
> This an API/ABI change notice for DPDK 18.05 announcing a change in
> the meaning of the return values of the rte_lcore_has_role() function.
> 
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> +* eal: The semantics of the return value for the ``rte_lcore_has_role`` function
> +  are planned to change in v18.05. The function currently returns 0 and <0 for
> +  success and failure, respectively.  This will change to 1 and 0 for true and
> +  false, respectively, to make use of the function more intuitive.

It will introduce some subtle bugs in applications.
We must clearly advertise this API change in the release notes.

Acked-by: Thomas Monjalon <thomas@monjalon.net>