From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 192D3A04DB; Fri, 16 Oct 2020 11:27:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DE3E1D5D1; Fri, 16 Oct 2020 11:27:21 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D4E021D5CA for ; Fri, 16 Oct 2020 11:27:19 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3A8505C00EB; Fri, 16 Oct 2020 05:27:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Oct 2020 05:27:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4JQRHjtFBbgI7K7/XI0PD2X/kS/w+dAc0cOs/F/1t8Q=; b=jaSOW3gUA0stnJwB rD5RxenEaPZU9DMhQoDthWN4BvTrQCltA6FPkm1S239YOXcH0XBEGBkIsmuntvhc H2l6uGNNNfvE/auuFfrmMkoRL/Bmh+G9bUNEbdcujIELTdapGkFngjkBDgGL7ya6 7Na4+51l6GkrzSb4wWYJVUY0Th1qlLsQdZT/pjmPLo9rpOdV0tRCrfQ3iVlWc71z E6Rvv+ldrnLHxtw+HiOAtnTvsURAp0tOPlTMoEsy0gy71kd4j0Ce2hHOJva1ydT+ cGhPYgbuV2lPu4R90MhJYov3IQ05s/pWSQ/piOL4JiBnOE4HLdiA9zW7GOg57OWA qm8gIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4JQRHjtFBbgI7K7/XI0PD2X/kS/w+dAc0cOs/F/1t 8Q=; b=f6r2XTsk2t74toU8p7wEbIFBhkjxywJcXso9coiWNLQYcjKGyW72fktBY hQUidkvJsoCcAcqC2rZn+FjKHMsKKml2eFe+BAeH6ht3/iJFEk8nmVObnQrkxrxU GBvhOryPWmmx14v4I8y+6gIrLzfCCvmO+wTdZUgua20nqJWfENNveKWbzxi+0XS3 0E+DcrYri56MamavdMoDMhFOGjebN0mdsFv1BoQtHgmJE9Z/VoVsB00+ZUZ3I+xW YENZUZBXaSbJPAdO2UsbY6YsjrbhNbJb0Lgh5qVIrb+IBEZsDoQNBh5ldPKtexPc CJnLwCFZ59nrndTmadlW2jkRaTGkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieehgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 640E6306467D; Fri, 16 Oct 2020 05:27:17 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 16 Oct 2020 11:27:14 +0200 Message-ID: <50089949.kCDsZEtK6n@thomas> In-Reply-To: <20201016091818.GC1008@bricha3-MOBL.ger.corp.intel.com> References: <20201016033955.2566518-1-thomas@monjalon.net> <20201016091818.GC1008@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: make sphinx errors more visible X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/10/2020 11:18, Bruce Richardson: > On Fri, Oct 16, 2020 at 05:39:55AM +0200, Thomas Monjalon wrote: > > When running Sphinx through ninja, the wrapper configured in meson > > redirects stdout to a log file. > > It makes more important to print issues on stderr. > > > > Some warnings generated by the conf.py were hidden because > > printed on stdout. The first improvement is to print them on stderr. > > > > The second measure is to stop processing if meson was configured > > with --werror. > > > > Signed-off-by: Thomas Monjalon > > --- > > buildtools/call-sphinx-build.py | 3 +++ > > doc/guides/conf.py | 19 +++++++++++++++---- > > 2 files changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/buildtools/call-sphinx-build.py b/buildtools/call-sphinx-build.py > > index 26b199220a..8b266bec9b 100755 > > --- a/buildtools/call-sphinx-build.py > > +++ b/buildtools/call-sphinx-build.py > > @@ -14,6 +14,9 @@ > > > > # set the version in environment for sphinx to pick up > > os.environ['DPDK_VERSION'] = version > > +# forward error policy to conf.py > > +if '-W' in extra_args: > > + os.environ['SPHINX_STOP_ON_ERROR'] = 'true' > > > > Actually, I'm not sure this is necessary. Since the conf.py is processed > from within the sphinx process itself, you can access sys.argv directly > from within conf.py, rather than having to pass variables through the > environment. Great idea, thanks