From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaoyu Min <jackmin@mellanox.com>, Ori Kam <orika@nvidia.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
"matan@nvidia.com" <matan@nvidia.com>,
Dekel Peled <dekelp@nvidia.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Xiaoyu Min <jackmin@nvidia.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Thomas Monjalon <thomas@monjalon.net>,
Hyong Youb Kim <hyonkim@cisco.com>,
John Daley <johndale@cisco.com>, Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct
Date: Mon, 9 Nov 2020 10:05:07 +0000 [thread overview]
Message-ID: <500a6ffc-2c12-9e2e-4413-d4e5b097d61a@intel.com> (raw)
In-Reply-To: <5218b9e5-68a8-085d-3336-ae1b4f0971a9@intel.com>
On 11/3/2020 2:27 PM, Ferruh Yigit wrote:
> On 11/3/2020 1:20 PM, Xiaoyu Min wrote:
>> From: Xiaoyu Min <jackmin@nvidia.com>
>>
>> The rte_flow_item_eth and rte_flow_item_vlan items are refined [1].
>> The structs do not exactly represent the packet bits captured on the wire
>> anymore so set raw_encap/decap commands should only copy real header
>> instead of the whole struct.
>>
>> Replace the rte_flow_item_* with the existing corresponding rte_*_hdr.
>>
>> [1]:
>> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
>> items")
>>
>> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
>
>
> Hi Dekel, Ori,
>
> This is second fix [1] we get related to the "rte_flow_item_xxx" size changes
> [2] from you.
>
> The assumption that 'rte_flow_item_xxx' size is same as xxx header size seems
> implemented in multiple locations, and changing 'rte_flow_item_xxx' struct size
> breaking those usage.
>
> Can one of you guys spend some time to actively check all possible breakages?
> They may be very hard to find unless someone explicitly check for this.
>
Hi Dekel, Ori,
Is there anyone actively checking for this?
> Thanks,
> ferruh
>
>
> [1]
> first one: https://patches.dpdk.org/patch/82863/
>
>
> [2]
> Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item")
> Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
next prev parent reply other threads:[~2020-11-09 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:20 Xiaoyu Min
2020-11-03 14:27 ` Ferruh Yigit
2020-11-09 10:05 ` Ferruh Yigit [this message]
2020-11-09 11:14 ` Dekel Peled
2020-11-09 11:16 ` Ferruh Yigit
2020-11-03 17:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500a6ffc-2c12-9e2e-4413-d4e5b097d61a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=asafp@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=jackmin@mellanox.com \
--cc=jackmin@nvidia.com \
--cc=johndale@cisco.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).