From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 885E1A0527; Mon, 9 Nov 2020 11:05:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAFB25937; Mon, 9 Nov 2020 11:05:18 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 542755928 for ; Mon, 9 Nov 2020 11:05:16 +0100 (CET) IronPort-SDR: VKXqmSp+KAm86zv5wVKzwQxXU2Ld8r0maK3RE3y2cGiYnbZ7X404xbx42cdKo4CKlKiE9Gari/ C+qG72A7vzJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="149628619" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="149628619" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:05:14 -0800 IronPort-SDR: xgC6Mf6pwGP2QupaZs66piUhz7/1ormBstQzqKOF6BIwGcu159UXvCv5CFayiU2ryNdSCvi+Zv 4Q+bb8wAPQ4Q== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530666609" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177]) ([10.213.193.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:05:11 -0800 From: Ferruh Yigit To: Xiaoyu Min , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , "matan@nvidia.com" , Dekel Peled , Ajit Khaparde Cc: dev@dpdk.org, Xiaoyu Min , Andrew Rybchenko , Thomas Monjalon , Hyong Youb Kim , John Daley , Asaf Penso References: <20201103132022.14132-1-jackmin@mellanox.com> <5218b9e5-68a8-085d-3336-ae1b4f0971a9@intel.com> Message-ID: <500a6ffc-2c12-9e2e-4413-d4e5b097d61a@intel.com> Date: Mon, 9 Nov 2020 10:05:07 +0000 MIME-Version: 1.0 In-Reply-To: <5218b9e5-68a8-085d-3336-ae1b4f0971a9@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 2:27 PM, Ferruh Yigit wrote: > On 11/3/2020 1:20 PM, Xiaoyu Min wrote: >> From: Xiaoyu Min >> >> The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. >> The structs do not exactly represent the packet bits captured on the wire >> anymore so set raw_encap/decap commands should only copy real header >> instead of the whole struct. >> >> Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. >> >> [1]: >> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN >> items") >> >> Signed-off-by: Xiaoyu Min > > > Hi Dekel, Ori, > > This is second fix [1] we get related to the "rte_flow_item_xxx" size changes > [2] from you. > > The assumption that 'rte_flow_item_xxx' size is same as xxx header size seems > implemented in multiple locations, and changing 'rte_flow_item_xxx' struct size > breaking those usage. > > Can one of you guys spend some time to actively check all possible breakages? > They may be very hard to find unless someone explicitly check for this. > Hi Dekel, Ori, Is there anyone actively checking for this? > Thanks, > ferruh > > > [1] > first one: https://patches.dpdk.org/patch/82863/ > > > [2] > Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item") > Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")