From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81C40454EF; Tue, 25 Jun 2024 13:21:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADE1242E8F; Tue, 25 Jun 2024 13:17:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 7814642C24 for ; Tue, 25 Jun 2024 13:16:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314209; x=1750850209; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PAAotW8m1VM/Rd2MXD8PcCNhYyGUQlkLiTiY5pMowl4=; b=Ct4HT1FiWd40d7+a50xQ360v1QRDi+cb0SoJxj+gTD1EmQqxgO2AmKNX gvcBDkR3UOjCGzB9C+0m6SVMD1P1SdQE7ZdkFjy5+uIXcJkL96BFO/rKw gOBxVC+GvGlTFQNrH1HhpmtqRU7jZQNjVKd48Of0jpwPrgQYFN32Byfj2 s0/70pM57b9qGWP6brT44LkQDfLXtXf+5sQva3NBbsdA6nG4m2IDQQadn iqgkSYex0dkDZw7+ft1ygz9H+3AJ8Cv2qWc2BjZg6FWstz5Lff9MEeP5C 1ypYEgLO6m7FUNqIfrwt/lUDFssYToUTTL0gu3bQfvXuuPO47U2BJgEBi A==; X-CSE-ConnectionGUID: UFZKbqXYSXeUx1ryhPTv+w== X-CSE-MsgGUID: L5QsHUQoQoui50wsii/6gQ== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080207" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080207" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:16:12 -0700 X-CSE-ConnectionGUID: gk2pWPIdSWW71l0GYmfOiw== X-CSE-MsgGUID: slhESHdlQGOuyMCIt3Syww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43719180" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:16:12 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Adrian Pielech , bruce.richardson@intel.com, ian.stokes@intel.com Subject: [PATCH v3 045/129] net/ice/base: remove dead code from ice_get_ddp_pkg_state Date: Tue, 25 Jun 2024 12:12:50 +0100 Message-ID: <5010b42846f8c94098180fc1f683f2a4e4ca04ac.1719313663.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Adrian Pielech Removed "else" statement in ice_get_ddp_pkg_state() as it may never happen. Signed-off-by: Adrian Pielech Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ddp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index fcf6dc69e3..5a0cf4d54f 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -1205,11 +1205,8 @@ ice_get_ddp_pkg_state(struct ice_hw *hw, bool already_loaded) } else if (hw->active_pkg_ver.major != ICE_PKG_SUPP_VER_MAJ || hw->active_pkg_ver.minor != ICE_PKG_SUPP_VER_MNR) { return ICE_DDP_PKG_ALREADY_LOADED_NOT_SUPPORTED; - } else if (hw->active_pkg_ver.major == ICE_PKG_SUPP_VER_MAJ && - hw->active_pkg_ver.minor == ICE_PKG_SUPP_VER_MNR) { + } else { return ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED; - } else { - return ICE_DDP_PKG_ERR; } } -- 2.43.0