From: Thomas Monjalon <thomas@monjalon.net>
To: Haifei Luo <haifeil@nvidia.com>
Cc: dev@dpdk.org, orika@nvidia.com, viacheslavo@nvidia.com,
rasland@nvidia.com, xuemingl@nvidia.com, haifeil@nvidia.com,
ajit.khaparde@broadcom.com, Xiaoyun Li <xiaoyun.li@intel.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump
Date: Wed, 14 Apr 2021 10:57:34 +0200 [thread overview]
Message-ID: <5011689.uK669MFXqd@thomas> (raw)
In-Reply-To: <1618389706-183883-2-git-send-email-haifeil@nvidia.com>
About the title, what is "rte API"?
I guess you mean DPDK API with rte prefix.
But given all DPDK API have rte prefix,
and this patch is for DPDK,
you can just say "API".
So the title can be:
ethdev: modify API for single flow dump
But it can look as single flow dump was possible before,
which is wrong because it is a new feature.
Another idea is wrong:
The packets of the flow are not dumped,
it is only dumping the HW representation of the flow rule.
I propose to simply describe the new feature:
ethdev: dump single flow rule
> + * @param[in] flow
> + * The pointer of rte flow.
Please replace "rte flow" with 'flow rule".
Is it allowed to pass NULL? Will it dump all?
If yes, you can change to:
Flow rule to dump.
Dump all rules if NULL.
next prev parent reply other threads:[~2021-04-14 8:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:15 [dpdk-dev] [PATCH 0/4] *** Support for one flow dump *** Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 1/4] ethdev: add rte API for single flow dump Haifei Luo
2021-03-10 0:39 ` Stephen Hemminger
2021-03-10 7:05 ` Ori Kam
2021-03-09 8:15 ` [dpdk-dev] [PATCH 2/4] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 3/4] common/mlx5: add mlx5 APIs " Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 4/4] net/mlx5: " Haifei Luo
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 0/5] support single flow dump Haifei Luo
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 1/5] ethdev: modify rte API for " Haifei Luo
2021-04-12 19:33 ` Ori Kam
2021-04-13 4:38 ` Ajit Khaparde
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-13 16:36 ` Ajit Khaparde
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 3/5] common/mlx5: add mlx5 APIs " Haifei Luo
2021-04-12 7:32 ` Slava Ovsiienko
2021-04-13 16:44 ` Kinsella, Ray
2021-04-14 2:40 ` Haifei Luo
2021-04-14 6:21 ` David Marchand
2021-04-14 6:23 ` Haifei Luo
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: " Haifei Luo
2021-04-12 7:29 ` Slava Ovsiienko
2021-04-12 7:37 ` Slava Ovsiienko
2021-04-13 1:29 ` Haifei Luo
2021-04-13 7:22 ` Haifei Luo
2021-04-13 7:39 ` Slava Ovsiienko
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 5/5] doc: add single flow dump to guides Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 0/3] support single flow dump Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 1/3] ethdev: modify rte API for " Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 8:23 ` Ferruh Yigit
2021-04-14 8:25 ` Haifei Luo
2021-04-14 10:00 ` Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 0/3] support single flow dump Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for " Haifei Luo
2021-04-14 8:57 ` Thomas Monjalon [this message]
2021-04-14 9:10 ` Haifei Luo
2021-04-14 9:01 ` Thomas Monjalon
2021-04-14 9:07 ` Haifei Luo
2021-04-14 9:31 ` Thomas Monjalon
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 9:15 ` Ferruh Yigit
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 0/3] support single flow dump Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 1/3] ethdev: dump single flow rule Haifei Luo
2021-04-14 10:33 ` Thomas Monjalon
2021-04-14 10:37 ` Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 10:19 ` [dpdk-dev] [PATCH v6 0/2] single flow dump Haifei Luo
2021-04-14 10:19 ` [dpdk-dev] [PATCH v6 1/2] ethdev: dump single flow rule Haifei Luo
2021-04-14 10:20 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 11:26 ` [dpdk-dev] [PATCH v6 0/2] single flow dump Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5011689.uK669MFXqd@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haifeil@nvidia.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=matan@nvidia.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).