From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5117BA0562; Wed, 14 Apr 2021 10:57:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A104161872; Wed, 14 Apr 2021 10:57:39 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id A390D161858 for ; Wed, 14 Apr 2021 10:57:38 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 328DE58051E; Wed, 14 Apr 2021 04:57:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 04:57:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Q3dSqMw0p5y2m+SSgMzC3XtRF6nzR1ymPATQLlIk+VM=; b=tpXPNYojJUdfD1mH Qj1W6GpJofueVVlx/SCOUI3JUbstIVnB/FiyS6Ff+C7hRquGK6N3vYgBXTSwJwjW ci9pjLUQdDQv0BkJzhtQb9pw5AKy9PNrMtkaMMAMLN7RpOXcd1j78893bbisXT7X t2NmuwPYVOwKilWo2Lt+UAd4/cnDeo3RPEK/A4zNFPMWrkKUjHxS6kn7mEREbtK0 gUGCfq/gEF7JG1kL3stG1AbpFI+63ECTYWeIaNupe2+Xc69YTypptlv4Mtn04UxN nJnLKfXofeWcioLaWu3XOpRri5YjwKgTjvOTp/pX1COm41XGIFYiUavKkJjXFYk7 +Dvyhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Q3dSqMw0p5y2m+SSgMzC3XtRF6nzR1ymPATQLlIk+ VM=; b=rsabXple6SDD3ejI0PJQ2q1xdfDFppAy+Cs887+v0CHOccRzpCGP997Xp td9n0rjOnSbTuPPWRIhsBPHdp6poWa2qRpEYQt5ZwbG19K1hlL7qHwQx/gD9gPQA meoxpey9PJGTqNrN4MlOfcm6SBBXARLQERTe17BG/jXNtEnvZf67mc125RmXTreS 11H9cfe7BjWu1i3L6ORIQ8B9avY7PnwGPRkzXclIsmEfWVGGF2eCQtPO4Y1QbKl6 rtITSLncNq0PVqtyVqGRmdDZs3R85T97UeS/1ld305hWzJAHMPGBWG1RK0jmH0Qp KkSv6me4d/mUn/jEE3IUTCBNlamVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EE0C7240057; Wed, 14 Apr 2021 04:57:35 -0400 (EDT) From: Thomas Monjalon To: Haifei Luo Cc: dev@dpdk.org, orika@nvidia.com, viacheslavo@nvidia.com, rasland@nvidia.com, xuemingl@nvidia.com, haifeil@nvidia.com, ajit.khaparde@broadcom.com, Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Date: Wed, 14 Apr 2021 10:57:34 +0200 Message-ID: <5011689.uK669MFXqd@thomas> In-Reply-To: <1618389706-183883-2-git-send-email-haifeil@nvidia.com> References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-2-git-send-email-haifeil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" About the title, what is "rte API"? I guess you mean DPDK API with rte prefix. But given all DPDK API have rte prefix, and this patch is for DPDK, you can just say "API". So the title can be: ethdev: modify API for single flow dump But it can look as single flow dump was possible before, which is wrong because it is a new feature. Another idea is wrong: The packets of the flow are not dumped, it is only dumping the HW representation of the flow rule. I propose to simply describe the new feature: ethdev: dump single flow rule > + * @param[in] flow > + * The pointer of rte flow. Please replace "rte flow" with 'flow rule". Is it allowed to pass NULL? Will it dump all? If yes, you can change to: Flow rule to dump. Dump all rules if NULL.