From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ori Kam <orika@nvidia.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros
Date: Thu, 7 Oct 2021 12:07:18 +0100 [thread overview]
Message-ID: <501a1761-cbb2-3334-a314-4e9ae081b0d5@intel.com> (raw)
In-Reply-To: <20210923093916.3050958-1-thomas@monjalon.net>
On 9/23/2021 10:39 AM, Thomas Monjalon wrote:
> The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts.
> The macro UINT64C is also used to replace remaining occurrences of ULL.
>
> Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason.
>
> The API of rte_mtr and rte_tm is using enums for 64-bit variables.
> As they are enums, RTE_BIT32 is used.
> The corresponding struct members should be converted to 32-bit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: use RTE_BIT32 in enums
Hi Thomas,
Can you rebase on top of latest main, this conflict with adding doxygen
group comment patch:
Commit 0ce56b057b5c ("ethdev: group constant definitions in Doxygen")
next prev parent reply other threads:[~2021-10-07 11:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 21:04 [dpdk-dev] [PATCH] " Thomas Monjalon
2021-09-16 6:52 ` Andrew Rybchenko
2021-09-16 8:55 ` Thomas Monjalon
2021-09-16 9:36 ` Andrew Rybchenko
2021-09-23 9:39 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-10-05 19:18 ` Thomas Monjalon
2021-10-07 10:07 ` Andrew Rybchenko
2021-10-07 11:07 ` Ferruh Yigit [this message]
2021-10-07 13:26 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-10-07 14:11 ` Thomas Monjalon
2021-10-07 15:48 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-10-07 17:32 ` Ferruh Yigit
2021-10-07 18:29 ` Thomas Monjalon
2021-10-13 7:52 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2021-10-13 11:29 ` Ferruh Yigit
2021-10-20 14:55 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-20 17:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501a1761-cbb2-3334-a314-4e9ae081b0d5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).