From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87B92A0C47; Thu, 7 Oct 2021 13:07:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A49411B9; Thu, 7 Oct 2021 13:07:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 5796E411AD for ; Thu, 7 Oct 2021 13:07:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="312431877" X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="312431877" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 04:07:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="560531293" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 07 Oct 2021 04:07:26 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 04:07:26 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 04:07:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 04:07:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 04:07:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX3g1Hxg7ULKxZIzMWJs2ueo5QoSWAquHrqoSl3IKNFESERFobaI++/Cr2AlKxg57zZ7SjZe6S6H2w/FmPbyz/l41UI2/eZW741Ym1MEpY7rs5V1koOECpbqxeM3w9abbO4mKBrjcRGknmyl57OJgoB8Y+uzu3qW0UjJU8QZzbD7G6ZdnZkyMQzq3oAVeqY3vW9eECQURW2D76cys55hJt/GVE8i5cwyG3qjbfi6OX8pG4pmcq7/Z96a9ROUxda7zcd8WXTsooz86TAMYca0AmQYyMBGY03R36gREoSDUETZXW/ma1iWxbY1bABk5Tw+D0OCSx6Eilc9rjjzFQSatQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=umYtUm03S776MOWF/lHSu7+Nib10L4OsGXgyodd8jFM=; b=Znm0U37rQ60sIqK9XiYWO1FqSnWuyiu7PHyc1Aqn9nCsCsTe4TOuJmvdZPacGl38ALziZg4+gLal220ToEJ0KwaYm38PlczCCqegtzMtBfRqa3njkaJQGNJosoghcw/hLqf7QtMlRh/bLI++tWanPUf6bz8ycG1Ndc8KjwwdxQV7NGqRqclJzpDKE9lWLFQPQiDnJ78AZpAhRFgfOp5PxEYubTBx3ZCKJzY6erNfBQAVqjJQ8J9G8EBZCKo4riJ8zp3T/eQPUkdjNtAzcfowLpI/tJ37bih5UHl0iU9UxMQ/h3j+mQUUsZoYxwtO0eHV8IJbSewa0r1eyivUbYJ/kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=umYtUm03S776MOWF/lHSu7+Nib10L4OsGXgyodd8jFM=; b=VZOfO2OYPaejsmGWNsbEbZFcybD7GBG4mmp9ELl2sa+2BKysU405dndniQ/c8XLEjJbbMqgC414QROkpqyXKHAgZ/9f/EGVHiKWX6WuMzKm6s09qG84zI8D09jSqn6VXGcqyxBc92dVl+Tf25ZZnn+Ne1yKnQRIWmXbW6TiWDqY= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB2631.namprd11.prod.outlook.com (2603:10b6:a02:be::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 7 Oct 2021 11:07:24 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a%8]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021 11:07:24 +0000 Message-ID: <501a1761-cbb2-3334-a314-4e9ae081b0d5@intel.com> Date: Thu, 7 Oct 2021 12:07:18 +0100 Content-Language: en-US To: Thomas Monjalon , CC: Andrew Rybchenko , Ori Kam , Cristian Dumitrescu References: <20210915210444.3126008-1-thomas@monjalon.net> <20210923093916.3050958-1-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20210923093916.3050958-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0159.eurprd04.prod.outlook.com (2603:10a6:10:2b0::14) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0159.eurprd04.prod.outlook.com (2603:10a6:10:2b0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 11:07:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54d1cd81-6929-4d59-e296-08d98982a429 X-MS-TrafficTypeDiagnostic: BYAPR11MB2631: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PxlqL8T2yN6SSob8ZYTMFV/knszyIDD2+VCD8YrUbFeDrpiSrSbsSsWI0GROPskbmboDRxZQvs9FbhGslSTlU7CjPZgweOddDKhR+Gwddvj92GsyQX4kkfgyfojEhfJmC9cFjxsv1IR1vO2psy2n9ZwqWrc8PGN4mmLbZSRU9awege+H8QkRm1WFYp6cdSGlxq5ShkzsWUhEylnzBVd7MQJ0HG6Mcxgn98DW86KPli5EWpFrMoneMpyaF16+yQuMCnZvkTXKuU2Wp2Yq+NdjhDidUO/SVGr2z2676Gf7Goll2yHEOVj06oMM4X7deqlNw9e0GOzcNdblnh/LJbxaWEqJYodyBxLbORaUdqhJ6m4IXXwujSD85NyeiPCJleYRztp/RQXcYYGpjgp41IC3lKJfVJQTu2MSeVPs3YJhGG1aIWYc5R4h1J9yUZOwJWmMZQpIcn9VuLwXa15m9BFa8pQbS/eyWQUrpk8lLWu1EkN0muCNEMfIGhQRncb55CVNmDe904PrGgziwIKdZZVZezm0pKXtuEsBLnI0N052L3VwM994YPNAsJpEiUNKxCVssWFLRVOA5oOUwkQUbWf8Qqey1wBrygCv1hAPe/vcOr3DdB1sOSWh/80jh5rx0hdc3arhzH5WAJQY89OJZFL7E6wYE6pE1+h7ZelkuTR7TQnpoPcCMtlTDWgjRPFtUAHfs9EncN2tD8RLYKC/WZeGeg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(956004)(26005)(36756003)(186003)(8676002)(8936002)(54906003)(4744005)(2906002)(38100700002)(4326008)(86362001)(6486002)(16576012)(66946007)(5660300002)(44832011)(31686004)(31696002)(316002)(107886003)(508600001)(66556008)(53546011)(2616005)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlNkQ0djZlJPVVVUaStLNHV1cmZsTFd2RUt2R1Q0R1RCVWJBMkFobW5LeHY1?= =?utf-8?B?T3hFYnFKVk1qQ2gvS1RWU0xJcVNCdUd0ZTdEUlh1dXVaMXBpM3V1a1gvOEwz?= =?utf-8?B?eVRQbkNxV2oyQk9vaGN5U2Q5dHZ0azBhNVVQTzlLbHI5aWhlT1Rway9aNGht?= =?utf-8?B?VzVJTFhrMlFEUjlyTlNqQzBOOWVPTEw0SDNYZ0ZjQjYrTnpLaHdOQWJHWkRq?= =?utf-8?B?WDlYa09YblBSeUczTmxHek1KbTZGOWQrKy95YTVNTUJOSDh6NU5MY2FmZDlR?= =?utf-8?B?WDQ1SEpQYXlLQ3BZNjVmQUxhYXRUY0RrV3N0NDBtbCtVK0tSSnRuS0E1UkFi?= =?utf-8?B?WVpDSWxENGJsSEFSZWhoazlpNG9wOG1DekM1bUxKRjNGaWgwL29WMFdwNjJs?= =?utf-8?B?bFNoeDhnY25YcHBnVzV3T1FjbklGc2ppTXdubXZzd0JVVXdCa0hKajlXZGhV?= =?utf-8?B?aDZYMTJBL3dVbllWK2lMaW45a05id1BMS1dkVkNMZ0x0VGU5MWd6WEMwN1lt?= =?utf-8?B?TXM0UTBGT0xxWWF2VG1EMDlZb21ISXc0cHJ2aTNUNXN2bHdNYno5aFROVTha?= =?utf-8?B?enh4TVlHOE1uSEo4Yjk2NmFiSmhJRHJ4dWthcmV5alp1TjRvM0N2b0xYOGVi?= =?utf-8?B?RHFTN1JJVXoweWl1TUdqRUZJbldrdXZSbVVBV3d1ZUNXS21nQm9DYUpUTlhR?= =?utf-8?B?Ky9IMkZEMmlPdm94ZnMxTkQ1ZHllek05cWEvVklRTzFXZktaNlhQT3VXUzRx?= =?utf-8?B?WEdvTndYbUlyVk5Gd3dmcU9SUkpodjN6aU9WdlNOYnFBL3U5aC9oNUhQT0Zl?= =?utf-8?B?dDVSVVlNZEZLZGZCb3IvMWhXZkJKTTZTMGZlUkNaeDVxWVpqek5Kc2dkWTc3?= =?utf-8?B?UitydjJmM2RYVEZobVNMTWJCNExGMVdiTUNzdXJ2WnFqRklwRkEvQzcwczh6?= =?utf-8?B?enhabGV2Ui9IUzVxRVBHeWl4aExWUVFMUzZ2L1Z4a3djWVVWL1VoL1lqZ0N3?= =?utf-8?B?ZjJFek9xYWdjUEtrS3lEeWhVckdkYVRKRjY5QnZJbE5sbUpKV2VHeHRWcHFv?= =?utf-8?B?b2YxMjFTblc5UkcvREs1LzZQNFgxSVFlOGRZbm5FQm55dE45VmJlSDRHSnZq?= =?utf-8?B?RWRYN2EzQVlVK3ZZV3NxRDlvWmpocmRjSENRZHczMXJ0U21wMWF2YWEya3FB?= =?utf-8?B?b1dEdkZobEpMcnpPR2ZxZmpQS3ptUCtqN2ZTZHpqZjdybXBiV2VXaytiaklr?= =?utf-8?B?L2pzbHhLbTB2QkJIb09mRDcrNjRSY0xINVROZm1TSzZDU2RQT2pHSEt2T09S?= =?utf-8?B?UjdRQ3Z2R2t0STlHSnhrMWdWRGxoRlZEZ3pRcjFPVThwV3Z2WWhxWE05bGtC?= =?utf-8?B?MjJ6OStNaFhUemF3blRZTWUvZUlOSHA4OTBSbVBwMlA5ZlhKUk9FbHhzYnU0?= =?utf-8?B?cXZuUWhwWFpzQXVaOGcweWJ3T2xLcmJZbDFoQ3V2eEJBZFY3RkdpdDNCSDdO?= =?utf-8?B?YWFaNXNqL21FQkYrWjR4UFdQei90N0l4NklBOE9NcldSd3JRdVU2QTB4YlRF?= =?utf-8?B?QjN3QVdTcHdaY2pSNW1WcXZoeGpHSXdwTkhybS9JanZyajFxOTRGUDY3bkxT?= =?utf-8?B?WTYwU0pMYUdQZGhmMUtnK20ybk8xRTY3R1FuMktPU0I1SnNxcklJRVdNbzdz?= =?utf-8?B?N1g0UDA5Mk92WE5aZWdXZ3lWTHo1Mmg3TVFvSnM4elBvVG5KSStGcEZBVFNM?= =?utf-8?Q?3mcE53v/UxHN+6Z1ifmcErOF6YOh7VPik1ca4Nf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 54d1cd81-6929-4d59-e296-08d98982a429 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 11:07:24.4977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b92zVdZ0LS7xfsD/UdpYCKdewyaEL0l3960Q1f53b9hFMD0LJ62/twfZ1lHLOegqkENUcwlOQPeHj56EEAoA/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2631 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 10:39 AM, Thomas Monjalon wrote: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums for 64-bit variables. > As they are enums, RTE_BIT32 is used. > The corresponding struct members should be converted to 32-bit. > > Signed-off-by: Thomas Monjalon > --- > v2: use RTE_BIT32 in enums Hi Thomas, Can you rebase on top of latest main, this conflict with adding doxygen group comment patch: Commit 0ce56b057b5c ("ethdev: group constant definitions in Doxygen")