* [dpdk-dev] [PATCH] app: fix proc_info app dependency
@ 2018-01-12 14:17 Anatoly Burakov
2018-01-12 14:59 ` Thomas Monjalon
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
0 siblings, 2 replies; 9+ messages in thread
From: Anatoly Burakov @ 2018-01-12 14:17 UTC (permalink / raw)
To: dev; +Cc: maryam.tahhan, stable
proc_info app is compiled unconditionally on Linux, but it's
actually dependent on librte_ethdev library, which prevents
DPDK from building without librte_ethdev library enabled.
Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
Cc: maryam.tahhan@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/Makefile b/app/Makefile
index 24c9067..d7fc26d 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -4,7 +4,9 @@
include $(RTE_SDK)/mk/rte.vars.mk
DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
+ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
+DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
+endif
DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency
2018-01-12 14:17 [dpdk-dev] [PATCH] app: fix proc_info app dependency Anatoly Burakov
@ 2018-01-12 14:59 ` Thomas Monjalon
2018-01-12 15:04 ` Burakov, Anatoly
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2018-01-12 14:59 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, maryam.tahhan, stable
12/01/2018 15:17, Anatoly Burakov:
> proc_info app is compiled unconditionally on Linux, but it's
> actually dependent on librte_ethdev library, which prevents
> DPDK from building without librte_ethdev library enabled.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
nit: please insert a blank line here
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
> +endif
> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
What about pdump and testpmd?
I guess a lot of things do not compile without ethdev, isn't it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency
2018-01-12 14:59 ` Thomas Monjalon
@ 2018-01-12 15:04 ` Burakov, Anatoly
2018-01-12 15:41 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Burakov, Anatoly @ 2018-01-12 15:04 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, maryam.tahhan, stable
On 12-Jan-18 2:59 PM, Thomas Monjalon wrote:
> 12/01/2018 15:17, Anatoly Burakov:
>> proc_info app is compiled unconditionally on Linux, but it's
>> actually dependent on librte_ethdev library, which prevents
>> DPDK from building without librte_ethdev library enabled.
>>
>> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
>> Cc: maryam.tahhan@intel.com
>> Cc: stable@dpdk.org
>
> nit: please insert a blank line here
>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
>> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
>> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
>> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
>> +endif
>> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
>
> What about pdump and testpmd?
>
> I guess a lot of things do not compile without ethdev, isn't it?
>
True, however one can still disable testpmd compilation with a config
option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a
new config option (i.e. CONFIG_RTE_PROC_INFO)?
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency
2018-01-12 15:04 ` Burakov, Anatoly
@ 2018-01-12 15:41 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2018-01-12 15:41 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: dev, maryam.tahhan, stable
12/01/2018 16:04, Burakov, Anatoly:
> On 12-Jan-18 2:59 PM, Thomas Monjalon wrote:
> > 12/01/2018 15:17, Anatoly Burakov:
> >> proc_info app is compiled unconditionally on Linux, but it's
> >> actually dependent on librte_ethdev library, which prevents
> >> DPDK from building without librte_ethdev library enabled.
> >>
> >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> >> Cc: maryam.tahhan@intel.com
> >> Cc: stable@dpdk.org
> >
> > nit: please insert a blank line here
> >
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> ---
> >> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
> >> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> >> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> >> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
> >> +endif
> >> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
> >
> > What about pdump and testpmd?
> >
> > I guess a lot of things do not compile without ethdev, isn't it?
> >
>
> True, however one can still disable testpmd compilation with a config
> option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a
> new config option (i.e. CONFIG_RTE_PROC_INFO)?
Yes, good idea.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file
2018-01-12 14:17 [dpdk-dev] [PATCH] app: fix proc_info app dependency Anatoly Burakov
2018-01-12 14:59 ` Thomas Monjalon
@ 2018-01-12 17:49 ` Anatoly Burakov
2018-01-12 18:02 ` Thomas Monjalon
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
1 sibling, 2 replies; 9+ messages in thread
From: Anatoly Burakov @ 2018-01-12 17:49 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, maryam.tahhan, stable
Unlike every other DPDK application's compilation, proc_info's
compilation cannot be turned off on Linux. Fix it by adding a
config option to base linuxapp config.
Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
Cc: maryam.tahhan@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/Makefile | 2 +-
config/common_linuxapp | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/Makefile b/app/Makefile
index 24c9067..aa44827 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -4,7 +4,7 @@
include $(RTE_SDK)/mk/rte.vars.mk
DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
+DIRS-$(CONFIG_RTE_PROC_INFO) += proc_info
DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 74c7d64..15c6961 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -50,3 +50,4 @@ CONFIG_RTE_LIBRTE_AVP_PMD=y
CONFIG_RTE_LIBRTE_NFP_PMD=y
CONFIG_RTE_LIBRTE_POWER=y
CONFIG_RTE_VIRTIO_USER=y
+CONFIG_RTE_PROC_INFO=y
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
@ 2018-01-12 18:02 ` Thomas Monjalon
2018-01-12 18:05 ` Burakov, Anatoly
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2018-01-12 18:02 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, maryam.tahhan, stable
12/01/2018 18:49, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/Makefile | 2 +-
> config/common_linuxapp | 1 +
You should also add the option in common_base (as disabled),
so we keep the list of almost every options in one place.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file
2018-01-12 18:02 ` Thomas Monjalon
@ 2018-01-12 18:05 ` Burakov, Anatoly
0 siblings, 0 replies; 9+ messages in thread
From: Burakov, Anatoly @ 2018-01-12 18:05 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, maryam.tahhan, stable
On 12-Jan-18 6:02 PM, Thomas Monjalon wrote:
> 12/01/2018 18:49, Anatoly Burakov:
>> Unlike every other DPDK application's compilation, proc_info's
>> compilation cannot be turned off on Linux. Fix it by adding a
>> config option to base linuxapp config.
>>
>> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
>> Cc: maryam.tahhan@intel.com
>> Cc: stable@dpdk.org
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> app/Makefile | 2 +-
>> config/common_linuxapp | 1 +
>
> You should also add the option in common_base (as disabled),
> so we keep the list of almost every options in one place.
>
Right, will fix.
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v3] app/procinfo: add compilation option in config file
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
2018-01-12 18:02 ` Thomas Monjalon
@ 2018-01-12 18:27 ` Anatoly Burakov
2018-01-17 18:45 ` Thomas Monjalon
1 sibling, 1 reply; 9+ messages in thread
From: Anatoly Burakov @ 2018-01-12 18:27 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, maryam.tahhan, stable
Unlike every other DPDK application's compilation, proc_info's
compilation cannot be turned off on Linux. Fix it by adding a
config option to base linuxapp config.
Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
Cc: maryam.tahhan@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
Notes:
v3: add config option to common_base and set it to 'n'
v2: use config option instead of depending on librte_ethdev
app/Makefile | 2 +-
config/common_base | 5 +++++
config/common_linuxapp | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/app/Makefile b/app/Makefile
index 24c9067..aa44827 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -4,7 +4,7 @@
include $(RTE_SDK)/mk/rte.vars.mk
DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
+DIRS-$(CONFIG_RTE_PROC_INFO) += proc_info
DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
diff --git a/config/common_base b/config/common_base
index e74febe..aca4e7b 100644
--- a/config/common_base
+++ b/config/common_base
@@ -805,6 +805,11 @@ CONFIG_RTE_APP_TEST=y
CONFIG_RTE_APP_TEST_RESOURCE_TAR=n
#
+# Compile the procinfo application
+#
+CONFIG_RTE_PROC_INFO=n
+
+#
# Compile the PMD test application
#
CONFIG_RTE_TEST_PMD=y
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 74c7d64..15c6961 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -50,3 +50,4 @@ CONFIG_RTE_LIBRTE_AVP_PMD=y
CONFIG_RTE_LIBRTE_NFP_PMD=y
CONFIG_RTE_LIBRTE_POWER=y
CONFIG_RTE_VIRTIO_USER=y
+CONFIG_RTE_PROC_INFO=y
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v3] app/procinfo: add compilation option in config file
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
@ 2018-01-17 18:45 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2018-01-17 18:45 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, maryam.tahhan, stable
12/01/2018 19:27, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-17 18:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 14:17 [dpdk-dev] [PATCH] app: fix proc_info app dependency Anatoly Burakov
2018-01-12 14:59 ` Thomas Monjalon
2018-01-12 15:04 ` Burakov, Anatoly
2018-01-12 15:41 ` Thomas Monjalon
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
2018-01-12 18:02 ` Thomas Monjalon
2018-01-12 18:05 ` Burakov, Anatoly
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2018-01-17 18:45 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).