Re: [dpdk-dev] [PATCH 03/10] eal: fix header guards

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Thanks for your review, Bruce.
More comments below.

2014-11-25 10:28, Bruce Richardson:
> On Sat, Nov 22, 2014 at 10:43:35PM +0100, Thomas Monjalon wrote:
> > Some guards are missing or have a wrong name.
> > Others have LINUXAPP in their name but are now common.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> One minor comment below.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
[...]
> > -#ifndef _EAL_LINUXAPP_FILESYSTEM_H
> > -#define _EAL_LINUXAPP_FILESYSTEM_H
> > +#ifndef EAL_FILESYSTEM_H
> > +#define EAL_FILESYSTEM_H
> >  
> >  /** Path of rte config file. */
> >  #define RUNTIME_CONFIG_FMT "%s/.%s_config"
> 
> no ending comment for #endif - should one be added for completeness?
> 
> > @@ -115,4 +115,4 @@ eal_get_hugefile_temp_path(char *buffer, size_t buflen, const char *hugedir, int
> >   * Used to read information from files on /sys */
> >  int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> >  
> > -#endif /* _EAL_LINUXAPP_FILESYSTEM_H */
> > +#endif /* EAL_FILESYSTEM_H */

The ending comment is here.

> > --- a/lib/librte_eal/common/eal_internal_cfg.h
> > +++ b/lib/librte_eal/common/eal_internal_cfg.h
> > @@ -36,8 +36,8 @@
> >   * Holds the structures for the eal internal configuration
> >   */
> >  
> > -#ifndef _EAL_LINUXAPP_INTERNAL_CFG
> > -#define _EAL_LINUXAPP_INTERNAL_CFG
> > +#ifndef EAL_INTERNAL_CFG_H
> > +#define EAL_INTERNAL_CFG_H
> >  
> >  #include <rte_eal.h>
> >  #include <rte_pci_dev_feature_defs.h>

I've added an ending comment for this file.
Is it the one you thought about?

-- 
Thomas