From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 9C2C32E8B for ; Tue, 25 Nov 2014 13:13:28 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id bs8so8947609wib.4 for ; Tue, 25 Nov 2014 04:24:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/VT7l0bMFIht/zAhOmggW/nxy2+QgtvKOJ2kdl+Bkjs=; b=BcgfnmMKlPw2crq9kL/P4WYQ5Yd4/H/uk0K2OV3+Sd0J2wQMj0DV19sSHT6FSlpbm3 buMIsv47kO+pgRgDyw2J22MYbdG947lSMO0go7i98VPDh7o6k/dW4nCDh1VqMPsNPVU9 2y/dorOq3DalXVa73/XPVCYlzPBt3s/YIP0eKchm0FmZ4PrC8RZdCou8HamhlGlrXVP3 w/hn9JmyAanKipSJY/bUkgAYiFujLum7wMcSVcEoQWO1fGE07pCs9htG4XzA0AHaGxBv iySnkXk2GUnrB+JBeHOmj5z+eNsEdOtr3zvU6uFwuIdgmrctKzQojNOl9N9hgGSqxM3B sMgg== X-Gm-Message-State: ALoCoQlrKqLv2AQREiMcAg43tCINkHv2jlPDx3nrtqgu2Ps8pJ08meK0B/EEETIFvrzxStq9s3tK X-Received: by 10.180.228.72 with SMTP id sg8mr20509739wic.48.1416918260675; Tue, 25 Nov 2014 04:24:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id c5sm2629765wik.3.2014.11.25.04.24.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Nov 2014 04:24:20 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Tue, 25 Nov 2014 13:23:55 +0100 Message-ID: <5027116.j4eGpnoEV0@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20141125102812.GC5260@bricha3-MOBL3> References: <1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com> <1416692622-28886-4-git-send-email-thomas.monjalon@6wind.com> <20141125102812.GC5260@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 03/10] eal: fix header guards X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 12:13:28 -0000 Thanks for your review, Bruce. More comments below. 2014-11-25 10:28, Bruce Richardson: > On Sat, Nov 22, 2014 at 10:43:35PM +0100, Thomas Monjalon wrote: > > Some guards are missing or have a wrong name. > > Others have LINUXAPP in their name but are now common. > > > > Signed-off-by: Thomas Monjalon > > One minor comment below. > > Acked-by: Bruce Richardson [...] > > -#ifndef _EAL_LINUXAPP_FILESYSTEM_H > > -#define _EAL_LINUXAPP_FILESYSTEM_H > > +#ifndef EAL_FILESYSTEM_H > > +#define EAL_FILESYSTEM_H > > > > /** Path of rte config file. */ > > #define RUNTIME_CONFIG_FMT "%s/.%s_config" > > no ending comment for #endif - should one be added for completeness? > > > @@ -115,4 +115,4 @@ eal_get_hugefile_temp_path(char *buffer, size_t buflen, const char *hugedir, int > > * Used to read information from files on /sys */ > > int eal_parse_sysfs_value(const char *filename, unsigned long *val); > > > > -#endif /* _EAL_LINUXAPP_FILESYSTEM_H */ > > +#endif /* EAL_FILESYSTEM_H */ The ending comment is here. > > --- a/lib/librte_eal/common/eal_internal_cfg.h > > +++ b/lib/librte_eal/common/eal_internal_cfg.h > > @@ -36,8 +36,8 @@ > > * Holds the structures for the eal internal configuration > > */ > > > > -#ifndef _EAL_LINUXAPP_INTERNAL_CFG > > -#define _EAL_LINUXAPP_INTERNAL_CFG > > +#ifndef EAL_INTERNAL_CFG_H > > +#define EAL_INTERNAL_CFG_H > > > > #include > > #include I've added an ending comment for this file. Is it the one you thought about? -- Thomas