DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix
Date: Thu, 06 Nov 2014 09:37:08 +0100
Message-ID: <5037229.OQFgQMz1y9@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2E2766@SHSMSX101.ccr.corp.intel.com>

2014-11-06 00:22, Xie, Huawei:
> Thomas, comments for this patch?

No, but Jing Chen made some comments that you didn't replied:
	"Please try to use macro to replace numbers."
So I wait a v2.

> > -----Original Message-----
> > From: Xie, Huawei
> > Sent: Saturday, September 27, 2014 10:49 PM
> > To: dev@dpdk.org
> > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin
> > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix
> > 
> > the right shift bits should be 5 rather than 4.
> >     vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F)
> > 
> > Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> > CC: Jing Chen <jing.d.chen@intel.com>
> > CC: Helin Zhang <helin.zhang@intel.com>
> > 
> > ---
> >  lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> > b/lib/librte_pmd_i40e/i40e_ethdev.c
> > index 9009bd4..9c9d831 100644
> > --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi,
> >  {
> >  	uint32_t vid_idx, vid_bit;
> > 
> > -#define UINT32_BIT_MASK      0x1F
> > -#define VALID_VLAN_BIT_MASK  0xFFF
> >  	/* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the
> >  	 *  element first, then find the bits it belongs to
> >  	 */
> > -	vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >>
> > -		  sizeof(uint32_t));
> > -	vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK));
> > +	vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F);
> > +	vid_bit = (uint32_t) (1 << (vlan_id & 0x1F));
> > 
> >  	if (on)
> >  		vsi->vfta[vid_idx] |= vid_bit;
> > --
> > 1.8.1.4

      reply	other threads:[~2014-11-06  8:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  5:49 Huawei Xie
2014-10-11  7:20 ` Chen, Jing D
2014-11-06  0:22 ` Xie, Huawei
2014-11-06  8:37   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5037229.OQFgQMz1y9@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git