From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id AED418001
 for <dev@dpdk.org>; Sun, 23 Nov 2014 16:08:51 +0100 (CET)
Received: by mail-wi0-f170.google.com with SMTP id bs8so6747472wib.3
 for <dev@dpdk.org>; Sun, 23 Nov 2014 07:19:35 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=pnx2KfsvbnfvbD/0LP0layGocRqgAxr2YDGVZIN0HlI=;
 b=Yp3+MI53ZrnhNiVY/G9fdnKNjP65EbHaSm2+g03JwIyvLsn2Q96gyW/eMB4O/NOK9N
 YJ0GTNqMz8tkk12JkeBrAq1OsJAbmWut0Iwa3saOHJE7YerYVrUBmOITyVQL0PcH8rQs
 slZMNdwKrjCKNRZ+nIWkC9REQJ56SAxqeaLA6xeiAsehK3hdC8dPEWfFljxfo7CZCMor
 NV2Y8k4pgXyFIH+oq3iNZtBA8FIswKiZU89kEGPVTzwRblPc8K9ldPsFs3BFGB4mxKU8
 1Tb3EsKIpm2p/pskMqzj7Bc1C+4eGvlwve9fl8IFirCYqu0WkrnP85263AmHtKEUYCTJ
 MWwQ==
X-Gm-Message-State: ALoCoQnFZ4YX1C/c1bOy7j6uU3VCl4iZgFZGNNOBoO5NLAgTUylA/lrZ5hvoxhvzX2oRZfYqvcwy
X-Received: by 10.180.85.198 with SMTP id j6mr13564657wiz.23.1416755975422;
 Sun, 23 Nov 2014 07:19:35 -0800 (PST)
Received: from xps13.localnet (108.26.90.92.rev.sfr.net. [92.90.26.108])
 by mx.google.com with ESMTPSA id lp14sm7753950wic.20.2014.11.23.07.19.33
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 23 Nov 2014 07:19:34 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Date: Sun, 23 Nov 2014 14:40:43 +0100
Message-ID: <5038013.rIESZ4PvDY@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <3280901.SpGJMfTadq@xps13>
References: <1413291597-27326-1-git-send-email-declan.doherty@intel.com>
 <345C63BAECC1AD42A2EC8C63AFFC3ADC27422D1C@IRSMSX101.ger.corp.intel.com>
 <3280901.SpGJMfTadq@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 0/8] link bonding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2014 15:08:51 -0000

2014-11-21 19:36, Thomas Monjalon:
> 2014-11-21 17:07, Doherty, Declan:
> > Hey Thomas, have you had a chance to have a look at this patchset, if you
> > have any comments or issues can you let me know asap, as the patch sets for
> > link bonding modes 4 & 5 are dependent on this set and I don't want to be
> > blocking them from the next release candidate.
> 
> Declan, your patchset doesn't touch anything else than the bonding area
> (except socket_id parameter in testpmd), it is acked and it has a test
> report since today.
> You are the author (and implicit maintainer) of bonding, so I consider
> I don't need to review this patchset.
> 
> Conclusion: yes, it should be applied shortly.

Actually no, checkpatch says this patchset is not ready.
Some errors:
TYPO_SPELLING: 'interupt' may be misspelled - perhaps 'interrupt'?
TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'?
BRACES: braces {} are not necessary for single statement blocks
SPACING: space prohibited before semicolon
MISSING_SPACE: break quoted strings at a space character
TRAILING_SEMICOLON: macros should not use a trailing semicolon
SPACING: space prohibited after that open parenthesis '('

Please fix and send a v7.
Thanks
-- 
Thomas