From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0575AA0C43; Mon, 15 Nov 2021 10:44:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7829740E01; Mon, 15 Nov 2021 10:44:15 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 6290F40141 for ; Mon, 15 Nov 2021 10:44:13 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="214134562" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="214134562" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 01:44:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="671449569" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 15 Nov 2021 01:44:11 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 01:44:10 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 01:44:10 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 01:44:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0401l9EmjPVEVemcifJKc1gZZlJxn4SbRmLNkZdnWoPlofg9TT+oLUwzpy/IXtoBKZIb3Q6egoX4ZmNvNSwzPJwdMgLkCfpRfmlHbqka2niVSRhv/2ocTbQHENnr+JnmGnZHj0rKxR9DAZimf0f+NI7/IORoX39pZUuA6xFKGvtXzHA4fIu25xGwSxvnBkDPeCl/TCZ7UYgvTYZ6H+NHcwkS4REb61XBERroks3cHVfuCNAPMdg/DCgw9TtxAW+3Z17zpfPpkmuFJKmJvpq4vcTZB/z2ed1G4fzgfgiDVZIk3IX0rmAzNSr5LJ/rFwTvrKjLdt6CSYHcb4RidxNFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tii7wQDroIwDuZOmKlIQWhwolGWjRJ/1J0oD7nGSGaw=; b=I3kn9H0BgE6XAXBuo6lu5uveRsPALPU+E1+lSBmc0Dr695T/KW0QTED4H0wuFa9AbiSabMBjXlrUekCua4hmfWR4PviwHOldR1sdNve4tZ5FFjQtLjQaz2h/lw3QO4sS91AUxNpsRKzx/x2Jj0nYq6PG2286VS6Tm2U4RN77PcwDmQWGWjZtxCw6AS1TJmYCwBoOmKW6EZkTGtIotZwziPBnHuZF6hRFIklh/Oov7RZCdHPvEyhNwGqMgMg6NV68bi6Ppp56/Om/XiMIg2IixwmTZ/YlGfZNYrdB5nPF+8kEOkbqJwXjLkHCXAi4D5ldxYA/jFswS9z8rLquwa6ddA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tii7wQDroIwDuZOmKlIQWhwolGWjRJ/1J0oD7nGSGaw=; b=gFvAHLkyrsqpFmXZacm8skvC3dnJzc0c8ZYEYIF08c7cKRnfPqGKHOTkLfZMYkHogGWyJHlxIFQR2vuqymBOG3RbsHQUKuYA8dVFNkQ+bu/1foOXed9FLU4MFQ6CPiwGxwRa0FD2QQc8jwN+SLdkXlUl8rZeoIfdqCjWDfLf8nA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.25; Mon, 15 Nov 2021 09:44:09 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 09:44:09 +0000 Message-ID: <503b1536-7c0a-f967-6b83-e64be6f626eb@intel.com> Date: Mon, 15 Nov 2021 09:44:03 +0000 Content-Language: en-US To: Apeksha Gupta , CC: , , , , References: <20211113043141.18888-2-apeksha.gupta@nxp.com> <20211115071940.12942-1-apeksha.gupta@nxp.com> From: Ferruh Yigit Subject: Re: [PATCH v11 0/5] drivers/net: add NXP ENETFEC driver X-User: ferruhy In-Reply-To: <20211115071940.12942-1-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0293.eurprd04.prod.outlook.com (2603:10a6:10:28c::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0293.eurprd04.prod.outlook.com (2603:10a6:10:28c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 09:44:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7331878a-8d89-4029-7a03-08d9a81c7911 X-MS-TrafficTypeDiagnostic: PH0PR11MB5093: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QsFhPI3RAE4DileoOa1SG/oXFZ9Fz1ch7gWrp9n8gQZ7L+S3XirPiWk11R7C8drwplzW/CJ7gxl/hX3jT4XNHQ+IODq4vC5Tplr6L2aO6f77egra3f1e9Y/pHdWKecG/ZQd53rf5nTBHJ+R+gz1dhNHabHYCZKfu9b4qWEF1zvGIgAUlpcPEtwigDbmveG7ZhZLenx5QRC0fBGJHpKTA+HIS1DaCFIuG58Gi9dj3kN7CabR6aPr7oiilwGLRdVLDdtTNtlGMfWOats+woXeaUiu5L8cyYg2fDIqSW3SqeHYMakj+5hjTJS9ehwLtFmog21tgcsXW+MOyc33MprxOooghL0hvXALBij/fWIBGAixWnim0l9lOReXiNRc1bFNUp/lUmbVuZWIT0JbWZRp+UzFNFyc2o9NBTirNtvFj2tf1sEvx4RaHjU3dnSAjy0jYyJQ1CwynrkanIyR06C4qbSl2D0ClqEth9zfSHJoj29u5keTF7u82Jq72O6T9+OtvGRmNuZoQH+YrGP04iLhgumGOm5aC6imPQqFXSGk3/sYvtvoKpjLp79JZWass7vEluO+Hm+0q3DsSqXp2wVmx6RRM0SCb4W9f8TDoHgr8pIe4agjQQOrggFcfEFMPQidluzl5d19T6KOXYEvZlwNKrovSphnvMwaCmzKvUxk8yqQFF+6+jJu4k/KQTbb1qvgRSX7oBg49xt5tM9FHTi6SpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(31686004)(26005)(186003)(2616005)(508600001)(38100700002)(36756003)(44832011)(66946007)(66476007)(6486002)(8936002)(86362001)(2906002)(66556008)(6666004)(53546011)(4326008)(83380400001)(5660300002)(316002)(16576012)(31696002)(8676002)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVU1NGFWc1hrdXJCOFJzWi9DbWZaQzVVRE5EZnNmNnZDOER6ejFpMTFtR0tQ?= =?utf-8?B?U1RrNlZUNEdiYVNWZUZ2Sjh3Z2JCTFVDMllteUdWMll4V0FRQzJoZUl3R1M4?= =?utf-8?B?SVZVUURlMUlMb2xlVlhxaUlkaWQvRUEzSzJiYjUxMHh5aFl5b3duc1hOR2xk?= =?utf-8?B?UGRXRFhKN1V5Zi83TFhhQUlOb1FLZUFWYmZCMW9QbnNpdEh6OERnQWlxaGtT?= =?utf-8?B?UlJPUFN6OFAwZGM4REFYZllwYmxzazV4bnd4VVlCa2prVVcvNDgvQjZSVmVB?= =?utf-8?B?RlJoNXdwcDE2OHhUVjVHTlQ1eDNFcDFLcC9YNlFBY0ZaRXhxVDdjN2RWRVdm?= =?utf-8?B?ajQwSmp6ZmhqbmNjZlY3VFQ4dCtHMGVjd2s4NjBnanRMWUtDc1RHREpQL0lI?= =?utf-8?B?ak5HRTc2ZkFTRXJ2L2FlTDM5WG5FSDBqYUJhVnFDKzBxMXZBcjMwWk5oOXlq?= =?utf-8?B?ekU5MldRZ2s0WTRGVTE4aWRqdm5rN1dMc1BuOFI3S0RacEdoTlViUGpIaFM1?= =?utf-8?B?YWtwcEl5cXF4Vjc2MS8wU3BXeVdJai8yTExScjBrZDR4Vjg5UDZhVG1tRVNO?= =?utf-8?B?bU40R2lKYmdaM3orRVprU1QveHhPU0l6dWgvcFVtYzExbHVaQWEya3Y3V05F?= =?utf-8?B?Z1YvYVBMM2FucGNselJ0eE5UNW85RUVGVVRtRnd3TjRzMW1LcEcvaUdLQ0U5?= =?utf-8?B?SXh3WDJ6UG8wTkMvbXU4d3lpeGRFUG4vUWx1b05XdkQwSlR5cUVydE1Wckh0?= =?utf-8?B?ZDQ2TmMxTUlOQXJJc0cwRFU5VllsaXZ6YWhlampNV2l2REpoM280aExZUTBr?= =?utf-8?B?VFVxUFAxUU9CWjJhSVdac2FqWkkyUlVBL1R1YThoQWFCOHJ0c3VtTnpySjZo?= =?utf-8?B?bENyMzdzU09iVmpkMUE3TlBBM3JKTEpTU0o4OUJRVk9CaCtVYjZ0Q1FiT2lm?= =?utf-8?B?YTI2YWhQR2pOemxkT0lUS1lrWUNWMTBMY3ZQVEQ0R0VWZWJ2MEZYTmhtM0Uw?= =?utf-8?B?cU96NnFXZlNTNlFOdVdBQ1BhRGVERThJL0FaNEowV3ZIRFBVNkZ2bitWS2Jy?= =?utf-8?B?am90bENYWThHTGwzN0Z5czdTNXNjb2ovSWZ1SUxISnpoSGdOZHB0NzZGaXh5?= =?utf-8?B?cWNQMStlamhSVWsrYkFUbXVrSm5XRm1kcDR3OTljd3VlRnhjSnVnZWhXdFN0?= =?utf-8?B?cGVHKzcrc2RNaUZXZ21tV2FJSlBIZUxFL3FEWlJWV2oxei92M244YVZpVUlv?= =?utf-8?B?ZFQ2NjFIUWV2UE1hRDQ0Y1FnMWVsU2hRelpnU1hxRkVGUUhRZzZIdWVWQXN1?= =?utf-8?B?ZmEwZ01JU1FteXJVdVZjMHNQT2hLUWNHY1pvem4rMkhsTDBqRGtKb2dYNTBH?= =?utf-8?B?YXEzU1hTRDhZVUlMZjFKSktiYXFLMFJxbmFwbk1YUWxvWXYremVVQStUM3Rn?= =?utf-8?B?YmVYRk5LUHVpNnB0bGN3UWdDLzk2YkFlNzFaaG1jOVdEblRrN0huUUhDOXY4?= =?utf-8?B?SnNTN0lseDVGSlFzaUFXalZnNityaXg2ZkpjVnphVHRwd01NQWVYQWVJM2tF?= =?utf-8?B?a2FSNjVGUk5neGFEZFpweXdqNERTNU1sS3RXWU51TG5kd2N4YVBSMnVkOEpw?= =?utf-8?B?V25hYXJTdS9MVHByTmdCc1pTUXEwWS9PbkNxaGlJbmFrSVY3cHI0YU1COFRp?= =?utf-8?B?SS9UUXUyb2E1SW5jb2N6SkdQSVFhVXB6aERlSEFZVzB4RjRIMmpBYnpnWDdh?= =?utf-8?B?YzhKVkxiL1pQcXlnY0Q0N2RNQXEvOVZGTnR3MDQzUC9nV1pEV0Rnd25kQ1dU?= =?utf-8?B?czltMGZDdnJDbmMvZ2JiWnU2a2tlZm9PYTBLTUttc0gyeEVLQXd1MFlwVUJt?= =?utf-8?B?bmJMdEkwR3NvUENCMXoveWNYaFNsdS9DRXhsVitNejQ4dEkySTZ2bGJ0UUxj?= =?utf-8?B?SlFJQmUrem9LSFR3SUFFZ3BTN3lUZ3FBWmxrVTZpcnBBTFgwYkZpQ3R0cStD?= =?utf-8?B?aXdnRVJQb21Mb0R0SUF4YjY0VG5CMjB2cEJWcHE5Ym1GUmM2T1U3T0ZEYzZY?= =?utf-8?B?UmZZenE0a05ZeTE4clFvcHNJSFVRZ0tYamRVU05vOXBSNHZpZmFXaElyOFd4?= =?utf-8?B?Q0h2bW9NS1FFTmhBTUJEanZySnlsRUc1QmZ4UjlJV0hZbUMxSUpYT3VIN1pR?= =?utf-8?Q?f3vkKQ6Rx6E5GAdF8AQjrmc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7331878a-8d89-4029-7a03-08d9a81c7911 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 09:44:09.5555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9WFXsyO/yuGF7W2+BqJ0nxu3iRh0FujmWuWSVljpoOIhCnDYDcy58EgrhFYGSaffQE+KgXgcYfD7RrzM/D/kbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5093 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 7:19 AM, Apeksha Gupta wrote: > This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet > Controller) is a network poll mode driver for the inbuilt NIC found in > the NXP i.MX 8M Mini SoC. > > An overview of the enetfec driver with probe and remove are in patch 1. > Patch 2 design UIO interface so that user space directly communicate with > a UIO based hardware device. UIO interface mmap the Control and Status > Registers (CSR) & BD memory in DPDK which is allocated in kernel and this > gives access to non-cacheble memory for BD. > > Patch 3 adds the RX/TX queue configuration setup operations. > Patch 4 adds enqueue and dequeue support. Also adds some basic features > like promiscuous enable, basic stats. > Patch 5 adds checksum and VLAN features. > > Apeksha Gupta (5): > net/enetfec: introduce NXP ENETFEC driver > net/enetfec: add UIO support > net/enetfec: support queue configuration > net/enetfec: add Rx/Tx support > net/enetfec: add features > Hi Apeksha, It would help if you can keep a changelog between versions, in the cover letter, for future. Also, there is a meson file warning, fyi: $ ./devtools/check-meson.py Error: Missing trailing "," in list at drivers/net/enetfec/meson.build:12