DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	pablo.de.lara.guarch@intel.com, yipeng1.wang@intel.com,
	gavin.hu@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH] hash: fix out-of-bound write while freeing key slot
Date: Fri, 21 Dec 2018 01:47:18 +0100	[thread overview]
Message-ID: <5048136.3VFI2TIjne@xps> (raw)
In-Reply-To: <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com>

20/12/2018 14:59, Bruce Richardson:
> On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote:
> > Add a debug check for out-of-bound write while freeing the key slot.
> > 
> > Coverity issue: 325733
> > Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency")
> > Cc: honnappa.nagarahalli@arm.com
> > 
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Steve Capper <steve.capper@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> >  lib/librte_hash/rte_cuckoo_hash.c |  4 ++++
> >  lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> While I think enqueuing a free slot should ever fail, I don't see an issue
> with having a check for that.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

      reply	other threads:[~2018-12-21  0:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  2:51 Honnappa Nagarahalli
2018-12-20 13:59 ` Bruce Richardson
2018-12-21  0:47   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5048136.3VFI2TIjne@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nd@arm.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).