From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66FCEA04B6; Tue, 13 Oct 2020 10:52:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D349C1D734; Tue, 13 Oct 2020 10:52:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5D3051D6F8 for ; Tue, 13 Oct 2020 10:52:11 +0200 (CEST) IronPort-SDR: 6A4Y02UPdxGXaUHeJZUkqfQ2ch6IDHKk4BcgCM9bAEIPCp1F4mAAKswx8vkQBGRQLg7dE5GSDW IQwEW/Ota8tw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="152807442" X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="152807442" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 01:52:09 -0700 IronPort-SDR: 96Fio+foKqZIsW7fp+WP3UymjbWm4/vLTsFMDPIjWfvA7Xuad6fhh2Uie0jvFyIaatetOTVqmK LhAsFWc7QvnQ== X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="530316040" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 01:52:08 -0700 To: Ciara Loftus , dev@dpdk.org References: <20201008091729.4321-1-ciara.loftus@intel.com> From: Ferruh Yigit Message-ID: <504881d7-0ecb-70e4-a063-1f56d3fe4653@intel.com> Date: Tue, 13 Oct 2020 09:52:04 +0100 MIME-Version: 1.0 In-Reply-To: <20201008091729.4321-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/2020 10:17 AM, Ciara Loftus wrote: > Supporting this would require locks, which would impact the performance of > the more typical cases - xsks with different qids and netdevs. > > Signed-off-by: Ciara Loftus > Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") Hi Ciara, 'check-git-log.sh' script is giving some errors, can you please fix them, you can run script as: "./devtools/check-git-log.sh -n1" And can you please give some sample in the description what is not supported now? Also does this require any documentation update, as kind of limitation or known issues?