From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1D2DDF04
 for <dev@dpdk.org>; Tue, 19 Sep 2017 23:26:49 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A118E2134B;
 Tue, 19 Sep 2017 17:26:48 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 19 Sep 2017 17:26:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=LnGjYTwZBiTZziK
 g/iHPgDIiEMwuIPTWfZeqaUkIoks=; b=WT7S5ee1ZlRXmzwpy/Vcoxn2Caxi6Sl
 uQA5hhXYlGkQ82/hhVcBx6xwvSJMlSY41T82sWbhN07DsePrhQcX8bQx+S2OAw5w
 1xaKBLs/ZYpZwTLTzeNJW5cc1TabcJjw/7nX0nHzND2hP0wJ9uGuT9Ttxm/vqIgg
 AKy65SpidtDQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=LnGjYTwZBiTZziKg/iHPgDIiEMwuIPTWfZeqaUkIoks=; b=IZOdsE98
 gFCllkRXAv26q1PGp5TokKgRW+s6I3kkRssYKZRsyNeQo02g+aSGD8KipUcHeWro
 ybeNtqCi+GLERyGoFu4n4Q1tVtHdiONI8e7hImGY5GXzlhAB/jWdugQ1q3TQ5tLC
 ZbW1uVoXnX3XaTS8OdTLViv52kd3YcMdejZfF7agBElkIrdaTBIu2HqJg4eoLAsl
 4oaJXcrRPE0aE1KgIIL10OyYv8mPCNuSaAWUEjbMYvoSgo3lga9eeoFHKQyrXjjj
 guB56Zmfftduh+9hwr2M6woeEDcujn4lGZWGzuQXXGyJuS1JB9TmiY8txUoyudKl
 p9af4jmdegUJ5g==
X-ME-Sender: <xms:mIvBWeeYPLc4fHooHUFo4OCVW3rlTuKjNxSX5I0txCvpdaA8ncx15Q>
X-Sasl-enc: ngEqFDbv7iQ2uPJYuJS93n3PLEDqF1c88Vg7DuCRiAAJ 1505856408
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 51D107F9BA;
 Tue, 19 Sep 2017 17:26:48 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kuba Kozak <kubax.kozak@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, deepak.k.jain@intel.com,
 michalx.k.jastrzebski@intel.com, jacekx.piasecki@intel.com
Date: Tue, 19 Sep 2017 23:26:46 +0200
Message-ID: <5053892.oD5KOMONjY@xps>
In-Reply-To: <1505819248-19792-1-git-send-email-kubax.kozak@intel.com>
References: <1505819248-19792-1-git-send-email-kubax.kozak@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 21:26:49 -0000

Hi,

19/09/2017 13:07, Kuba Kozak:
> @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct rte_cfgfile *cfg,
>  {
>  	const struct rte_cfgfile_section *s = _get_section(cfg, sectionname);
>  	if (s == NULL)
> +#ifdef RTE_NEXT_ABI
> +		return -EINVAL;
> +#else
>  		return -1;
> +#endif
>  	return s->num_entries;
>  }

Why are you using RTE_NEXT_ABI?
Can you wait 18.02 to make this change?

Anyway, when breaking the API you need to update tha API section
of the release notes.

> @@ -219,7 +219,7 @@ int rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg,
>  * @param max_entries
>  *   Maximum number of section entries to be stored in entries array
>  * @return
> -*   Number of entries populated on success, -1 otherwise
> +*   Number of entries populated on success, -EINVAL otherwise
>  */

This documentation become wrong if RTE_NEXT_ABI is disabled.