From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id B8E5A5A57
 for <dev@dpdk.org>; Mon,  2 Mar 2015 19:42:25 +0100 (CET)
Received: by wgha1 with SMTP id a1so35308164wgh.12
 for <dev@dpdk.org>; Mon, 02 Mar 2015 10:42:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=8PqG6vJ5BX9XPfTsZSz6jDt5tWmJgkxGObUvJkl52sE=;
 b=med//2oSq7I4ZlQlOCGYI/ECLkiG87DUcsOs+BK4M3HuLcF//lBfNKnEc7oXLc39IX
 pGtXejy8VQSHINlnSwkiC6FEYd8sobDQXo92138v0TzeYFyC7JZTi79bo0cuaDyLeFLL
 YtIs88ZnfkkAFdyTAVis+KZiBoD9PzJ0nMErg0PVC1t/9a8LSF+IbrtQtazjQzJRuqc9
 VRo+Ys9kzEMTQpkzGBNB76YXj4KH9cbqsPlW6hsbkmz95PomxoXTih7S2pNglpKdqzyD
 sZXUHWlzBp+C3NU+RYJ+NxAZE2TKfqRbZQGApubithY+DsdMtsyEEqcI03Uq5np0XIZR
 0yPg==
X-Gm-Message-State: ALoCoQk2gG0Xq+nRz3YOzh9bmEeWlb3Lve4qWUpO0a5yvvMoLxgoF4+dxeXbgP7TsNMmN2A9coWc
X-Received: by 10.194.2.43 with SMTP id 11mr61793820wjr.104.1425321745619;
 Mon, 02 Mar 2015 10:42:25 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id bd3sm17214036wib.17.2015.03.02.10.42.23
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 02 Mar 2015 10:42:24 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 02 Mar 2015 19:41:50 +0100
Message-ID: <5054941.fYjsyoJciO@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <D0158A423229094DA7ABF71CF2FA0DA3118DFF15@shsmsx102.ccr.corp.intel.com>
References: <1424874849-8973-1-git-send-email-nhorman@tuxdriver.com>
 <1425040393-31201-1-git-send-email-nhorman@tuxdriver.com>
 <D0158A423229094DA7ABF71CF2FA0DA3118DFF15@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] eal: Clean up export of
	per_lcore__socket_id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Mar 2015 18:42:25 -0000

> > Theres no need to export this variable.  Its set and queried from an API call
> > that doesn't exist in the hot path.  Instead just export the rte_socket_id
> > symbol and make the variable private to protect it from type changes.  We should
> > do this with the other exported variables too, but I think its too late in the
> > release cycle to do that.
> > 
> > tested using distributor_autotest (which uses rte_socket_id), successfully.
> > Only tested on linux, as I don't currently have a bsd system spun up, but the
> > changes are symmetric, and should be fine
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Acked-by:  Cunming Liang <cunming.liang@intel.com>

Applied, thanks