From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Guo, Jia" <jia.guo@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Date: Wed, 14 Oct 2020 11:35:30 +0000 [thread overview]
Message-ID: <505e2e9f71ec4fb7adff1f3f03a6e0c6@intel.com> (raw)
In-Reply-To: <20201014091945.1934-4-stevex.yang@intel.com>
Couple comments inline,
Btw, no need to submit a new version, I will ack and merge the patch with below fix directly.
but please keep in mind in your next patch.
> -----Original Message-----
> From: SteveX Yang <stevex.yang@intel.com>
> Sent: Wednesday, October 14, 2020 5:20 PM
> To: dev@dpdk.org
> Cc: Guo, Jia <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v5 3/5] net/ice: fix max mtu size packets with vlan tag cannot
> be received by default
Title is too long, please use check-git-log.sh
Renamed to
"fix MTU size for VLAN packets"
>
> when application presets the max rx packet length and expected mtu at the
s/when/When
> same time, driver need identify if the preset max frame size can hold mtu data
> and Ether overhead completely.
>
> if not, adjust the max frame size via mtu_set ops within dev_configure.
s/if/If
>
> Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
>
> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 0056da78a..a707612c2 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3305,6 +3305,7 @@ ice_dev_configure(struct rte_eth_dev *dev)
> struct ice_adapter *ad =
> ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> + uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
> int ret;
>
> /* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3316,6
> +3317,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
> if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
> dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
>
> + /**
> + * Reset the max frame size via mtu_set ops if preset max frame
> + * cannot hold MTU data and Ether overhead.
> + */
> + if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
> + ret = ice_mtu_set(dev, dev->data->mtu);
> + if (ret != 0)
> + return ret;
> + }
> +
> ret = ice_init_rss(pf);
> if (ret) {
> PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
> --
> 2.17.1
next prev parent reply other threads:[~2020-10-14 11:35 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 5:52 [dpdk-dev] [PATCH v1 0/5] fix default max mtu size when device configured SteveX Yang
2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang
2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 2/5] net/igc: " SteveX Yang
2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 3/5] net/ice: " SteveX Yang
2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 4/5] net/iavf: " SteveX Yang
2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 5/5] net/i40e: " SteveX Yang
2020-09-16 14:41 ` Ananyev, Konstantin
[not found] ` <DM6PR11MB4362E5FF332551D12AA20017F93E0@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-17 12:18 ` Ananyev, Konstantin
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 0/5] fix default max mtu size when device configured SteveX Yang
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 2/5] net/igc: " SteveX Yang
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 3/5] net/ice: " SteveX Yang
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 4/5] net/i40e: " SteveX Yang
2020-09-22 10:47 ` Ananyev, Konstantin
2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 5/5] net/iavf: " SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 0/5] fix default max mtu size when device configured SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 2/5] net/igc: " SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 3/5] net/ice: " SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 4/5] net/i40e: " SteveX Yang
2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 5/5] net/iavf: " SteveX Yang
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 0/5] fix default max mtu size when device configured SteveX Yang
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 2/5] net/igc: " SteveX Yang
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 3/5] net/ice: " SteveX Yang
2020-09-29 11:59 ` Zhang, Qi Z
2020-09-29 23:01 ` Ananyev, Konstantin
2020-09-30 0:34 ` Zhang, Qi Z
[not found] ` <DM6PR11MB4362515283D00E27A793E6B0F9330@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-30 2:32 ` Zhang, Qi Z
2020-10-14 15:38 ` Ferruh Yigit
[not found] ` <DM6PR11MB43628BBF9DCE7CC4D7C05AD8F91E0@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-10-19 10:49 ` Ananyev, Konstantin
2020-10-19 13:07 ` Ferruh Yigit
2020-10-19 14:07 ` Ananyev, Konstantin
2020-10-19 14:28 ` Ananyev, Konstantin
2020-10-19 18:01 ` Ferruh Yigit
2020-10-20 9:07 ` Ananyev, Konstantin
2020-10-20 12:29 ` Ferruh Yigit
2020-10-21 9:47 ` Ananyev, Konstantin
2020-10-21 10:36 ` Ferruh Yigit
2020-10-21 10:44 ` Ananyev, Konstantin
2020-10-21 10:53 ` Ferruh Yigit
2020-10-19 18:05 ` Ferruh Yigit
[not found] ` <DM6PR11MB4362F936BFC715BF6BABBAD0F91F0@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-10-20 8:13 ` Ferruh Yigit
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 4/5] net/i40e: " SteveX Yang
2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 5/5] net/iavf: " SteveX Yang
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 0/5] fix default max mtu size when device configured SteveX Yang
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 2/5] net/igc: " SteveX Yang
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 3/5] net/ice: " SteveX Yang
2020-10-14 11:35 ` Zhang, Qi Z [this message]
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 4/5] net/i40e: " SteveX Yang
2020-10-14 10:30 ` Ananyev, Konstantin
2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 5/5] net/iavf: " SteveX Yang
2020-10-14 11:43 ` [dpdk-dev] [PATCH v5 0/5] fix default max mtu size when device configured Zhang, Qi Z
2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 0/2] " SteveX Yang
2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang
2020-10-22 16:22 ` Ferruh Yigit
2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length SteveX Yang
2020-10-22 16:31 ` Ferruh Yigit
2020-10-22 16:52 ` Ananyev, Konstantin
2020-10-28 3:03 ` [dpdk-dev] [PATCH v7 0/1] fix default max mtu size when device configured SteveX Yang
2020-10-28 3:03 ` [dpdk-dev] [PATCH v7 1/1] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang
2020-10-29 8:41 ` Ferruh Yigit
2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 0/2] fix default max mtu size when device configured SteveX Yang
2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang
2020-11-02 11:48 ` Ferruh Yigit
2020-11-03 13:29 ` Ferruh Yigit
2020-11-04 16:51 ` Thomas Monjalon
2020-11-04 17:07 ` Ferruh Yigit
2020-11-04 17:55 ` Thomas Monjalon
2020-11-04 20:19 ` Ferruh Yigit
2020-11-04 20:39 ` Thomas Monjalon
2020-11-05 8:54 ` Andrew Rybchenko
[not found] ` <DM6PR11MB43622CC5DF485DD034037CD3F9EE0@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-11-05 10:37 ` Ferruh Yigit
2020-11-05 10:44 ` Thomas Monjalon
2020-11-05 10:48 ` Thomas Monjalon
2020-11-05 10:50 ` Ferruh Yigit
2020-11-05 13:52 ` Olivier Matz
2020-11-05 15:11 ` Lance Richardson
2020-11-05 15:56 ` Ferruh Yigit
2020-11-05 16:23 ` Lance Richardson
2020-11-05 17:44 ` [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment Thomas Monjalon
2020-11-05 18:02 ` Lance Richardson
2020-11-05 18:11 ` Ferruh Yigit
2020-11-05 18:18 ` Thomas Monjalon
2020-11-05 10:49 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets Ferruh Yigit
2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition SteveX Yang
2020-11-02 11:50 ` Ferruh Yigit
2020-11-02 13:18 ` Andrew Rybchenko
2020-11-02 13:58 ` Ferruh Yigit
2020-11-02 16:05 ` Ananyev, Konstantin
[not found] ` <DM6PR11MB43625C5CF594BEDC9CE479F7F9110@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-11-24 17:46 ` Ferruh Yigit
2020-11-27 12:19 ` Andrew Rybchenko
2020-11-27 17:08 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505e2e9f71ec4fb7adff1f3f03a6e0c6@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).