From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A62941C5D; Fri, 10 Feb 2023 09:31:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49D9E42670; Fri, 10 Feb 2023 09:31:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B7E9840EE6 for ; Fri, 10 Feb 2023 09:31:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676017901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QA6ZcoJsahTACC9r9AZckVMA7QxSvptDJ69/1SqDMA=; b=L5orPjRl+zp01H8wrEvkbId82/430QkgvqOFMMVIvv0Aq6s6CcnnYsXSZhpacQRk6G2xkY bMt68CA2fB/6RZonmtqodHeYJftW883hu8FgUYvCAfL83Xtx7XgrgHgWiQN0goLlZxCq2w Pic0GdT8iiF2bZolTsOclh34UqFOjYI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-YP2nQ86PMsicBwwb68SrPw-1; Fri, 10 Feb 2023 03:31:40 -0500 X-MC-Unique: YP2nQ86PMsicBwwb68SrPw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 976D5811E9C; Fri, 10 Feb 2023 08:31:39 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09F1F1121319; Fri, 10 Feb 2023 08:31:37 +0000 (UTC) Message-ID: <505e346f-d24a-ab7b-f6fc-ee7beeea567a@redhat.com> Date: Fri, 10 Feb 2023 09:31:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 3/9] baseband/acc: remove interrupt support on VRB1 To: Nicolas Chautru , dev@dpdk.org Cc: hernan.vargas@intel.com, stable@dpdk.org References: <20230209221929.265059-1-nicolas.chautru@intel.com> <20230209221929.265059-4-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20230209221929.265059-4-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/23 23:19, Nicolas Chautru wrote: > Not enabling interrupt in VRB1 PMD variant to avoid > potential corner case. > > Fixes: 3cabc8eaf524 ("baseband/acc200: support interrupt") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_vrb_pmd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index c43c08afe8..a111836e51 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -586,6 +586,14 @@ vrb_intr_enable(struct rte_bbdev *dev) > { > int ret; > struct acc_device *d = dev->data->dev_private; > + > + if (d->device_variant == VRB1_VARIANT) { > + /* On VRB1: cannot enable MSI/IR to avoid potential back-pressure corner case. */ > + rte_bbdev_log(ERR, "VRB1 (%s) doesn't support any MSI/MSI-X interrupt\n", > + dev->data->name); > + return -ENOTSUP; > + } > + > /* > * MSI/MSI-X are supported. > * Option controlled by vfio-intr through EAL parameter. Reviewed-by: Maxime Coquelin Thanks, Maxime