DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type
Date: Wed, 14 Feb 2018 18:10:44 +0100	[thread overview]
Message-ID: <50628242.XRkpFPbRgn@xps> (raw)
In-Reply-To: <2b154134-d1e5-f7db-e38f-43900b48f91e@nxp.com>

> >>> Ethdev APIs to add callback return the callback object as "void *",
> >>> update return type to actual object type
> >>> "struct rte_eth_rxtx_callback *"
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> ---
> >>> +* ethdev: functions add rx/tx callback will return named opaque type
> >>> +  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
> >>> +  rte_eth_add_tx_callback() functions currently return callback object as
> >>> +  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
> >>> +  as parameter. For consistency functions adding callback will return
> >>> +  "struct rte_eth_rxtx_callback \*" instead of "void * ".
> >>> +
> >>>   * i40e: The default flexible payload configuration which extracts the first 16
> >>>     bytes of the payload for RSS will be deprecated starting from 18.02. If
> >>>     required the previous behavior can be configured using existing flow
> >>> --
> >>
> >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > 
> > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied

      reply	other threads:[~2018-02-14 17:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 10:11 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-02-09 10:18 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-02-09 13:22   ` Ananyev, Konstantin
2018-02-10 12:02     ` Jerin Jacob
2018-02-13  3:52       ` Hemant Agrawal
2018-02-14 17:10         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50628242.XRkpFPbRgn@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).