From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4B00433E7; Mon, 27 Nov 2023 22:19:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8250B40A6B; Mon, 27 Nov 2023 22:19:33 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D20CF40156 for ; Mon, 27 Nov 2023 22:19:31 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 6AC445C0225; Mon, 27 Nov 2023 16:19:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 27 Nov 2023 16:19:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1701119971; x=1701206371; bh=mtOAytvgHIxo7SRrVll0SxZgkctOii/lr0z Xp15z00Y=; b=gwavZU6UtpvP2uN0SU1p4N/HfOWmWMHrFv30cI1kXeTYkneI/Jc 0gp0fEm/J0JDVcL1cQSgRQUsAxrld7AlWTPdCda5CBO5NF3irOUzNS4zZ1Mu3+m2 5hCq7f2jS4vniLboAwvC1KJ16snI0wNHDP5Rpm1kZGCKv4I1v6vaFcepipxtjKfA YYYlvs0nsil+CrdHAwXF/qeKaRUfViR64p5T9BkX1Yr5vMGQgTYtwRPkQBJweJnC INlFG44CJG6X8FCg8d2UbKnvGPUpq/aLJyk2SDiapGmO6x+M9eYr3nKCoO3mOFzS ovAG3AwKHT9tpLm7jmpSNaYxtSVaT+p/EDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701119971; x=1701206371; bh=mtOAytvgHIxo7SRrVll0SxZgkctOii/lr0z Xp15z00Y=; b=h6zCt3QrROOPKW6SHS3tXfacKimbPJlj+CDCcyjkQO6b/iTPHlL +8DVL6p9anSYAVNKUzyUC31IQfNklpom7ehoD6nEbWuJvPIS7RQY7HlIxPQ0ETVE UlkkZz0OwKhp5Jd2AscxVwPGbFGx3zTDHvk6OtSvnUJ38xU99AtHl987Dx5n/Wg/ JVy95H2BUL2PqXzOGV0V+ImedWbF8xOsay2zL0ZKUYAMPhI9fLQwpiOyfGPs2KYn W+OO7H/7VkYzthux4w/rlT63iOp9YrDr1aIo95h5a59cNv0XsGZsWDFkpgyE9bT4 WBFmTEyBpsigxE8FQ7iGtyBsjvzzFfxB9IQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiuddgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Nov 2023 16:19:29 -0500 (EST) From: Thomas Monjalon To: Sivaprasad Tummala Cc: "Kelly, Karen" , anatoly.burakov@intel.com, david.marchand@redhat.com, dev@dpdk.org, john.mcnamara@intel.com, ferruh.yigit@amd.com, "Hunt, David" Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Date: Mon, 27 Nov 2023 22:19:28 +0100 Message-ID: <5067151.6tgchFWduM@thomas> In-Reply-To: References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> <2d53680a-cde3-45cf-b353-81637ec4f7e2@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/10/2023 14:37, Hunt, David: > On 27/10/2023 13:36, Kelly, Karen wrote: > > On 26/10/2023 16:19, Sivaprasad Tummala wrote: > >> Updated the l3fwd-power app to configure the uncore env before invoking > >> any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > >> too late because other APIs already called. > >> > >> Bugzilla ID: 1304 > >> Fixes: ac1edcb6621a ("power: refactor uncore power management API") > >> Cc:karen.kelly@intel.com > >> > >> Signed-off-by: Sivaprasad Tummala > >> --- > >> examples/l3fwd-power/main.c | 6 ++++++ > >> lib/power/rte_power_uncore.c | 7 +++++++ > >> lib/power/rte_power_uncore.h | 9 +++++---- > >> 3 files changed, 18 insertions(+), 4 deletions(-) > > Ran on my system, bug is resolved after applying this patch. > > > > Tested-by: Karen Kelly > > > > Acked-by: David Hunt So I merge it to fix a bug in the library, despite the patch title. I am fixing a typo, and the commit description. Applied