From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBAFBA0546; Thu, 16 Jul 2020 09:53:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95B384F9A; Thu, 16 Jul 2020 09:53:38 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 4AE952C4F for ; Thu, 16 Jul 2020 09:53:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594886016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Ih6O6pNKUUWO6JVTjRuCU7Wy2/IghfKVK7oZx7p2No=; b=YZ40Vgt6C0iPKCu9jXIZPasJ4B17yOQd8y3lo2udRc9u8TpqFIchA1zUP3Kfy1bPi60MWT NeKJZxgzl7eaqFqXlT2ajF1OedvdASdfSbnK3/2Cb1yiHeU15p330Ay1MdLvMPxdy86m4O pXaZh3zCCe7ISTYIajMJRdfmAGLJJB8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-Kw94FRsxOr-HBskAR2OcRA-1; Thu, 16 Jul 2020 03:53:34 -0400 X-MC-Unique: Kw94FRsxOr-HBskAR2OcRA-1 Received: by mail-wr1-f71.google.com with SMTP id s16so4982449wrv.1 for ; Thu, 16 Jul 2020 00:53:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3Ih6O6pNKUUWO6JVTjRuCU7Wy2/IghfKVK7oZx7p2No=; b=Ep24MuaYhH3pdK5YnmrJlBAvSiKsEktP+typFL0R6fPEjiyQllZFz3EZXE6UjbOMz5 Pgt49YfWZx3CDr1ZqGkeYLfVL6pN5aNv8ZVBKgaqjuZG8/lT6359wDNpWluiI/AhFPDw +mhWtzo56RjMW1AB0eYlOFAtsr/MRH8k0Kp8WHQmQAOzi8q4FgUFzeICw+2dxrxYneQT 9FN4KPSF1WVjFYddzJFibmtYejlF2BQt84lJIvbGF1/89IANP05PkyhEdy7mCIcO186z zpzjNgmcYth2uHq5TRbXDVzucE1qlj188f31gACQEBT+UtpI4+96PG3FcQS89o2Pb+Qf GmtA== X-Gm-Message-State: AOAM533AG+xDyjqI7HE2srqqvabYGI7XUKqZ1WW7cmfnV+8dHbhj+sxo 9gkq593njHzYinZE8WkiN2XkCi8pFzXoDlF+ImeJv6vAQck5XhgqEgwKmoPYuEDhDw4TpOstOlV 8vdo= X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3097252wmj.119.1594886013622; Thu, 16 Jul 2020 00:53:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL/G7S4s/Tuj5hyfh3eUvMn1bItvYtXoRerm9MyTpKCs0f/hWuBimvD8QbCcwCuVwxcQ+45w== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr3097239wmj.119.1594886013417; Thu, 16 Jul 2020 00:53:33 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([92.176.159.3]) by smtp.gmail.com with ESMTPSA id u65sm7529757wmg.5.2020.07.16.00.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 00:53:32 -0700 (PDT) To: "Xia, Chenbo" , "dev@dpdk.org" Cc: "maxime.coquelin@redhat.com" , "Wang, Zhihong" , David Marchand References: <20200715171828.95887-1-amorenoz@redhat.com> <20200715171828.95887-5-amorenoz@redhat.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <506d7594-efd0-ed82-2f3a-6306540c7cc1@redhat.com> Date: Thu, 16 Jul 2020 09:53:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/16/20 5:31 AM, Xia, Chenbo wrote: > Hi Adrian, > >> -----Original Message----- >> From: Adrian Moreno >> Sent: Thursday, July 16, 2020 1:18 AM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com; Wang, Zhihong ; >> amorenoz@redhat.com; Xia, Chenbo >> Subject: [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user >> >> This patch adds support for VHOST_USER_GET_STATUS request. >> >> Only vhost-user backed is supported for now >> >> Signed-off-by: Adrian Moreno >> --- >> drivers/net/virtio/virtio_user/vhost_user.c | 2 + >> .../net/virtio/virtio_user/virtio_user_dev.c | 39 >> +++++++++++++++++++ .../net/virtio/virtio_user/virtio_user_dev.h | 1 + >> drivers/net/virtio/virtio_user_ethdev.c | 2 + >> 4 files changed, 44 insertions(+) >> >> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c >> b/drivers/net/virtio/virtio_user/vhost_user.c >> index 2332e01d1..43c630e47 100644 >> --- a/drivers/net/virtio/virtio_user/vhost_user.c >> +++ b/drivers/net/virtio/virtio_user/vhost_user.c >> @@ -279,6 +279,7 @@ vhost_user_sock(struct virtio_user_dev *dev, >> switch (req) { >> case VHOST_USER_GET_FEATURES: >> case VHOST_USER_GET_PROTOCOL_FEATURES: >> + case VHOST_USER_GET_STATUS: >> need_reply = 1; >> break; >> >> @@ -373,6 +374,7 @@ vhost_user_sock(struct virtio_user_dev *dev, >> >> switch (req) { >> case VHOST_USER_GET_FEATURES: >> + case VHOST_USER_GET_STATUS: >> case VHOST_USER_GET_PROTOCOL_FEATURES: >> if (msg.size != sizeof(m.payload.u64)) { >> PMD_DRV_LOG(ERR, "Received bad msg size"); >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> index 2c400a448..613caef56 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> @@ -804,3 +804,42 @@ virtio_user_send_status_update(struct virtio_user_dev >> *dev, uint8_t status) >> >> return 0; >> } >> + >> +int >> +virtio_user_update_status(struct virtio_user_dev *dev) { >> + uint64_t ret; >> + >> + /* Vhost-user only for now */ >> + if (!is_vhost_user_by_type(dev->path)) >> + return 0; >> + >> + if (!(dev->protocol_features & (1UL << >> VHOST_USER_PROTOCOL_F_STATUS))) >> + return 0; >> + >> + if (dev->ops->send_request(dev, VHOST_USER_GET_STATUS, &ret) < 0) { >> + PMD_INIT_LOG(ERR, "GET_STATUS failed: %s", strerror(errno)); >> + return -1; >> + } >> + if (ret > UINT8_MAX) { >> + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS >> response 0x%" PRIx64 "\n", ret); > > There's a coding style issue here: > CHECK:CAMELCASE: Avoid CamelCase: > Could you fix this? I did see this one as well. It also seems new because PRIx64 is widely used in DPDK. find -iname *.c | xargs grep -i "PRIx64" | wc -l 520 So, ether we have to modify the script to ignore this one or change all 520 cases, right? + David, what do you think? > > Btw, in case you don't know, there's a script in dpdk for check these issues: > devtools/checkpatches.sh. 😊 > > Thanks! > Chenbo > >> + return -1; >> + } >> + >> + dev->status = ret; >> + PMD_INIT_LOG(DEBUG, "Updated Device Status(0x%08x):\n" >> + "\t-ACKNOWLEDGE: %u\n" >> + "\t-DRIVER: %u\n" >> + "\t-DRIVER_OK: %u\n" >> + "\t-FEATURES_OK: %u\n" >> + "\t-DEVICE_NEED_RESET: %u\n" >> + "\t-FAILED: %u\n", >> + dev->status, >> + !!(dev->status & VIRTIO_CONFIG_STATUS_ACK), >> + !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER), >> + !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER_OK), >> + !!(dev->status & >> VIRTIO_CONFIG_STATUS_FEATURES_OK), >> + !!(dev->status & >> VIRTIO_CONFIG_STATUS_DEV_NEED_RESET), >> + !!(dev->status & VIRTIO_CONFIG_STATUS_FAILED)); >> + return 0; >> +} >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> index a76d7cfaf..1a045af6f 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> @@ -75,4 +75,5 @@ void virtio_user_handle_cq_packed(struct virtio_user_dev >> *dev, >> uint16_t queue_idx); >> uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs); >> int virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status); >> +int virtio_user_update_status(struct virtio_user_dev *dev); >> #endif >> diff --git a/drivers/net/virtio/virtio_user_ethdev.c >> b/drivers/net/virtio/virtio_user_ethdev.c >> index e52f11341..40330deed 100644 >> --- a/drivers/net/virtio/virtio_user_ethdev.c >> +++ b/drivers/net/virtio/virtio_user_ethdev.c >> @@ -281,6 +281,8 @@ virtio_user_get_status(struct virtio_hw *hw) { >> struct virtio_user_dev *dev = virtio_user_get_dev(hw); >> >> + virtio_user_update_status(dev); >> + >> return dev->status; >> } >> >> -- >> 2.26.2 > -- Adrián Moreno