From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report
Date: Mon, 12 Feb 2018 18:55:22 +0100 [thread overview]
Message-ID: <5072632.Aql229SuCI@xps> (raw)
In-Reply-To: <1518446598-24238-1-git-send-email-ophirmu@mellanox.com>
The title should be "add CRC stripping capability".
12/02/2018 15:43, Ophir Munk:
> CRC stripping is executed outside of TAP PMD scope. There is no
> prevention that TAP reports on Rx CRC stripping capability.
We could mention that the CRC stripping is done in the kernel.
> It is especially required when TAP is operating as failsafe sub-device
> with another PCI sub-device which supports CRC stripping.
> In the corrupted code TAP did not report on this capability which
> caused failsafe to not report on it as well.
You discover the bug with failsafe but it is not related at all.
I think you squeeze this part of the explanation.
> The fix is for TAP to report that Rx CRC stripping is supported.
>
> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
I don't think it is a root cause.
This capability is missing from day one:
Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
next prev parent reply other threads:[~2018-02-12 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 14:43 [dpdk-dev] " Ophir Munk
2018-02-12 17:55 ` Thomas Monjalon [this message]
2018-02-12 22:34 ` [dpdk-dev] [dpdk-stable] " Ophir Munk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072632.Aql229SuCI@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).