From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 10AB21B3CF for ; Mon, 12 Feb 2018 18:55:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B050721450; Mon, 12 Feb 2018 12:55:31 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 12 Feb 2018 12:55:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pIPQR3PGQwcdQAqDA3+t1JeD8s le37Rli/J6P1TETPI=; b=UC7lycGfcfUK9uslhnVzHRTKDJVpTYSqJTkhqW6ZHD Hli1y+S3MbXwQ8xqZ5kT3vYzCrElW+Mag1m9r7WtvctXDzWCSygsxVjCfjW7Vzz+ Sve0Gr5MBCraQW8v3A4/qs0ugtWbRiaJjczvi4aKTU+O5HaVLfwIeXLVoWfc47kC M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pIPQR3 PGQwcdQAqDA3+t1JeD8sle37Rli/J6P1TETPI=; b=Cp1AdlZxZ3hGPZVtQVP9Av qVz9xnyqzUAJ09TaZe1K+RqSn+oTaQAvs4Nbz/+00x4Q39fqttIR3047BcKkqZtY D1dvjxx96wEqnDIwXpG0S9rkG+FvvCoBZuEyQmv7vCbFXmKtw63erXzlDSOiSQ6+ /6lxx5d8SzEFKM6wVOXV1whVcRLmTFVACSx6o70UnAqblwkBzUUtetfl+L3/7UEZ VKnvLrNq/PV2Bp926BFI69q2Q3m3SkZxgpEBZ8foA2BGcfTXv/YAcrZF95tGESFl jSZzu4Wv/MKR2wbtMIhRa/So9xAUxjDBPn8GvKMsUq/qFtl61mgcJgOz/uWrdVmA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 658997E168; Mon, 12 Feb 2018 12:55:31 -0500 (EST) From: Thomas Monjalon To: Ophir Munk Cc: dev@dpdk.org, Pascal Mazon , Olga Shern Date: Mon, 12 Feb 2018 18:55:22 +0100 Message-ID: <5072632.Aql229SuCI@xps> In-Reply-To: <1518446598-24238-1-git-send-email-ophirmu@mellanox.com> References: <1518446598-24238-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 17:55:32 -0000 The title should be "add CRC stripping capability". 12/02/2018 15:43, Ophir Munk: > CRC stripping is executed outside of TAP PMD scope. There is no > prevention that TAP reports on Rx CRC stripping capability. We could mention that the CRC stripping is done in the kernel. > It is especially required when TAP is operating as failsafe sub-device > with another PCI sub-device which supports CRC stripping. > In the corrupted code TAP did not report on this capability which > caused failsafe to not report on it as well. You discover the bug with failsafe but it is not related at all. I think you squeeze this part of the explanation. > The fix is for TAP to report that Rx CRC stripping is supported. > > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") I don't think it is a root cause. This capability is missing from day one: Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk