From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 349F8A04DD; Wed, 28 Oct 2020 11:32:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81ABDC9A6; Wed, 28 Oct 2020 11:28:00 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2E320C95E for ; Wed, 28 Oct 2020 11:27:58 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id C3D6720061; Wed, 28 Oct 2020 10:27:56 +0000 (UTC) Received: from us4-mdac16-33.at1.mdlocal (unknown [10.110.49.217]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id C2777800A3; Wed, 28 Oct 2020 10:27:56 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.8]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5B076100061; Wed, 28 Oct 2020 10:27:56 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id F16604C0058; Wed, 28 Oct 2020 10:27:54 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Oct 2020 10:27:49 +0000 To: David Marchand , CC: Ray Kinsella , Neil Horman , "Olivier Matz" References: <20201027221343.28551-1-david.marchand@redhat.com> <20201027221343.28551-9-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <507d2ebc-a37d-3fd1-d55d-6133acfe3845@solarflare.com> Date: Wed, 28 Oct 2020 13:27:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201027221343.28551-9-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25752.003 X-TM-AS-Result: No-3.780400-8.000000-10 X-TMASE-MatchedRID: O/y65JfDwwt2LasmHuCXMfZvT2zYoYOwC/ExpXrHizy2K+7tVM9UojB9 ccde3hbUgudRl/9qZRt65cF3rK4wg1tNf1tGHBMOydRP56yRRA+8RL+SWMdQmNEsTITobgNEcOQ FqW7TulW2YuNTyjgaYFKMQ1IQfrV424hSFrj+Gq+eAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyLUZx EAlFPo846HM5rqDwqtxg5zdzl7YxNAWo19lT4Tc5RA829xa3uYE5ssc4vJNaUCjDa0RsflCzn4M NuTniv+1qZk9RS1zeNVLjxDyGGwLfblWdGuH8LL4vn0zMfSmjYrbLOj1GuP3A+hgLflG6KEo9Qj uF9BKnnfMd6s6DDccQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.780400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25752.003 X-MDID: 1603880876-VXSMgS5-iLLY X-PPE-DISP: 1603880876;VXSMgS5-iLLY Subject: Re: [dpdk-dev] [PATCH 8/8] mbuf: remove seqn field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/20 1:13 AM, David Marchand wrote: > As announced in the deprecation note, the field seqn is removed to give > more space to the dynamic fields. > > This is how the mbuf layout looks like (pahole-style): > > word type name byte size > 0 void * buf_addr; /* 0 + 8 */ > 1 rte_iova_t buf_iova /* 8 + 8 */ > /* --- RTE_MARKER64 rearm_data; */ > 2 uint16_t data_off; /* 16 + 2 */ > uint16_t refcnt; /* 18 + 2 */ > uint16_t nb_segs; /* 20 + 2 */ > uint16_t port; /* 22 + 2 */ > 3 uint64_t ol_flags; /* 24 + 8 */ > /* --- RTE_MARKER rx_descriptor_fields1; */ > 4 uint32_t union packet_type; /* 32 + 4 */ > uint32_t pkt_len; /* 36 + 4 */ > 5 uint16_t data_len; /* 40 + 2 */ > uint16_t vlan_tci; /* 42 + 2 */ > 5.5 uint64_t union hash; /* 44 + 8 */ > 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */ > uint16_t buf_len; /* 54 + 2 */ > 7 uint64_t timestamp; /* 56 + 8 */ > /* --- RTE_MARKER cacheline1; */ > 8 struct rte_mempool * pool; /* 64 + 8 */ > 9 struct rte_mbuf * next; /* 72 + 8 */ > 10 uint64_t union tx_offload; /* 80 + 8 */ > 11 struct rte_mbuf_ext_shared_info * shinfo; /* 88 + 8 */ > 12 uint16_t priv_size; /* 96 + 2 */ > uint16_t timesync; /* 98 + 2 */ > 12.5 uint32_t dynfield1[7]; /* 100 + 28 */ > 16 /* --- END 128 */ > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko