From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E7FCA00C4; Wed, 29 Jun 2022 22:06:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAC26410D5; Wed, 29 Jun 2022 22:06:06 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060.outbound.protection.outlook.com [40.107.92.60]) by mails.dpdk.org (Postfix) with ESMTP id 8448E40691 for ; Wed, 29 Jun 2022 22:06:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5lvziIJ5b2ILuqLOUKiZNrJ421y5IjK2Dmn71PodZ96RMJEW6ptSYakwItN+3DzulmyNS7qVcjJsjEZuoARe8XuNYp6lcGUNnnUrDEFtO3GZIGHnzZL2FQMG89ANHDT2CW8PMR2F1D6A/1+9fIy93TtcBDVNKzQSwo/JhGajwQcY5Xvq/BJHoiYPqM39MkgXB1Axttt8EPECmapTVTNba5Og+Kvu68RYPA0iy0UmbhkVGrohMZqA97SKm1d5K62c9c1yB3LomhQ+8QHsMguu/askUHVDblpJeAhwSZD/GnwuGp3ivrmXyDJfGRDY223EaO8+K0CU4sHhX2Z70xWAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KIEcRY5G7qKNaaJ6qoI7YUOOK25wrkG5YjQEDj6bXU8=; b=Ua5ax/wyD5e7EMod1AOQGEndbc6y/Vx2hvrkaCNfLTle+CswYqNT2/hQ2b5EhCAotruaIkSiZSSmoNswHT3/eVOZMCSVxNPZGxJGu950M6m3YtjHQ5nY23E8hKFL3lxvvQUvB5CX+e0eWwo1jUISIfgZSZjMXSq9gT1QXZuSinBJXTF53xIhHy5mbKMfJzkuTJnWYBV0N46InKASrjwjTvPbOgG7HsD6zoTrrDjwQyYIZWjDawoUAzZxWGww7HVhmHWBl5L8KGzkTr4rphjevLYrLjdXUk20k8Sj+hEv8PP0hvS5gY8DdY7VwNsWlM/k2XshFtABIhrmpEbrIkr+wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KIEcRY5G7qKNaaJ6qoI7YUOOK25wrkG5YjQEDj6bXU8=; b=RIPsIA/iZYbdw9+yp1oGsaMRDUAbedTxk6xHL3vgvrjBkEvMv0pjn7OdC1HY+AOkdwBcG/Wi2G8BdkcYykUywoN+69u96hRO+M1O5MuTgvXv49N01Xeh0KqYtbVMoXAxCz5xVL9AOt/YfXUTms4P3OX1FAQ0peMzP3Jk6AG81bY= Received: from BN0PR10CA0006.namprd10.prod.outlook.com (2603:10b6:408:143::32) by SN4PR0201MB3488.namprd02.prod.outlook.com (2603:10b6:803:44::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 29 Jun 2022 20:06:02 +0000 Received: from BN1NAM02FT025.eop-nam02.prod.protection.outlook.com (2603:10b6:408:143:cafe::92) by BN0PR10CA0006.outlook.office365.com (2603:10b6:408:143::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Wed, 29 Jun 2022 20:06:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT025.mail.protection.outlook.com (10.13.2.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5395.14 via Frontend Transport; Wed, 29 Jun 2022 20:06:02 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 29 Jun 2022 21:06:00 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 29 Jun 2022 21:06:00 +0100 Envelope-to: lihuisong@huawei.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [10.71.116.38] (port=8335) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o6dwk-0001hk-St; Wed, 29 Jun 2022 21:06:00 +0100 Message-ID: <508a2a40-7617-cee1-a17e-078340a5d964@xilinx.com> Date: Wed, 29 Jun 2022 21:05:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V6 0/8] app/testpmd: fix RSS and flow type Content-Language: en-US To: Huisong Li , , , CC: , , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220629083451.21954-1-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20220629083451.21954-1-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a724474e-c6ba-4119-5331-08da5a0acac3 X-MS-TrafficTypeDiagnostic: SN4PR0201MB3488:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eWvH46lW68MTOwNpNcn6XBx48aTS0e7xv6MqoQJVFIKlSRtx7VSMEiv1ZlHTGYTRYJVhLAWMtp1v6tfIY/EyQDZhETEr+nERKYnBRd1en5Np9NQGIG9spqnUZ0i6Ys3iztVnJN5nNZIDuO8BMXoZyPMS65hh9PljjE3og+CAO+3gicMG+uTjz3sooIoxu+V7mzOwq+fPHj6qqQDvWW9yG0XdJWXnMwKrNrTMN4Ts/yDlBE/eqAD0esDJ/iK2MYtW3ym44deM87mSzeyuAQ5pB4osAtPC2xFsAR9A41R+PXxY6q3f2B8O0tYFYIhLZzhSq+CChWSLX/FxvZ6flN1Dn/1WVThaq+S+iMCRcaP8xCnlNHZsaoStQAm+uIuY/2gESJXZZXYOEwvxouPjjxxjXgh6jQHzDCJJzqEaDKxQFUunCXNUcelqVqIbsDVkJ2X3UIcIgBRQ8ZBsxhuGQLLzfELp4N/o8F9PBNw8vFhxfulpvT6x2Su208OWq+QDxCWnb60t0SR5jQANNh2W1NhBjxg4OBWpUptzcsObFyUF24urKTe9g6on0UwuxjcKSRBIyKDJNSeYDGZCCTDkCjBp7L63dIuO1DX3NZqXPEzY80RRuVsy9bLgvZCsGEpXzA7N6UMYc1F3IDJRKnCTlXpmKl0s8sd7UheXMB5iG7KzyZZyD9UQ0T2aBPM42KJgOFemDYULDD0KHAycdiU1dzYeBghXImpucNwM6n5Ocqtz3zam5xwMzaleoyIov+FLwQUrEJXFpqmt1MUyrn6C++UAJOc7MqMxYSKF7BXDRmpOPFmwbCV2B0rABzvvImt1oikxPbrjLrZEnardXRJ+fljAhIriGCpXc9ygwkC58dK6unFlg/3zJ93T3aSyNGeAWB9P X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(356005)(40460700003)(36860700001)(7636003)(2906002)(82740400003)(31696002)(82310400005)(8936002)(5660300002)(478600001)(9786002)(41300700001)(44832011)(316002)(70586007)(54906003)(83380400001)(110136005)(70206006)(8676002)(47076005)(336012)(186003)(426003)(40480700001)(4326008)(53546011)(26005)(2616005)(31686004)(36756003)(50156003)(21314003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 20:06:02.2599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a724474e-c6ba-4119-5331-08da5a0acac3 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT025.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB3488 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/29/2022 9:34 AM, Huisong Li wrote: > This patchset fix RSS related code and remove duplicated flow type to > string table. > > --- > v6: > - add a release note for renaming testpmd RSS type 'ether'. > - revert "unknown offload xxx" print. > > v5: > - resolve a warning in testpmd_funcs.rst file > > v4: > - delete 'rss_offload_table[]' and use 'rss_type_table[]' > - add an 'char_num_per_line' parameter to control RSS types display. > - add 2/7, 3/7 and 6/7 patch. > > v3: > - add 'rss_offload_table[]' to display supported RSS offload. > - add patch 3/4 and 4/4. > > v2: > - resovle compilation failure when disable i40e and ixgbe. > > Ferruh Yigit (2): > app/testpmd: compact RSS types output in some commands > app/testpmd: remove duplicated flow type to string table > > Huisong Li (6): > app/testpmd: fix supported RSS offload display > app/testpmd: unify the name of L2 payload offload > doc: testpmd rename RSS type ether to L2 payload > app/testpmd: refactor config all RSS command > app/testpmd: unify RSS types display > app/testpmd: reorder elements in RSS type table array > For series, Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks. Doc patch merged with relevant patch while merging. Thanks for the cleanup. Addition to some internal cleanup/refactoring, output improved as following [1]. The output is "Supported RSS offload flow types", so it is the capability of the device, not current configuration. Do you think does it make sense to add "Configured RSS offload types" too? @Aman, @Yuying, what do you think? [1] RSS related part of "show port info all" new: Supported RSS offload flow types: ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-other ipv6 ipv6-frag ipv6-tcp ipv6-udp ipv6-other ipv6-ex ipv6-tcp-ex ipv6-udp-ex esp l4-dst-only l4-src-only l3-dst-only l3-src-only old: Supported RSS offload flow types: ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-other ipv6 ipv6-frag ipv6-tcp ipv6-udp ipv6-other ipv6-ex ipv6-tcp-ex ipv6-udp-ex user defined 27 user defined 60 user defined 61 user defined 62 user defined 63