DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Christophe Fontaine <cfontain@redhat.com>, chenbo.xia@intel.com
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/1] vhost: Move fds outside of VhostUserMessage
Date: Tue, 1 Feb 2022 10:56:28 +0100	[thread overview]
Message-ID: <509d4dfe-4350-f7fe-b80f-484a42b38b3f@redhat.com> (raw)
In-Reply-To: <20220123115927.76130-2-cfontain@redhat.com>

Hi Christophe,

On 1/23/22 12:59, Christophe Fontaine wrote:
> FDs at the end of the VhostUserMessage structure limits the size
> of the payload. Move them to an other englobing structure, before
> the header & payload of a VhostUserMessage.
> Also removes a reference to fds in the VHUMsg structure defined in
> drivers/net/virtio/virtio_user/vhost_user.c
> 
> Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
> ---
>   drivers/net/virtio/virtio_user/vhost_user.c |   1 -
>   lib/vhost/vhost_crypto.c                    |  10 +-
>   lib/vhost/vhost_user.c                      | 529 ++++++++++----------
>   lib/vhost/vhost_user.h                      |   7 +-
>   4 files changed, 288 insertions(+), 259 deletions(-)
> 

Thanks for working on this, I agree the FDs should be moved outside the
Vhost-user message structure.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2022-02-01  9:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-23 11:59 [PATCH 0/1] Removes FDs from VhostUserMessage structure Christophe Fontaine
2022-01-23 11:59 ` [PATCH 1/1] vhost: Move fds outside of VhostUserMessage Christophe Fontaine
2022-02-01  9:56   ` Maxime Coquelin [this message]
2022-02-04 12:21   ` Maxime Coquelin
2022-02-07 10:21   ` [PATCH v2 0/1] Removes FDs from VhostUserMessage structure Christophe Fontaine
2022-02-07 10:21     ` [PATCH v2 1/1] vhost: move fds outside of VhostUserMessage Christophe Fontaine
2022-02-08  9:48       ` Maxime Coquelin
2022-02-08  9:59       ` David Marchand
2022-02-08 11:12       ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509d4dfe-4350-f7fe-b80f-484a42b38b3f@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=cfontain@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).