From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 287FBA00C3; Tue, 1 Feb 2022 10:56:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1569240691; Tue, 1 Feb 2022 10:56:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 46DF040685 for ; Tue, 1 Feb 2022 10:56:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643709393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5R2FtTfe0zZUPvW9Ybs+bf68dS7sLLPxVgL/n2vL9Xo=; b=As4KK7Y6Q2YbpEg0q8u/k5aolP07/o9A2oogCRB8R8t16MnUBHlPOHv/joFuTnkPtEtsEm P//tGjRc+DMaAUaLR7VIV9ML9y2BjUHauDy7j32reZVQuceyTvOw/aefJHdoZaIsV9A/27 InqxHihR1aEb/eleCx7Eiclpnh3UF1g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-itsytvcFMFCzH0FTKj6NPA-1; Tue, 01 Feb 2022 04:56:32 -0500 X-MC-Unique: itsytvcFMFCzH0FTKj6NPA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D61204686D; Tue, 1 Feb 2022 09:56:31 +0000 (UTC) Received: from [10.39.208.24] (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F5115E4BB; Tue, 1 Feb 2022 09:56:30 +0000 (UTC) Message-ID: <509d4dfe-4350-f7fe-b80f-484a42b38b3f@redhat.com> Date: Tue, 1 Feb 2022 10:56:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/1] vhost: Move fds outside of VhostUserMessage To: Christophe Fontaine , chenbo.xia@intel.com Cc: dev@dpdk.org References: <20220123115927.76130-1-cfontain@redhat.com> <20220123115927.76130-2-cfontain@redhat.com> From: Maxime Coquelin In-Reply-To: <20220123115927.76130-2-cfontain@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Christophe, On 1/23/22 12:59, Christophe Fontaine wrote: > FDs at the end of the VhostUserMessage structure limits the size > of the payload. Move them to an other englobing structure, before > the header & payload of a VhostUserMessage. > Also removes a reference to fds in the VHUMsg structure defined in > drivers/net/virtio/virtio_user/vhost_user.c > > Signed-off-by: Christophe Fontaine > --- > drivers/net/virtio/virtio_user/vhost_user.c | 1 - > lib/vhost/vhost_crypto.c | 10 +- > lib/vhost/vhost_user.c | 529 ++++++++++---------- > lib/vhost/vhost_user.h | 7 +- > 4 files changed, 288 insertions(+), 259 deletions(-) > Thanks for working on this, I agree the FDs should be moved outside the Vhost-user message structure. Reviewed-by: Maxime Coquelin Thanks, Maxime