From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A46201B6B8 for ; Tue, 3 Apr 2018 14:54:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 05:54:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,401,1517904000"; d="scan'208";a="44519939" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by orsmga001.jf.intel.com with ESMTP; 03 Apr 2018 05:54:16 -0700 From: Ferruh Yigit To: Alejandro Lucero Cc: dev , Hemant Agrawal References: <1521826504-20195-1-git-send-email-alejandro.lucero@netronome.com> <1521826504-20195-2-git-send-email-alejandro.lucero@netronome.com> <2b74b6bf-5b41-b64c-5568-6fcbead8c629@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: <50a3b667-aa12-28de-1998-6bd3492edbfb@intel.com> Date: Tue, 3 Apr 2018 13:54:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 12:54:19 -0000 On 4/3/2018 12:09 PM, Ferruh Yigit wrote: > On 3/31/2018 6:04 PM, Alejandro Lucero wrote: >> >> >> On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit > > wrote: >> >> On 3/23/2018 5:35 PM, Alejandro Lucero wrote: >> > CPP refers to the internal NFP Command Push Pull bus. This patch allows >> > to create CPP commands from user space allowing to access any single >> > part of the chip. >> > >> > This CPP interface is the base for having other functionalities like >> > mutexes when accessing specific chip components, chip resources management, >> > firmware upload or using the NSP, an embedded arm processor which can >> > perform tasks on demand. >> > >> > NSP was the previous only way for doing things in the chip by the PMD, >> > where a NSPU interface was used for commands like firmware upload or >> > port link configuration. CPP interface supersedes NSPU, but it is still >> > possible to use NSP through CPP. >> > >> > CPP interface adds a great flexibility for doing things like extended >> > stats, firmware debugging or selecting properly the firmware file to >> > upload. >> >> It can be good to announce this new feature in release notes, what do you think? >> >> >> Uhmm, not sure about this. It is specific to the NFP PMD and I do not see it as >> a new feature, at least DPDK users will not be aware of it. > > OK, if this internal and you think user won't be interested in this update. > >> >>   >> >> Also get some build errors [1], one is about zlib.h, normally we disable PMDs by >> default with external dependencies, is nfp depends to libz with this patch? >> >> >> I forgot to remove this reference. It is not needed now, but it was with the >> initial internal work. >> >> About the other build errors, I do not get them and I have used a couple of >> different systems, Ubuntu and Redhat. This is, of course, a serious concern. Can >> you give me more information about the system you are using?   >> >> I remember I got some build error with other patches, from automatic builds made >> just after those patches were sent. I did not get any this time, just those >> warning for checkpatch which I was aware of. Is this automatic build not >> happening any more? > > I will share more details. Automatic build still works and it has wider > coverage, this is from my local script... [1] seems valid and for all. [2] #include seems for all. [3] clang [1] ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readl’: ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *value = rte_le_to_cpu_32(tmp); ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readq’: ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: ‘tmp’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *value = rte_le_to_cpu_64(tmp); [2] ...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: zlib.h: No such file or directory #include ^~~~~~~~ compilation terminated. make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:116: nfp_resource.o] Error 1 make[7]: *** Waiting for unfinished jobs.... ...dpdk/drivers/net/nfp/nfpcore/nfp_hwinfo.c:47:10: fatal error: zlib.h: No such file or directory #include ^~~~~~~~ [3] ...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format specifies type 'short' but the argument has type 'unsigned int' [-Werror,-Wformat] printf("\tusage:%hd\n", mutex->usage); ~~~ ^~~~~~~~~~~~ %u 1 error generated. make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:114: nfp_mutex.o] Error 1 make[7]: *** Waiting for unfinished jobs.... ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused function '__nfp_bytemask_of' [-Werror,-Wunused-function] __nfp_bytemask_of(int width, uint64_t addr) ^ 1 error generated. make[7]: *** [...dpdk/mk/internal/rte.compile-pre.mk:114: nfp_cppcore.o] Error 1 ...dpdk/drivers/net/nfp/nfp_net.c:2970:35: error: format specifies type 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') [-Werror,-Wformat] cpp->serial[4], cpp->serial[5], cpp->interface >> 8, ^~~~~~~~~~~~~~~~~~~ ...dpdk/drivers/net/nfp/nfp_net.c:2971:3: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat] cpp->interface & 0xff); ^~~~~~~~~~~~~~~~~~~~~ 2 errors generated. > >> >> >> >> [1] >> ...dpdk/drivers/net/nfp/nfpcore/nfp_mutex.c:295:28: error: format specifies type >> 'short' but the argument has type 'unsigned int' [-Werror,-Wformat] >>                         printf("\tusage:%hd\n", mutex->usage); >> >>                                         ~~~     ^~~~~~~~~~~~ >> >> >>                                         %u >> >> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:819:1: error: unused function >> '__nfp_bytemask_of' [-Werror,-Wunused-function] >> __nfp_bytemask_of(int width, uint64_t addr) >> >> >> ^ >> >> ...dpdk/drivers/net/nfp/nfp_net.c:2971:35: error: format specifies type >> 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') >> [-Werror,-Wformat] >>                 cpp->serial[4], cpp->serial[5], cpp->interface >> 8, >> >> >>                                                 ^~~~~~~~~~~~~~~~~~~ >> ...dpdk/drivers/net/nfp/nfp_net.c:2972:3: error: format specifies type 'unsigned >> char' but the argument has type 'unsigned int' [-Werror,-Wformat] >>                 cpp->interface & 0xff); >>                 ^~~~~~~~~~~~~~~~~~~~~ >> >> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readl’: >> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:459:9: error: ‘tmp’ may be used >> uninitialized in this function [-Werror=maybe-uninitialized] >>   *value = rte_le_to_cpu_32(tmp); >> >> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c: In function ‘nfp_cpp_area_readq’: >> ...dpdk/drivers/net/nfp/nfpcore/nfp_cppcore.c:483:9: error: ‘tmp’ may be used >> uninitialized in this function [-Werror=maybe-uninitialized] >>   *value = rte_le_to_cpu_64(tmp); >> >> ...dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:34:10: fatal error: zlib.h: No >> such file or directory >>  #include >>           ^~~~~~~~ >> >> > >> > Signed-off-by: Alejandro Lucero > > >> >> <...> >> >> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h >> b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h >> > new file mode 100644 >> > index 0000000..fbeec57 >> > --- /dev/null >> > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h >> > @@ -0,0 +1,748 @@ >> > +/* >> > + * Copyright (c) 2018 Netronome Systems, Inc. >> > + * All rights reserved. >> > + * >> > + * Redistribution and use in source and binary forms, with or without >> > + * modification, are permitted provided that the following conditions are >> met: >> > + * >> > + * 1. Redistributions of source code must retain the above copyright notice, >> > + *  this list of conditions and the following disclaimer. >> > + * >> > + * 2. Redistributions in binary form must reproduce the above copyright >> > + *  notice, this list of conditions and the following disclaimer in the >> > + *  documentation and/or other materials provided with the distribution >> > + * >> > + * 3. Neither the name of the copyright holder nor the names of its >> > + *  contributors may be used to endorse or promote products derived from this >> > + *  software without specific prior written permission. >> > + * >> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >> "AS IS" >> > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE >> > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE >> > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE >> > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >> > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >> > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN >> > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) >> > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE >> > + * POSSIBILITY OF SUCH DAMAGE. >> > + */ >> >> Can you please add new files with SPDX tags? >> >> >