DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Guo, Jia" <jia.guo@intel.com>
To: "Wu, Wenjun1" <wenjun1.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/e1000: fix the invalid flow control mode setting
Date: Wed, 20 Jan 2021 07:18:33 +0000
Message-ID: <50bcafce8d654fd48ea241671befb3f2@intel.com> (raw)
In-Reply-To: <20210120065337.230488-1-wenjun1.wu@intel.com>

Acked-by: Jeff Guo <jia.guo@intel.com>

> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Wednesday, January 20, 2021 2:54 PM
> To: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/e1000: fix the invalid flow control mode setting
> 
> E1000_CTRL register should be updated according to fc_conf->mode's value.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 34
> ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index 647aa8d99..a8fc57d2c 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -3064,6 +3064,7 @@ eth_igb_flow_ctrl_set(struct rte_eth_dev *dev,
> struct rte_eth_fc_conf *fc_conf)
>  	uint32_t rx_buf_size;
>  	uint32_t max_high_water;
>  	uint32_t rctl;
> +	uint32_t ctrl;
> 
>  	hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
>  	if (fc_conf->autoneg != hw->mac.autoneg) @@ -3101,6 +3102,39
> @@ eth_igb_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf
> *fc_conf)
>  			rctl &= ~E1000_RCTL_PMCF;
> 
>  		E1000_WRITE_REG(hw, E1000_RCTL, rctl);
> +
> +		/*
> +		 * check if we want to change flow control mode - driver
> doesn't have native
> +		 * capability to do that, so we'll write the registers ourselves
> +		 */
> +		ctrl = E1000_READ_REG(hw, E1000_CTRL);
> +
> +		/*
> +		 * set or clear E1000_CTRL_RFCE and E1000_CTRL_TFCE bits
> depending
> +		 * on configuration
> +		 */
> +		switch (fc_conf->mode) {
> +		case RTE_FC_NONE:
> +			ctrl &= ~E1000_CTRL_RFCE & ~E1000_CTRL_TFCE;
> +			break;
> +		case RTE_FC_RX_PAUSE:
> +			ctrl |= E1000_CTRL_RFCE;
> +			ctrl &= ~E1000_CTRL_TFCE;
> +			break;
> +		case RTE_FC_TX_PAUSE:
> +			ctrl |= E1000_CTRL_TFCE;
> +			ctrl &= ~E1000_CTRL_RFCE;
> +			break;
> +		case RTE_FC_FULL:
> +			ctrl |= E1000_CTRL_RFCE | E1000_CTRL_TFCE;
> +			break;
> +		default:
> +			PMD_INIT_LOG(ERR, "invalid flow control mode");
> +			return -EINVAL;
> +		}
> +
> +		E1000_WRITE_REG(hw, E1000_CTRL, ctrl);
> +
>  		E1000_WRITE_FLUSH(hw);
> 
>  		return 0;
> --
> 2.25.1


  reply	other threads:[~2021-01-20  7:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  6:53 Wenjun Wu
2021-01-20  7:18 ` Guo, Jia [this message]
2021-01-20 23:35   ` Zhang, Qi Z
     [not found] <20210120045859.211284-1-wenjun1.wu@intel.com>
2021-01-20  5:55 ` Guo, Jia
     [not found] <20210119065847.66043-1-wenjun1.wu@intel.com>
2021-01-19  7:43 ` Guo, Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50bcafce8d654fd48ea241671befb3f2@intel.com \
    --to=jia.guo@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git