DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Weifeng Li <liweifeng96@126.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	 "Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
Date: Wed, 13 Jan 2021 04:09:23 +0000
Message-ID: <50c03a97fb73443f865cd524ee5153b2@intel.com> (raw)
In-Reply-To: <20210110083417.1276-1-liweifeng96@126.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Weifeng Li
> Sent: Sunday, January 10, 2021 4:34 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Weifeng Li <liweifeng96@126.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
> 
> When NVM API version is 1.7 or above adminq operation to set TPID is set as
> supported. This cause using adminq instead of registers.
> For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause
> adminq operation to set as supported but it is not supported on FW4.16
> Additional check added for SFP_I_X722 to not enable adminq operation.

The commit log can be simplified to 
Disable "802.1ad frames ability" for SFP_I_X722 as it does not support.

> 
> Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Weifeng Li <liweifeng96@126.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 1462248..a07879c 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void
> *init_params __rte_unused)
>  		return -EIO;
>  	}
>  	/* Firmware of SFP x722 does not support adminq option */

This is not the problem of you patch, but the comment is totally misleading, what does "adminq option" means?
could you help to correct in v2?, I40E_HW_FLAG_802_1AD_CAPABLE should means"802.1ad frames ability"

> -	if (hw->device_id == I40E_DEV_ID_SFP_X722)
> +	if (hw->device_id == I40E_DEV_ID_SFP_X722 ||
> +		hw->device_id == I40E_DEV_ID_SFP_I_X722)
>  		hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE;
> 
>  	PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d
> eetrack %04x",
> --
> 2.9.5


  reply	other threads:[~2021-01-13  4:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  8:34 Weifeng Li
2021-01-13  4:09 ` Zhang, Qi Z [this message]
2021-01-14  4:50   ` Zhang, Qi Z
2021-01-14 12:41     ` 李伟峰

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50c03a97fb73443f865cd524ee5153b2@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=liweifeng96@126.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git