When NVM API version is 1.7 or above adminq operation to set TPID is set as supported. This cause using adminq instead of registers. For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause adminq operation to set as supported but it is not supported on FW4.16 Additional check added for SFP_I_X722 to not enable adminq operation. Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16") Cc: stable@dpdk.org Signed-off-by: Weifeng Li <liweifeng96@126.com> --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 1462248..a07879c 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) return -EIO; } /* Firmware of SFP x722 does not support adminq option */ - if (hw->device_id == I40E_DEV_ID_SFP_X722) + if (hw->device_id == I40E_DEV_ID_SFP_X722 || + hw->device_id == I40E_DEV_ID_SFP_I_X722) hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE; PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d eetrack %04x", -- 2.9.5
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Weifeng Li > Sent: Sunday, January 10, 2021 4:34 PM > To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com> > Cc: dev@dpdk.org; Weifeng Li <liweifeng96@126.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16 > > When NVM API version is 1.7 or above adminq operation to set TPID is set as > supported. This cause using adminq instead of registers. > For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause > adminq operation to set as supported but it is not supported on FW4.16 > Additional check added for SFP_I_X722 to not enable adminq operation. The commit log can be simplified to Disable "802.1ad frames ability" for SFP_I_X722 as it does not support. > > Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16") > Cc: stable@dpdk.org > > Signed-off-by: Weifeng Li <liweifeng96@126.com> > --- > drivers/net/i40e/i40e_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 1462248..a07879c 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void > *init_params __rte_unused) > return -EIO; > } > /* Firmware of SFP x722 does not support adminq option */ This is not the problem of you patch, but the comment is totally misleading, what does "adminq option" means? could you help to correct in v2?, I40E_HW_FLAG_802_1AD_CAPABLE should means"802.1ad frames ability" > - if (hw->device_id == I40E_DEV_ID_SFP_X722) > + if (hw->device_id == I40E_DEV_ID_SFP_X722 || > + hw->device_id == I40E_DEV_ID_SFP_I_X722) > hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE; > > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d > eetrack %04x", > -- > 2.9.5
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang, Qi Z
> Sent: Wednesday, January 13, 2021 12:09 PM
> To: Weifeng Li <liweifeng96@126.com>; Xing, Beilei <beilei.xing@intel.com>;
> Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
>
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Weifeng Li
> > Sent: Sunday, January 10, 2021 4:34 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Weifeng Li <liweifeng96@126.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
> >
> > When NVM API version is 1.7 or above adminq operation to set TPID is
> > set as supported. This cause using adminq instead of registers.
> > For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause
> > adminq operation to set as supported but it is not supported on FW4.16
> > Additional check added for SFP_I_X722 to not enable adminq operation.
>
> The commit log can be simplified to
> Disable "802.1ad frames ability" for SFP_I_X722 as it does not support.
>
> >
> > Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Weifeng Li <liweifeng96@126.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 1462248..a07879c 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void
> > *init_params __rte_unused)
> > return -EIO;
> > }
> > /* Firmware of SFP x722 does not support adminq option */
>
> This is not the problem of you patch, but the comment is totally misleading,
> what does "adminq option" means?
> could you help to correct in v2?, I40E_HW_FLAG_802_1AD_CAPABLE should
> means"802.1ad frames ability"
>
> > - if (hw->device_id == I40E_DEV_ID_SFP_X722)
> > + if (hw->device_id == I40E_DEV_ID_SFP_X722 ||
> > + hw->device_id == I40E_DEV_ID_SFP_I_X722)
> > hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE;
> >
> > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d
> eetrack
> > %04x",
> > --
> > 2.9.5
As the patch looks OK, I have applied to dpdk-next-net-intel with above comment be captured.
Thanks
Qi
your commit log is better. thanks.
| |
李伟峰
|
|
邮箱:liweifeng96@126.com
|
签名由 网易邮箱大师 定制
On 01/14/2021 12:50, Zhang, Qi Z wrote:
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang, Qi Z
> Sent: Wednesday, January 13, 2021 12:09 PM
> To: Weifeng Li <liweifeng96@126.com>; Xing, Beilei <beilei.xing@intel.com>;
> Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
>
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Weifeng Li
> > Sent: Sunday, January 10, 2021 4:34 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Weifeng Li <liweifeng96@126.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16
> >
> > When NVM API version is 1.7 or above adminq operation to set TPID is
> > set as supported. This cause using adminq instead of registers.
> > For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause
> > adminq operation to set as supported but it is not supported on FW4.16
> > Additional check added for SFP_I_X722 to not enable adminq operation.
>
> The commit log can be simplified to
> Disable "802.1ad frames ability" for SFP_I_X722 as it does not support.
>
> >
> > Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Weifeng Li <liweifeng96@126.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 1462248..a07879c 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void
> > *init_params __rte_unused)
> > return -EIO;
> > }
> > /* Firmware of SFP x722 does not support adminq option */
>
> This is not the problem of you patch, but the comment is totally misleading,
> what does "adminq option" means?
> could you help to correct in v2?, I40E_HW_FLAG_802_1AD_CAPABLE should
> means"802.1ad frames ability"
>
> > - if (hw->device_id == I40E_DEV_ID_SFP_X722)
> > + if (hw->device_id == I40E_DEV_ID_SFP_X722 ||
> > + hw->device_id == I40E_DEV_ID_SFP_I_X722)
> > hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE;
> >
> > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d
> eetrack
> > %04x",
> > --
> > 2.9.5
As the patch looks OK, I have applied to dpdk-next-net-intel with above comment be captured.
Thanks
Qi