From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 853D02C2F for ; Tue, 5 Sep 2017 09:05:49 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBBE87E43C; Tue, 5 Sep 2017 07:05:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CBBE87E43C Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.29] (ovpn-112-29.ams2.redhat.com [10.36.112.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B337812C0; Tue, 5 Sep 2017 07:05:42 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, yliu@fridaylinux.org, jfreiman@redhat.com, mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-13-maxime.coquelin@redhat.com> <20170905041435.GA31895@debian-ZGViaWFuCg> From: Maxime Coquelin Message-ID: <50d5bbbd-44d8-11de-f468-2ae770d12f68@redhat.com> Date: Tue, 5 Sep 2017 09:05:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170905041435.GA31895@debian-ZGViaWFuCg> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 05 Sep 2017 07:05:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 12/21] vhost: introduce guest IOVA to backend VA helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 07:05:49 -0000 On 09/05/2017 06:14 AM, Tiwei Bie wrote: > On Thu, Aug 31, 2017 at 11:50:14AM +0200, Maxime Coquelin wrote: >> This patch introduces vhost_iova_to_vva() function to translate >> guest's IO virtual addresses to backend's virtual addresses. >> >> When IOMMU is enabled, the IOTLB cache is queried to get the >> translation. If missing from the IOTLB cache, an IOTLB_MISS request >> is sent to Qemu, and IOTLB cache is queried again on IOTLB event >> notification. >> >> When IOMMU is disabled, the passed address is a guest's physical >> address, so the legacy rte_vhost_gpa_to_vva() API is used. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost.c | 27 +++++++++++++++++++++++++++ >> lib/librte_vhost/vhost.h | 3 +++ >> 2 files changed, 30 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >> index bae98b02d..0e8c0386a 100644 >> --- a/lib/librte_vhost/vhost.c >> +++ b/lib/librte_vhost/vhost.c >> @@ -48,9 +48,11 @@ >> #include >> #include >> #include >> +#include > > This header isn't needed. Right, I'll remove it. Thanks, Maxime > > Best regards, > Tiwei Bie >