From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB90AA3160 for ; Fri, 11 Oct 2019 08:14:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87BA11E95D; Fri, 11 Oct 2019 08:14:30 +0200 (CEST) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 78A801E964 for ; Fri, 11 Oct 2019 08:14:28 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4291EA40064; Fri, 11 Oct 2019 06:14:26 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Oct 2019 07:14:10 +0100 To: , Hemant Agrawal , Sachin Saxena , Akhil Goyal , Igor Russkikh , Pavel Belous , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Rahul Lakkireddy , Marcin Wojtas , "Michal Krawczyk" , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "John Daley" , Hyong Youb Kim , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Qi Zhang , Jingjing Wu , Wenzhuo Lu , Qiming Yang , Alejandro Lucero , Jerin Jacob , Maciej Czekaj , Rosen Xu , Tianfei zhang CC: References: <20191011040709.8344-1-pbhagavatula@marvell.com> <20191011040709.8344-2-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <50d82fa2-dc4f-e438-4617-4bd213ee65d5@solarflare.com> Date: Fri, 11 Oct 2019 09:14:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191011040709.8344-2-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24968.003 X-TM-AS-Result: No-2.325100-8.000000-10 X-TMASE-MatchedRID: wQVy7q402w1r2bIFd4uhtPZvT2zYoYOwC/ExpXrHizxHZg0gWH5yUZg4 J5K77fs68XVI39JCRnSlskwMhnibr0gMxOkBoMP0R/j040fRFpJsgPq1iB1CtJwsUqEjZnPrXvb V/VnUv0pM6jhUz2z6B+IGJZ6+qv8rTX7PJ/OU3vKDGx/OQ1GV8t0H8LFZNFG7mf3YH9x5dJV0gC 6OXOvYbYnuTYRIumwXBiYyCWmDEFrv6gd+JHYhKUGLBjjE23ui0WSTh2pSfCVldKRCDEEYf+KyT CN2SYlpgQLNJFyaGLiigEHy7J4S6ylkreA5r24aYnCi5itk3iprD5+Qup1qU4k0oJvJCVSkQwym txuJ6y0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-2.325100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24968.003 X-MDID: 1570774467-dkx4_XD4rfD6 Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/19 7:07 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Use RTE_DIM instead of re-defining ARRAY_SIZE. > > Signed-off-by: Pavan Nikhilesh [snip] > drivers/net/sfc/base/ef10_ev.c | 4 +-- > drivers/net/sfc/base/ef10_filter.c | 12 ++++---- > drivers/net/sfc/base/ef10_mac.c | 18 +++++------ > drivers/net/sfc/base/ef10_nic.c | 4 +-- > drivers/net/sfc/base/ef10_nvram.c | 6 ++-- > drivers/net/sfc/base/efx.h | 3 -- > drivers/net/sfc/base/efx_port.c | 2 +- > drivers/net/sfc/base/efx_rx.c | 2 +- > drivers/net/sfc/base/siena_mac.c | 2 +- > drivers/net/sfc/base/siena_nic.c | 20 ++++++------- > drivers/net/sfc/base/siena_nvram.c | 6 ++-- NACK No changes in net/sfc/base please. It is the base driver which is used on other platforms. So, it can't use DPDK specific macros.