* [dpdk-dev] [PATCH] net/virtio-user: fix port_id type
@ 2018-03-30 8:31 zhiyong.yang
2018-03-30 8:36 ` Maxime Coquelin
2018-04-04 9:51 ` Maxime Coquelin
0 siblings, 2 replies; 4+ messages in thread
From: zhiyong.yang @ 2018-03-30 8:31 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, tiwei.bie, Zhiyong Yang
virtio-user port_id range should be increased from 8 bits to 16 bits.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
index 64467b4f9..5f8755771 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
@@ -31,7 +31,7 @@ struct virtio_user_dev {
*/
uint64_t device_features; /* supported features by device */
uint8_t status;
- uint8_t port_id;
+ uint16_t port_id;
uint8_t mac_addr[ETHER_ADDR_LEN];
char path[PATH_MAX];
struct vring vrings[VIRTIO_MAX_VIRTQUEUES];
--
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/virtio-user: fix port_id type
2018-03-30 8:31 [dpdk-dev] [PATCH] net/virtio-user: fix port_id type zhiyong.yang
@ 2018-03-30 8:36 ` Maxime Coquelin
2018-03-30 8:39 ` Yang, Zhiyong
2018-04-04 9:51 ` Maxime Coquelin
1 sibling, 1 reply; 4+ messages in thread
From: Maxime Coquelin @ 2018-03-30 8:36 UTC (permalink / raw)
To: zhiyong.yang, dev; +Cc: tiwei.bie, stable
On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:
> virtio-user port_id range should be increased from 8 bits to 16 bits.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
Next time, please add cc: stable@dpdk.org as it targets v17.11 LTS.
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/virtio-user: fix port_id type
2018-03-30 8:36 ` Maxime Coquelin
@ 2018-03-30 8:39 ` Yang, Zhiyong
0 siblings, 0 replies; 4+ messages in thread
From: Yang, Zhiyong @ 2018-03-30 8:39 UTC (permalink / raw)
To: Maxime Coquelin, dev; +Cc: Bie, Tiwei, stable
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, March 30, 2018 4:37 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Bie, Tiwei <tiwei.bie@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/virtio-user: fix port_id type
>
>
>
> On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:
> > virtio-user port_id range should be increased from 8 bits to 16 bits.
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
>
> Next time, please add cc: stable@dpdk.org as it targets v17.11 LTS.
Ok. :)
Zhiyong
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio-user: fix port_id type
2018-03-30 8:31 [dpdk-dev] [PATCH] net/virtio-user: fix port_id type zhiyong.yang
2018-03-30 8:36 ` Maxime Coquelin
@ 2018-04-04 9:51 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-04-04 9:51 UTC (permalink / raw)
To: zhiyong.yang, dev; +Cc: tiwei.bie
On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:
> virtio-user port_id range should be increased from 8 bits to 16 bits.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> index 64467b4f9..5f8755771 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> @@ -31,7 +31,7 @@ struct virtio_user_dev {
> */
> uint64_t device_features; /* supported features by device */
> uint8_t status;
> - uint8_t port_id;
> + uint16_t port_id;
> uint8_t mac_addr[ETHER_ADDR_LEN];
> char path[PATH_MAX];
> struct vring vrings[VIRTIO_MAX_VIRTQUEUES];
>
Applied to dpdk-next-virtio/master.
Thanks!
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-04 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 8:31 [dpdk-dev] [PATCH] net/virtio-user: fix port_id type zhiyong.yang
2018-03-30 8:36 ` Maxime Coquelin
2018-03-30 8:39 ` Yang, Zhiyong
2018-04-04 9:51 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).