From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FB9E439FD; Mon, 29 Jan 2024 12:17:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB4C1402C2; Mon, 29 Jan 2024 12:17:06 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 2DD104029A for ; Mon, 29 Jan 2024 12:17:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IeoYCfne5ERIKjEdzRE+AHFRm+VHuJ1jI259e3NK19Ds8nVjk5HqIBK9lJwp9PdNpg8w4zwA8VjfaoTcfHcfcG5ZC1PLhOo9afT1yZIRuCyF2JPXuJmwbZo6h8JX4Nm6KZvMer0fMfZDpz0r/OCy1h3pQRL2DSdtsV/xcmlb6FEnryl7nlP9QA0RYom4aF4am2uBqGRRsoxYHNaWG+REox/sSqQhmUkgs0DgZifGgzpXO1cG6NmpnpN8HNMFZlj1OKP1KqPLsftePE7oqoxnMbjNLVomusIF1+5sRljYuOAPQMB+3mUNvU34lH4YHLkQcS/jAc3cI1ojwMkmq+c3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1YevPGAfW4I9u0Yo3LOIr9X8aiNjqi+YWAQAFXUnMrU=; b=LA5dXozUK6QVhklZqyvLhqOc9/Vi7jBLejMR03T65v34AO3UNRdivAb+Z5Fev2/RkcjV+YbBLKJHLYyBs/JWs/a0Ons/e03RvskC1EQYeWNfoUP4jQ2pDvqT5NoQtGouqrYAiBWg2334ixpnvy5wKvpEQUMgCedLopj9YI03lZKRHSKBd1uWQCNwVwTH6mBo613rgHeT6Dz64UgfnfOAktnxxKoo9Zj5FSvFD+hcJO79t6obkDaoeLyZaq0WwqBANmH1Gvar8xQ6cPtzYq3wdkfFjnnvs+YEyd2BbGzSLffIvtEgxtCGFpg3JkXLTJalzeYKTuYGQnd2W16VIaTC0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1YevPGAfW4I9u0Yo3LOIr9X8aiNjqi+YWAQAFXUnMrU=; b=r20SX+bV1/dV3bR2eu7XO9A2EeP9l01cTxvRXx2w9VVePn+ExpZmuehQ6WaYvZ6Yvg+rUP2dSNWAPGAOT6wEWKMYrlEpHjgBom/6yJcHfmGLRbElXLBYQj1HVYQ6Utjq+8rjOIGnnvj2bPiSpWDPT1S2r+eY1bnpfEDSa4+zw1E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5618.namprd12.prod.outlook.com (2603:10b6:510:134::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Mon, 29 Jan 2024 11:17:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.029; Mon, 29 Jan 2024 11:17:00 +0000 Message-ID: <50f72945-4f45-4f0f-9c52-a62522e27c26@amd.com> Date: Mon, 29 Jan 2024 11:16:09 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] ethdev: add the check for PTP capability Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, liuyonglong@huawei.com, Gagandeep Singh , Hemant Agrawal , Simei Su , Qi Zhang , Qiming Yang , Junfeng Guo References: <20220628133959.21381-1-liudongdong3@huawei.com> <20230817084226.55327-1-lihuisong@huawei.com> <1834a6a9-ef92-4a67-a987-490151cf5380@amd.com> <242e8583-969e-d8ca-2dd4-80e8cf73a662@huawei.com> <0d7f429c-8862-4f16-b7e5-46d69581f54f@amd.com> <3a11b30d-346f-446f-903a-5a56cbae3853@amd.com> <665b0b6e-1ad9-a692-39cb-9e45e6b78b08@huawei.com> <7ecc6f3b-78f8-6421-307d-2c6c484c6109@huawei.com> <5afa7ecf-254f-424b-9a58-1548e8ef270d@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: ZR2P278CA0037.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5618:EE_ X-MS-Office365-Filtering-Correlation-Id: affb7e09-bb7c-4914-1e6f-08dc20bbcfff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yZwjHE4+zrwCeXK6hstzOrn2471+gx2dtDWUCp44XEA+8E8IdIKg6qeY2xUqiFL+LjxSaHCxkXprctpAJAdohP2Awk1k07QIWvY+gkBYsuxyzzsc3S7ZGdZSV3fkglZu7iTaF/mffKIB89j1FVbculQ3dRsWWrT0l0n7ELc1BFtnEiq0wUnWemcVAJ6cUl5/p2ZDNFIdLRiDRz6czYi0tkLk8bAes0itPjllHt/gJTyLiZFq1yK9wY9wG46v37zdZuLivwA8OQQYQBeGjjitkTQKbNKU7e/UnQ2YUHeab4yJN7b+pNtdGr6WJuBEFZnkkC4Nwji0IsKeGU8BNiZhmYB76aQSzuHiCC+qwmirK+DRheyaZPkhW7V7tKRlvONqwbCz1dxn29dViBxAfRp6CIsikLaaPFRb6p5+KWRq+MMp6NMsjMbekim0FXieNIR86yIFbXhYZOjzS4gGwb4J12OZ/nKaRNnqGfwxp0QQ3A3+AsNTdQr8OKB2A+jCAR65bUHOC1qRtvDOcEARyvnmkBV58RyLsqpAurHIWI4eKGV3fEpE6g5fb4q/FvwRZmFgUVpbdAXYk67xErZhel2+DAkOZZaEshu97L+l7Ykzo1Xc/dSF6XI+pIPyAi8cMrDA0s2JwARrfC96HkLGPu6Vww== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(39860400002)(396003)(376002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(31686004)(66899024)(26005)(83380400001)(6512007)(6506007)(53546011)(36756003)(86362001)(31696002)(5660300002)(7416002)(44832011)(8676002)(41300700001)(4326008)(8936002)(2616005)(38100700002)(66946007)(66476007)(66556008)(54906003)(6486002)(2906002)(478600001)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWZvYnRzMjd6aDBadi8zcmYrb3BMbExpZ3BRdjJLK1pxNmtHWFBnSDg0UjFL?= =?utf-8?B?Sld2Qks5QWlzclo4NEVXWWc1TXlUU29xRG05Z0VycGh4K3lLbm81emlqMWlz?= =?utf-8?B?WVRzTWNtQS9ETDUxRktHeEJBbHBCa3V6YXRUVU5QR3RUVEkxMzlHcFNHZkJS?= =?utf-8?B?L2JJbXphZlJsT3FNTUxFaEQ2bk5wMGRvMVd0SlJ5K3hCY3lKTjNONkhBakI3?= =?utf-8?B?VEtBNnpjV2c2Q0J0SnNpZ01UVmplOGV5YkxmM0Q0NURBWE1PNlBtdEx5WWRm?= =?utf-8?B?SGxuZzlIeHdJZFlEajIzdmNwNnVoYmljd2ljMGx4bVRsOWhFVjQrWmtGR0xn?= =?utf-8?B?bDdQUzYzaFFNcTBwQjZWMkpFa1hRNk9yamh5bmdPLzd1STUrQUk4a3JPTXRp?= =?utf-8?B?NlE2SlU5M25FUnh4YTZrU0t2MlYwMTdZUkZxT3hVSkVQd3N3WVFuRkt3WWJW?= =?utf-8?B?YWVjOHl2M1pIRzg4RzRzOVRLU3pyTldHaUlUcDE0amxBaS8yOWE4RTV6QXp6?= =?utf-8?B?K1lVTmYyZ1RSRlVJTHhta0hETjFqRCt0T2UrZDgwRW1DQjlQTGJ1dWljdGpU?= =?utf-8?B?bGZvYjZVOUdtMnA3eFpTYnI5VTRxTTYya3N0TVVpdzNkOHc2TW8relhVckps?= =?utf-8?B?eitPOHlLZ3pzcEQyZ0RVOStta3QyVGVncUpza3ZBa3J6Z05SRFBPNHdheGZz?= =?utf-8?B?SGlhQXhYQ2NDalVHNXFVcHh1QXFhVS9CTGdIMGZwYUxaQWU4WjArWm5NZng3?= =?utf-8?B?ZFJDajlhdlZ2Mm83QnZiVS8vNW1WSW1aMC9FVG1jWHNITmhaclJVUW4zMjVE?= =?utf-8?B?M3VpYjZYT0c4Nm9zSGt1akdwSnBsTkhycXJocFdNM0VvQUhuR1ZGK3R3Zjlm?= =?utf-8?B?K2JXY2l3d3V5Qm4ydmhxMnk1OXJad3Voeld2MWRlVVVoTk90R1hzSFNMNGY2?= =?utf-8?B?NjdIczBsQ3lTVUJPZndCcXhiQUVKMk0ycmdzZ2J5cDNVSUl5WG9DNXA5VTQz?= =?utf-8?B?S29MWFJFb1pKd0FEb2N0WGhnTXN3SjNZSHUyWUxRTEFQSUVEbExDUEdzMDNa?= =?utf-8?B?OGc1MzgvRHEzNlFGVVI4NWNXWnorVGpmdDcrRmJmaUdLNzRld2xveklCcGNm?= =?utf-8?B?SHNnUlY1NEh6MVJ1SHFTZldPWG9na1YxSHdMaThhYkUyZWU3VnZveFRGRXVG?= =?utf-8?B?RGIvZCswL2QvNmZiajNhQlJCWW5teHJCWktJVUVtRDFvQjQwUUpENVB1K2g0?= =?utf-8?B?bkxSYlQ5MC9YS1IrUGdZTnNSVUpGREU4L1pza0U1M0VSMFNEaG5QQ0h4NDVp?= =?utf-8?B?Y0pPL2hoUjhsbXpBZ3FEMlo1SzRxaWFjWjJCQk9uTS9peVJFN05qR2JGanNE?= =?utf-8?B?RnNWV0hxeHpFbVAwTGpnZEJuQVpFVkxIbnJlQWkzTHYrWFVRS2NiNzZlQmN3?= =?utf-8?B?VEk3QWp2V3JOdWYwZnVxSnMzUXoreWE1a1c3cEhwKzJnd1lLOElwTS84MlFr?= =?utf-8?B?bEhZWHhjRDVXVE5Gb1R4RTMwM3YwVjB1S214aG03NEVJMlFVQk9tRjdRRjha?= =?utf-8?B?VnI4d2phM1lJZkh0aW12d1ZyVHlsMzhkUGZRdDJKbk1DNCt3QlNnZEltbjAw?= =?utf-8?B?THVsOE5TR1FvTEJrWW9IOHFoNjB4SDBjRElhck9qR3NBWExPSjRDY3hsS3Nk?= =?utf-8?B?bEFNd2NrcHBFV3JpaEYrQmZRM0cxeXlYYTQxM3cyWHhpUG9RK0cyZXFCQkVp?= =?utf-8?B?eDZ0dHAxaFo0eHRlVlFlR29QQjlrblJnL0Rac0E5ODdxa1NsL2lraE4rQmFk?= =?utf-8?B?UkM0NjI0RmxoeXM1N3BPcnJkN3Z2ZTQvQnBIWjkvbTZWSjE3S3crOWd6amx0?= =?utf-8?B?UTdDKzdUNVltelZ4ODBrU1F4WmxQNEMyUzFSS3Nzci9ka3gyMVdGOHN2T1Bi?= =?utf-8?B?Y3VTbDlvSG5ReVVraGMwbUJueFp3WUkwemNFWVVtallrcVNZTERaNzRyRWIw?= =?utf-8?B?eXIrb2QzZzJKWURkakc0cUlURlkvVlgrVTZzSlNpenpPZXR0d0RXc0NqeWpQ?= =?utf-8?B?NmZvaXNDTWRFNnpNck05L0NYSGFpU2VMcVFROTM0TVVveEwvU3M0bkc0REhx?= =?utf-8?Q?rZD8=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: affb7e09-bb7c-4914-1e6f-08dc20bbcfff X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 11:17:00.3098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 07uoJAei58uB/1hkS4hD0zynw1Xij6Ysv4zk1dNiPe8BB3TTgWk/pzPp5hu8hEfo X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5618 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/27/2024 1:52 AM, lihuisong (C) wrote: > > 在 2024/1/27 0:54, Ferruh Yigit 写道: >> On 1/11/2024 6:25 AM, lihuisong (C) wrote: >>> Hi Ferruh, >>> >>> 在 2023/11/23 19:56, lihuisong (C) 写道: >>>> 在 2023/11/2 7:39, Ferruh Yigit 写道: >>>>> timesync_read_rx_timestamp >>>>> On 9/21/2023 12:59 PM, lihuisong (C) wrote: >>>>>> add ice & igc maintainers >>>>>> >>>>>> 在 2023/9/21 19:06, Ferruh Yigit 写道: >>>>>>> On 9/21/2023 11:02 AM, lihuisong (C) wrote: >>>>>>>> Hi Ferruh, >>>>>>>> >>>>>>>> Sorry for my delay reply because of taking a look at all PMDs >>>>>>>> implementation. >>>>>>>> >>>>>>>> >>>>>>>> 在 2023/9/16 1:46, Ferruh Yigit 写道: >>>>>>>>> On 8/17/2023 9:42 AM, Huisong Li wrote: >>>>>>>>>>     From the first version of ptpclient, it seems that this >>>>>>>>>> example >>>>>>>>>> assume that >>>>>>>>>> the PMDs support the PTP feature and enable PTP by default. >>>>>>>>>> Please see >>>>>>>>>> commit ab129e9065a5 ("examples/ptpclient: add minimal PTP >>>>>>>>>> client") >>>>>>>>>> which are introduced in 2015. >>>>>>>>>> >>>>>>>>>> And two years later, Rx HW timestamp offload was introduced to >>>>>>>>>> enable or >>>>>>>>>> disable PTP feature in HW via rte_eth_rxmode. Please see >>>>>>>>>> commit 42ffc45aa340 ("ethdev: add Rx HW timestamp capability"). >>>>>>>>>> >>>>>>>>> Hi Huisong, >>>>>>>>> >>>>>>>>> As far as I know this offload is not for PTP. >>>>>>>>> PTP and TIMESTAMP are different. >>>>>>>> If TIMESTAMP offload cannot stand for PTP, we may need to add >>>>>>>> one new >>>>>>>> offlaod for PTP. >>>>>>>> >>>>>>> Can you please detail what is "PTP offload"? >>>>>>> >>>>>> It indicates whether the device supports PTP or enable  PTP feature. >>>>>> >>>>> We have 'rte_eth_timesync_enable()' and 'rte_eth_timesync_disable()' >>>>> APIs to control PTP support. >>>> No, this is just to control it. >>>> we still need to like a device capablity to report application if the >>>> port support to call this API, right? >>>>> But when mention from "offload", it is something device itself does. >>>>> >>>>> PTP is a protocol (IEEE 1588), and used to synchronize clocks. >>>>> What I get is protocol can be parsed by networking stack and it can be >>>>> used by application to synchronize clock. >>>>> >>>>> When you are refer to "PTP offload", does it mean device (NIC) >>>>> understands the protocol and parse it to synchronize device clock with >>>>> other devices? >>>> Good point. PTP offload is unreasonable. >>>> But the capablity is required indeed. >>>> What do you think of introducing a RTE_ETH_DEV_PTP in >>>> dev->data->dev_flags for PTP feature? >>> Can you take a look at this discussion line again? >>> >>> Let's introduce a  RTE_ETH_DEV_PTP in dev->data->dev_flags to reveal if >>> the device support PTP feature. >>> > Hi Ferruh, > > Thanks for taking your time to reply. > >> Hi Huisong, >> >> First let me try to summarize the discussion since it has been some time. >> >> HW timer block can be used for Rx timestamp offload >> (RTE_ETH_RX_OFFLOAD_TIMESTAMP) and/or PTP support, but they are two >> different things. >> >> This patch uses 'RTE_ETH_RX_OFFLOAD_TIMESTAMP' capability for PTP >> support, which is wrong. >> > correct. >> >> After we agreed on above, your next question is to use 'dev_flag' to >> report PTP capability. >> >> First, can you please describe what is the motivation to learn if HW >> supports PTP or now, what is the benefit of knowing this. > There are a couple of device which have the same driver on a platform or > OS. > But just allow one device to support or be responsible for PTP feature. > The firmware will report a capability to tell the device if it is > support PTP. > But, currently, driver doesn't know how to report user which device > support PTP feature. > Driver can hold a private data that records if PTP supported by the device or not, and according this value PTP dev_ops can return error or success. This may not be ideal but it lets user to know about the support status, can this work? > In addition, many drivers use RTE_LIBRTE_IEEE1588 to control PTP code flow. > Whether the device supports PTP is irrelevant to this macro. > Yes, I guess because both features use same HW, there is confusion there. >> >> If we agree that there is a need to know the PTP capability, question is >> where to report this capability. >> >> Suggested 'dev_flags' is used for various things, some are internal >> flags and some are status, I don't think overloading this variable is >> not good idea. > Yes, we need to consider  carefully. >> >> Other option is an update 'rte_eth_dev_info_get()' for it but it has the >> same problem, this function is already overloaded with many different >> things. >> >> We can have an API just to get PTP capability, but this will require a >> new dev_ops, this can be an option but my concern is having a capability >> dev_ops for each feature create a mess in dev_ops. >> >> Perhaps we can have single get_capability() API, and it gets features as >> flags to return if that feature is supported or not, but this requires a >> wider discussion. >> >> Instead can we deduce the capability from PTP relevant dev_ops, if they >> are implemented we can say it is supported? This doesn't require new >> support. > Thank you mentioning so many ways. > For the end of advice, I don't think it is appropriate. > Because we have to modify dynamically the pointer address of all PTP > APIs in dev_ops on the above case. > I was thinking for the case application distinguish if PTP related dev_ops set or not, but after your explanation I can see this won't help for your case. Because in your case PTP dev_ops implemented but some devices support it and some don't, and you are looking for a way to distinguish it. > How about we use rte_eth_dev_info.dev_capa to report PTP offload? > This is specifically used to report "Non-offload capabilities" according > to its document. > As mentioned above 'rte_eth_dev_info' is overloaded, I am for being more cautious to expand it more. Also I think it is a wider discussion if we want a capability reporting in ethdev and where it should be.