From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A53A0A05; Tue, 19 Jan 2021 16:52:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8BBC140ECE; Tue, 19 Jan 2021 16:52:28 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id D4989140ECC for ; Tue, 19 Jan 2021 16:52:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 2E28B5806A8; Tue, 19 Jan 2021 10:52:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Jan 2021 10:52:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 5+QYQiFu0sT0o+uzPLNTOgimDXugREQLyaCTU1ATV/4=; b=l4ClcTn1Ir/Ls1rs zhA+1ue+7mWveNMAJzUoZX/XDSoAw/V1qqZEe4X6ujTZKyfJHSPPdq00nGQ8Fvid b3HpXZKg7QJ0YLExMISfg2Sm0GnJA+qlAoZEICSzcwPJfHTFJ/BpYDtfvDC8p7DG cjUAXMRMzgUwyVFLfbVsKljX+uLB5rD/T0sRgZO17FY+xwqIjuITemKX/7AAVtWV TK+X4msY77Jjbrnkwfqs68y4pZNF8nS4XKrEKHgOLwVAk51efzY6kXCJ2VQPK/Au jj7XP/28EX20z5SpyzBduhQ9CSi8uvivxhnqLqJm5CrntUSMYiXT/ax5hAovDool lkDQZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5+QYQiFu0sT0o+uzPLNTOgimDXugREQLyaCTU1ATV /4=; b=iCdCTb5yuiMEQB0WcbUFmgt50cavqfOhl81Uo+HhVef8ZYXh3l5MjGA9v Yq7UUlvmrtH0shjccFNST2sHkx4oFeVR1DyBNR/8ZJ/c9DSoDDeovH9LRqlVdpE8 bM4uzMttNs+SYldHWowwROTK7/6ERffDJINbCNjrNjJuJpDDNf6wdKTS0GH6mUg1 h72nGsdg3S4AYpTmXE0cmvkV6wvaze/IBphbXTztZH/3MPrJkGeQUMLVRBwdqBIL F+1Gt8pXfnUlF8ouNxeW8U/Bvphko0yxbHz9+Nl0xd8OSc0dhwvqCqeVtwUKr8d1 nxKBFPou3RTVrknwoSmjk9qXcXGiQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 74FEC1080057; Tue, 19 Jan 2021 10:52:21 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "bruce.richardson@intel.com" , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" Date: Tue, 19 Jan 2021 16:52:19 +0100 Message-ID: <5100660.PnnWPLytas@thomas> In-Reply-To: <41e763746e344be89a07adac8eefb712@pantheon.tech> References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <4853612.H2Lh91oTzL@thomas> <41e763746e344be89a07adac8eefb712@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/01/2021 15:56, Juraj Linke=C5=A1: > From: Thomas Monjalon > > 15/01/2021 14:26, Juraj Linke=C5=A1: > > > Add Arm SoC configuration to Arm meson.build and add a meson option to > > > enable those options for native builds. This is preferable to > > > specifying a cross file when doing aarch64 -> aarch64 builds, since > > > the cross file specifies the toolchain as well. > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > Reviewed-by: Honnappa Nagarahalli > > [...] > > > --- a/config/arm/arm64_graviton2_linux_gcc > > > +++ b/config/arm/arm64_graviton2_linux_gcc > > > [properties] > > > -implementor_id =3D '0x41' > > > -implementor_pn =3D '0xd0c' > > > -max_lcores =3D 64 > > > -max_numa_nodes =3D 1 > > > -numa =3D false > > > +soc =3D 'graviton2' > > [...] > > > --- a/meson_options.txt > > > +++ b/meson_options.txt > > > +option('arm_soc', type: 'string', value: '', > > > + description: 'Specify if you want to build for a particular aarch64 > > > +Arm SoC when building on an aarch64 machine.') > >=20 > > This is more elegant, I like how cross and native share almost the same= option. > >=20 > > Why the option is named "arm_soc" and not just "soc"? > > The same option could be used by other archs, isn't it? >=20 > Agree that a more generic name would be better. > I'll change it to "soc" if there are no other suggestions. Another name could be "machine". Should it be the same mechanism as compiling for a specific x86 CPU from an x86 machine?