From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0051.outbound.protection.outlook.com [104.47.34.51]) by dpdk.org (Postfix) with ESMTP id 0117E271 for ; Wed, 13 Dec 2017 16:08:56 +0100 (CET) Received: from DM5PR03CA0042.namprd03.prod.outlook.com (10.174.189.159) by CY4PR03MB2693.namprd03.prod.outlook.com (10.173.43.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 15:08:55 +0000 Received: from BY2FFO11FD039.protection.gbl (2a01:111:f400:7c0c::172) by DM5PR03CA0042.outlook.office365.com (2603:10b6:4:3b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Wed, 13 Dec 2017 15:08:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD039.mail.protection.outlook.com (10.1.14.224) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Wed, 13 Dec 2017 15:08:47 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBDF8oL5030510; Wed, 13 Dec 2017 08:08:51 -0700 To: "Ananyev, Konstantin" , Matan Azrad , Nikhil Agarwal CC: "dev@dpdk.org" , "Hunt, David" , "nikhil.agarwal@nxp.com" , "hemant.agrawal@nxp.com" , "Yigit, Ferruh" References: <20171212100520.20502-1-nikhil.agarwal@linaro.org> <2601191342CEEE43887BDE71AB9772585FAC8785@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772585FAC91DE@irsmsx105.ger.corp.intel.com> From: Shreyansh Jain Message-ID: <51033c92-d286-6785-62c1-a9797046422c@nxp.com> Date: Wed, 13 Dec 2017 20:52:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAC91DE@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131576513279352656; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(7966004)(336005)(39380400002)(376002)(346002)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189003)(199004)(24454002)(13464003)(8656006)(54906003)(77096006)(76176011)(110136005)(316002)(58126008)(93886005)(86362001)(85426001)(50466002)(47776003)(230700001)(81166006)(8676002)(68736007)(305945005)(229853002)(81156014)(106466001)(36756003)(498600001)(97736004)(31696002)(2906002)(356003)(4326008)(6666003)(65806001)(6246003)(53936002)(104016004)(64126003)(2950100002)(31686004)(5660300001)(59450400001)(23676004)(2486003)(8936002)(105606002)(83506002)(53546011)(65956001)(65826007)(67846002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2693; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD039; 1:fjHj3NYGDbWShuHOFPdDyI+XclFLyLuXqQSUN1+P8azUpfn2L4ScJ8HkLd/hFGbGIvEwVLijrC5Wx9tOthqnmDPK34LvrotoO9+NH+i+KVlRf92steuvnvfSG2yaH2oB X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e89ed22e-3ad2-45fd-df50-08d5423b6943 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:CY4PR03MB2693; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2693; 3:yLdgVMmXj9/oH7ODM7W8rHWMRr9eAbVAaCPFrBDpZ28NiorwCsTkVWiDRRdtjwjNuK62iq6g6D4wx7WqjNvP4uAKXMw7wwVIt/tORyKWldMWeZjA1ERWpLFW+47etCWg6C5DFGJ7JikgFNo0OBQApIuAf+vhjEfPjgXt1CIOIx4H4cdX/V5UKs8f/HMA95oaX38TQ7NSEAmskicf5XK8s1y52RQyXQDgCrcsO8sgM83e3qc6OXe58oaKN6bCKqj7f5/28Yx5ABsNr58vmucJDKz4oJ3GKnlCVbazf8MAh+dNGpGoFfNhiKEf02LVShHQ8gkLeSgKb+Q/bPBHLq1RC2l2YsJVPeEXRM8Uj933Dyo=; 25:JlAaYelARYRTjRxhrlhlFwQ2S1OUbQ924Gn395plR8xdeZzRG/CyTpXoTugPFotG5gm1sU2Bogwk7cd/mm8o8HSD5RDz2yVK8jF/daOKWVsxa2tWCXJ8ytDd0q8lGOTxRCD+hjbC2rmkjCWhswaMRCI9DFkYswfcyUp4S1TU/VqRKmLr+eWjLsDCEBNIN0Slvwo5IEX2SF1u5rM0TkwBURR2Q55po8lOI/t1M9sNxgKUxik20PH+QaKFDqVX4YwaaA6BdeBiG3nJttUaqDM9xUC77rm6AUK9vvXTrRj49qO4DM8VfsGlbwzSD8GPhg3EyjYEbXngPcU5O7ias1XCyw== X-MS-TrafficTypeDiagnostic: CY4PR03MB2693: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2693; 31:/Q3/Knmw5lcZSjrqgZ42MeXrkajd3MNjvV/WhB+69aW38ExobBxJxG0zyAqXdRz7gr7FUCMMslfDtxrY5trc2ee7CZ62KDkCBeo6j2J3Kg5mU1g8GRs4sn4y9s24UBBOZOxazTSSnVeoMXutCLQXqhGiNMEhnK8S3iyWEypOthrvRC9RIFrcyNs9paWLvatToPRjsvMtnjOOFqlUqcmP4cNDeuOXg4J3vUQkIMzeJ/c=; 4:jkny7DpmG2KMSuglUjSljHEPSlnD5DiCdSZp4UIydrA1cWYQwYVa7wceUhshPE17aMUtBOHDhEzqrETsCKg6CZEiu6neWnm04Uz2SHMJCfvix2S7vx0Foj18VD2fC6FI7XCDljQL7SjAe+lTjLpyFOgBPShiZl3JdzwvgwO/2HcW1Wgrz40xNdVV7qt3vRUKjcYiIamQj029+qp0rSMDeTundWGmG1ceR4j/fP8WZXaoOYS9rW+s2NXDeQSPUXCCLkH4l0CanycTEBlU/dDG1X5MDhCrjEMbj8lzPTaEoHAmHD6UvNGsTo0lXhe6qQIj8SmcYLoFSiBasBO5DE37rlHD3Qws0pu/UrhUdDEcatbzwEe+YJ2VwXQSlkC7vKka X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231023)(93006095)(93001095)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123561025)(20161123559100)(20161123565025)(20161123556025)(20161123563025)(201708071742011); SRVR:CY4PR03MB2693; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY4PR03MB2693; X-Forefront-PRVS: 052017CAF1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjkzOzIzOnp2VWR2bEVXUkdDbm5RL3BCeHYxUWhwZmIz?= =?utf-8?B?YVhRRDNqVGJCMDFhVUpoZUozQ2x0UWRiTmJrNUJwaXlBNDJReG5QK3pPTmNO?= =?utf-8?B?aTBQMXQyTkUxU3dtazFzZTJlVitGOTNwbEJPN3FCMi9FbXlxOXN4SXpJaFdS?= =?utf-8?B?bExmRTdlVnQxNFB0Y2l6U3gzOW92RW93STN1L2huY2ZWQzR3dHdXdjBnSDFS?= =?utf-8?B?eGxZK1I3Wm1xcmFudkRJbWNVZDVEWFRVbElVQjhSZW9ESUFobVdxaFdsbFhy?= =?utf-8?B?dTBrU1cvVTBxTjk1UVZ0YnRNaUp1Z0tJU0NYV2VrOEVhWkNPWno0Rzd6NVI0?= =?utf-8?B?K3hUUEVMcHFrS1NWcnlzK1MwV2Z2cFJCMitRRUVha2hwZXY1ek9YOFNCQ0V1?= =?utf-8?B?T29uWW9TdlpKdjFUQzNyKzdnK3VtdHhDZXQyMU5RTlBmSlhJUkRPZ25JWFdv?= =?utf-8?B?UzljVTRQbXRCVjhxWlBBWDhiVXU0SFkzTkljaXpZZ0VTbE04TDlWYVB6bURK?= =?utf-8?B?TzMzbnhHOWdCOS9rQnJjL2h6akV3Q0d5aXp0VlV1emZuMzhzTU1QbGF5dUNR?= =?utf-8?B?WUQybCtMV1piNFFjeWRGL2JENUN0U2RoMVEvV1J1allRWFlTYlFXemE4VWZQ?= =?utf-8?B?UzJiTnBsMVp4bUs2a1o5ZjR2WTI0N1lBeTNzbW5YMTlSYlY1bjBXQzlNWFo4?= =?utf-8?B?cVJtenhJWG1KZGdrY2ZnbUdZdnNseHZGZ1VHUnBOcTNGUGtQOW4zZG5pLzZE?= =?utf-8?B?R1VVa3BTczBObk54NkNrbitxdHFXYTZFYk5YUy9od1RmODVTVmhrUTNSSERB?= =?utf-8?B?NVE3enBOWEJmbEM3YloramFjS3RKNWU4b3dHeEUxNUg4ZTd4VFpGU2tHOElN?= =?utf-8?B?NDhlNDJxZTVrYTg4QmVidFA4MmhPZnoyK3lzbS93SG9CcmhVRC9yL2tTK1pq?= =?utf-8?B?TkV5TDJZWlVlYUY1RGYreFlac2tRUXNiUmFiRVhnVUJ0c2krQ0hDUVNpZnlh?= =?utf-8?B?eFpidFZ4UVRvRmVBeXFKdGhzMFEvbHhKSU5TUVNTVWtSUnoxdHJIWEhVK2hX?= =?utf-8?B?ZlJnTjhZbEV5Tm82Z1VPOEF1SFFPek9vcmo4WUFBZXF6cWxxR0RhSXJabW9E?= =?utf-8?B?YlAyUXpkN0YxMUVobG1NdWxXV0VhYUZ4N05lYnNDVVlWWHE2QWdyTmJaelVD?= =?utf-8?B?eWtUUUV4L0djb1NDaU1DZ2U0cmVNWm9lSU5vUVUrRm8reDMvWEJkQ1llSitp?= =?utf-8?B?TUhHY1NEd0pVY09FczZjVnZMK1V2LzExMjNWM0lUa2xHU3J4SFQrTnhVY2Vl?= =?utf-8?B?VkQ2MHV6U2RYQUJlYWxkallmRmJtZlBGc09JQkZOS0tMM3I2d3JqL016blpR?= =?utf-8?B?UUFqVGhRY1VpWVFOQ1hkSkxwV0lHemdyNWkyc2dsQXgxRE5jYmtDLzk1a3Ux?= =?utf-8?B?a1BtdXhOQk51LzlOQ3BJQTk5bDd1Rkp4YjgwOW94M3VWTVVBanhIeG9IazdH?= =?utf-8?B?Ty9qengwV0NJRU1YQ2F5blIrRXUwQVMzdUYvam96RkVWb2FtZjJGdGxiQkpS?= =?utf-8?B?NWdkYjFVSHIydGdSTmxudTFPNG5kNk9ZUVJVbnZWY1dLT0sySndNYXUxdGg3?= =?utf-8?B?engxb1hrSlI3bS91K1Y2c0NGNDBvUnRIQXZqdGtJTitBblpXZXFtZkpmaXl4?= =?utf-8?B?SFVLUXl0ck0zS0J4MEFIaTZvVnRVMk5kSGRNL3FXRm1BK2FyOUt1dmd1NU11?= =?utf-8?B?RTNjdkZZckYzOGRNdGpZNEhGc1hHK3QyYWdRZHFOcGN4K3NxUHE1OTl3RGlB?= =?utf-8?B?R1RTRDdxUWgwMU4rUWxqMk1MaG9IdWw5WVZtUVR6aHNoUERqbk1LTk5Kb1Fk?= =?utf-8?B?ZzJJQjVGcHlxT3REVnVPUEJNSXViclpDaVpsd2trVHFkbi9iSFRMSUpoTHhk?= =?utf-8?B?WDN3cWp6R3BnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2693; 6:CgV4EGR+ETYoFnHgKAgb59zQjuPlz7SdaP8S//Ff6xf+emkUq7Mg9ihLzgPa/w5GAfVLvZq+9gErpj711ul+HBEKEl+TGNMsTgn8l6v04Ajni2V6BhRA60oYavd5apVRyoqbfMloV5E/4H0YOapfYHgbc17i50JJWWyH58m8FXcLWpAx2xUIeGyitEuEihy9hcFrBwLer3UFnNSA2QTrNIQsdzwO+xaPVDeDPQ97dWxSMkI2M4qVhoK+MmUBm/5tdCFT6i1eSfkzrtzTDri6oucppWwsGUXBS3J2aKXAQ6hJ7OBF2nkaQ30CkZJfRWvF5/prVNvzCJitN62WLIOoABhIMyNBWEq+/lNvwtvX7dc=; 5:h0VJZlmIsrnbsNA5IVliXS/7kyaC3C+UscPDfMT0+H6b/Ijn59LBbmGQ9pTVjKmii6Wbx43EOUAT0Jek1gri+mGF+nzdnQqGMLzvYa+hHxgZz4RV/VDJooGh5l2FQqlzktG6JsPos+5ig1xX+bYBmtNSp/amxC6Rgimj2C2VUkE=; 24:Qt1gzZqTKNtbUA6KWZYBoWn6/XvdA+QF2ULM2jUEv8Qw8Pnzq1CADm+hn+WlcfcGXDIflijGRRsjGyMSwD0yzcSZ0PadxkijmaWNqZNYfw4=; 7:D8Kd+wUoKAFwxvQtsGHpCirMZ28gFA7wvJPFUCU3QLoWnq1fbtk6T2E8ihkkWMh0xYxlikfBq6kh2fzg7riQEKKcIjhs+Y54wmbPw5bvBFDmo/cxb4eL52lkq99JHoDu4Hjff8BngRyt+o7W3/lhBJ4537E2WvrFkHC5SG4E3P6NfSMsjL7tqOjUz1mn4qD9MfyqkuWqG7fck/Mmq++9Y0b9EdfV5jHnkOvK4XnAmc7UxmlAgmqhlDDgDHXN5zHB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 15:08:47.7012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e89ed22e-3ad2-45fd-df50-08d5423b6943 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2693 Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 15:08:57 -0000 On Wednesday 13 December 2017 06:22 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] >> Sent: Tuesday, December 12, 2017 1:44 PM >> To: Ananyev, Konstantin ; Matan Azrad ; Nikhil Agarwal >> >> Cc: dev@dpdk.org; Hunt, David ; nikhil.agarwal@nxp.com; hemant.agrawal@nxp.com; Yigit, Ferruh >> >> Subject: Re: [PATCH 1/3] ethdev: add max burst size to device info >> [...] >>>> Doesn't such like devices PMDs should try to retrieve multiple HW burst to adjust the asked received packet number? >>> >>> Same thought here... >>> Can't that limitation be hidden inside PMD by calling HW burst multiple times? >> >> This might be required in some cases for performance. >> It is possible that for each request containing N buffers, if the PMD >> fetches all N (more than its preferred burst_size), cache misses reduce >> the performance - especially for SoC with limited cache size. >> >> Also, a complete cycle of >> application->driver->hardware->driver->application can help driver >> prefetch buffers - which, in case of hw burst looping, might be too >> little to complete the prefetch cycle. >> >> To summarize, indeed this is for performance specific cases and the idea >> that @Matan gave for renaming 'perf_buf_size' to highlight this, sounds >> logical. >> >>> Also if I am not mistaken - it would increase size of struct rte_eth_dev_info, right? >>> If so, then it means ABI breakage. >> >> Yes, deprecation notice should have been sent - if we continue with the >> dev_info change. To me that looks as one of the option. Maybe, someone >> on the list has a better idea. > > In theory there is at least 2 free bytes at the end of struct rte_eth_desc_lim. > Might be it would help a bit. :) Thanks for highlighting. So, you feel it is OK to reuse this assumption of hole in alignment? It certainly would bypass the ABI limitation but not sure which cases it would break (for example, same assumptions by others) It would an issue in case of 32bit systems, though. [...] - Shreyansh