From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D5A2A0032; Tue, 19 Jul 2022 22:44:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFC2941101; Tue, 19 Jul 2022 22:44:41 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C59F040FAE for ; Tue, 19 Jul 2022 22:44:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 47AAF5C0164; Tue, 19 Jul 2022 16:44:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Jul 2022 16:44:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658263480; x= 1658349880; bh=YWvdlHZ5TCsF2HpnviVDXiKLrKgkFl0cPTeahHDV5Dk=; b=o FbB0eJWJugU0Hr7BbR+uL1/8wEw3nYazXlIJ+yJzAvcvDqxIxcqm/Hoq9V9BPotJ qkTKWfqEKxI2GH+2PUnyGR94ifm9okSQrAinaUnQvRFPRv997jSg6wMNyg0Xhnq8 v9kc/peM5mFLLtADqa4Smcm4UJL8yLt18hwvL1F1Ep76j3DU01az0vj0ZURiUlkM JLt1P5wgswKr+4ZzxiYQ/B1t/18kTGRwlTJ9pAhzsmzfRmvUtfzToQJDv78VtxFT 6R1oW7JsJXuFT0GNA0wZoT45bFIRcCX0P7I5ux6vpwxL1lGuFdvH/FaSRRTkd8AI 65IVkMh21x7g7G38LQiqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658263480; x= 1658349880; bh=YWvdlHZ5TCsF2HpnviVDXiKLrKgkFl0cPTeahHDV5Dk=; b=I 0TAH2bxhCeaCCwU826ZBKzOpLLKz0EwpMwu+dZotkZZMZTMhEVDcWU4qsf1PL3zu cV9DC/WEK8Pk4nXwh+poGyPBiXHVFmC1ep3qfMwDRAK/Ble3YRPr0M0QiNdPCB4n VJFR5SxZffDmiReksyCTqwP2CKqdJRz94C4k8IzwOJ6liNT34egcH0RfLQ9idbNH Xh9NZiGl2rILnHJn9PpoLl0sbQv2bKWOdf4QVb8EY2EDGYMCS3lkQ02Kw7lj/WpD 7z3HSS8YxIZWFnu555g0XEjnysnyLLxSFQNB0aNEzX7L90/8JsWdf7ClJbhQfjrX tI9gSBAE6v2R6L1fdFxcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeltddgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Jul 2022 16:44:38 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Slava Ovsiienko , Ori Kam , Asaf Penso , Matan Azrad , Gaetan Rivet , Nir Anteby , Eli Britstein , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [dpdk-dev] [RFC] testpmd: support user-id attribute Date: Tue, 19 Jul 2022 22:44:37 +0200 Message-ID: <5103963.6fTUFtlzNn@thomas> In-Reply-To: <20220704082433.3698761-1-elibr@nvidia.com> References: <20220704082433.3698761-1-elibr@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +Cc ethdev and testpmd maintainers Any feedback about this need and solution? 04/07/2022 10:24, Eli Britstein: > Upon creation of a flow, testpmd assigns it a flow ID. Later, the flow > ID is used for flow operations (query, destroy, dump). > > The testpmd application allows to manage flow rules with its IDs. > The flow ID is known only when the flow is created. > In order to prepare a complete sequence of testpmd commands to > copy/paste, the flow IDs must be predictable. > > The idea brought here is to allow providing some user-defined ID, chosen > in advance of the effective flow creation. > > > Example: > > testpmd> flow create 0 ingress user_id 0x1234 pattern eth / end actions > count / drop / end > Flow rule #0 created, user-id 0x1234 > > testpmd> flow destroy 0 user_id rule 0x1234 > Flow rule #0 destroyed, user-id 0x1234 > Here, "user_id" is a flag that signifies the "rule" ID is the user-id. > > The motivation is from OVS. OVS dumps its "rte_flow_create" calls to > the log in testpmd commands syntax. As the flow ID testpmd would assign > is unkwon, it cannot log valid "flow destroy" commands. > > With the enhancement described above, valid testpmd commands can be > created in a log to copy/paste to testpmd. > The application's flows sequence can then be played back in testpmd, to > enable enhanced dpdk debug capabilities of the applications's > flows in a controlled environment of testpmd rather than a dynamic, more > difficult to debug environment of the application.