From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5AD141BB78
 for <dev@dpdk.org>; Thu, 10 May 2018 18:11:07 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C2793225A5;
 Thu, 10 May 2018 12:11:06 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 10 May 2018 12:11:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=F/93IXGg9Rt1Q6xagxVmvuuJJr
 vSleGB0mSS6GC/5po=; b=nrezMpdFnj0oLkvqzSJCtHmuEMtFVPZG8x80rAe46T
 5b81xXrd5AgJAXCfvgODbJ0es3YiDaVtt39/BMWDmjT7BgONdTwCcVKBGUeqJoUg
 G7vUy7zYKg7ONqn7ZPJt08K2wf3vd0s8vPRwfhzElpr7M42hf0Yq+dtmfSVVUda8
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=F/93IX
 Gg9Rt1Q6xagxVmvuuJJrvSleGB0mSS6GC/5po=; b=Dr8APN/vcBhcsSeKjk7pLR
 4sY8XSzbBp23YwQ7YH4I8s2qsvd8yP/KUrDL83ovkqvunWdk0kCk7zVM43tUoLaX
 gDRVt5oiiTi7HkL8FqAg5ImsPIgWHVX1qcAqRXsiZ0IgsO/oZ/LalbP4Y2go5A0H
 rqqUgUmX27yaixv88LDkKDbpcFcRj14e75QYHBNR3CA1DkQGFVxENYs5Jrfgaidq
 c1AXoUOsxhT7CtcPbkbhqjAwc72E6Lu6RUkko3Vl8Ivra1nL0ekXXHo8d59OmFCB
 EdOmttaIVzwgom7nvmLRi3K2pA1kafyt5ZHuGc7mR5nlhFA0mtTs3OA2Zx+b838A
 ==
X-ME-Sender: <xms:Gm_0WmI-YMfKAcVHEQO0b9WT_aO8EOMe3ugBjjkY1gS-ywtPWtxR1Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D60F3E43E8;
 Thu, 10 May 2018 12:11:05 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, lei.a.yao@intel.com
Date: Thu, 10 May 2018 18:11:04 +0200
Message-ID: <5108925.ZsJXTeGUpG@xps>
In-Reply-To: <8310826.PepUDZemRM@xps>
References: <1525893452-155596-1-git-send-email-nikhil.rao@intel.com>
 <20180510151642.GA25202@jerin> <8310826.PepUDZemRM@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eventdev: make ethernet
	port identifiers 16 bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 May 2018 16:11:07 -0000

10/05/2018 17:45, Thomas Monjalon:
> 10/05/2018 17:16, Jerin Jacob:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 10/05/2018 16:30, Jerin Jacob:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 10/05/2018 06:31, Jerin Jacob:
> > > > > > > Date: Thu, 10 May 2018 02:22:40 +0530
> > > > > > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > > > > > 
> > > > > > > Ethernet port ID data size has been extended to 16 bits size 17.11
> > > > > > > Update the Rx event adapter interface and implementation accordingly.
> > > > > > > 
> > > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> > > > > > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > > > > > Cc: stable@dpdk.org
> > > > > > 
> > > > > > Since it is an ABI change, please bump the library version.
> > > > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is
> > > > > > required.
> > > > > 
> > > > > The ABI changes must be described in the release notes too.
> > > > > 
> > > > > There is no deprecation notice for this ABI change.
> > > > > According the the policy, you must send a notice in 18.05,
> > > > > and do the change in 18.08.
> > > > 
> > > > Even for the APIs with experimental tag?
> > > 
> > > No, experimental can change without prior notice.
> > > 
> > > > If so, I don't see any
> > > > difference between experimental vs non experimental API? 
> > > 
> > > Rx adapter is not experimental as far as I know.
> > 
> > It is experimental. Please see the links.
> > 
> > http://dpdk.org/browse/dpdk/tree/MAINTAINERS#n351
> > http://dpdk.org/browse/dpdk/tree/lib/librte_eventdev/rte_event_eth_rx_adapter.h#n276
> 
> Yes, you're right.
> I've looked at the map file, where the symbols are not in EXPERIMENTAL block.
> 
> > If you agree then take dropped patch.
> 
> I'll take it.

Applied with a fix in meson file (ABI version to increase).