From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C6EFA0A02; Wed, 5 May 2021 16:39:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C114A41104; Wed, 5 May 2021 16:39:09 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2C9F140040 for ; Wed, 5 May 2021 16:39:08 +0200 (CEST) IronPort-SDR: 49Jr7xbldR2SN8C+tLg/jnGPzXhTj+RvXo05AQ3UhjUgJQPHRVYn6JU5NAgmSb3QdFewK1o6Z2 TOaNM8qVSCgQ== X-IronPort-AV: E=McAfee;i="6200,9189,9975"; a="177775417" X-IronPort-AV: E=Sophos;i="5.82,275,1613462400"; d="scan'208";a="177775417" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 07:39:06 -0700 IronPort-SDR: 7eKBqu4E5d5Aet15Ns20Akrmw8bpNYrwudWMj2tfjc7pK+LbXBC7H0mNL2gBDVjqTWpnnlZtxu Xdkcd+JAsfgg== X-IronPort-AV: E=Sophos;i="5.82,275,1613462400"; d="scan'208";a="433850216" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.194.51]) ([10.213.194.51]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 07:39:00 -0700 To: =?UTF-8?Q?Micha=c5=82_Krawczyk?= Cc: Shahed Shaikh , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Maxime Coquelin , Chenbo Xia , Stephen Hemminger , Long Li , Steven Webster , Matt Peters , Jerin Jacob , Maciej Czekaj , Yong Wang , Heinrich Kuhn , Shijith Thotton , Srisivasubramanian Srinivasan , Jiawen Wu , Jian Wang , Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , dev , Thomas Monjalon , bruce.richardson@intel.com, Qi Zhang , Andrew Rybchenko References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210331095254.2454439-1-qi.z.zhang@intel.com> <20210331095254.2454439-2-qi.z.zhang@intel.com> <27cbb27b-42c9-9a6d-c990-c2174ec59e83@intel.com> <155bda61-4a17-1618-003f-1b155304e448@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <512462f4-7b21-2f48-8dde-9d5bd2764640@intel.com> Date: Wed, 5 May 2021 15:38:56 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/5/2021 1:21 PM, Michał Krawczyk wrote: > śr., 5 maj 2021 o 13:45 Ferruh Yigit napisał(a): >> >> On 4/1/2021 3:30 PM, Ferruh Yigit wrote: >>> On 3/31/2021 10:52 AM, Qi Zhang wrote: >>>> PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap >>>> data path debug code. As .config has been removed since the meson build, >>>> It is not friendly for new DPDK users to notice those debug options. >>>> >>>> The patch introduces below build options for data path debug, so PMD >>>> can choose to reuse them to avoid maintain their own. >>>> >>>> - RTE_ETHDEV_DEBUG_RX >>>> - RTE_ETHDEV_DEBUG_TX >>>> >>>> All the build options are documented at programming guide >>>> "3.1 Driver Option", so users can easily find them. >>>> >>>> The original undocumented RTE_LIBRTE_ETHDEV_DEBUG will alias to >>>> both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward >>>> compatibility. >>>> >>>> Signed-off-by: Qi Zhang >>>> --- >>>> doc/guides/nics/build_and_test.rst | 16 ++++++++++++++++ >>>> lib/librte_ethdev/rte_ethdev.h | 22 ++++++++++++++-------- >>>> 2 files changed, 30 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/doc/guides/nics/build_and_test.rst >>>> b/doc/guides/nics/build_and_test.rst >>>> index e83dd4628c..e8b29c2277 100644 >>>> --- a/doc/guides/nics/build_and_test.rst >>>> +++ b/doc/guides/nics/build_and_test.rst >>>> @@ -26,6 +26,22 @@ This will also build testpmd. >>>> Detailed instructions are available >>>> in the :doc:`meson build guide <../prog_guide/build-sdk-meson>`. >>>> +The ethdev layer supports below build options for debug purpose: >>>> + >>>> +- ``RTE_ETHDEV_DEBUG_RX`` (default **disabled**) >>>> + >>>> + Build with debug code on Rx path. >>>> + >>>> +- ``RTE_ETHDEV_DEBUG_TX`` (default **disabled**) >>>> + >>>> + Build with debug code on Tx path. >>>> + >>>> +.. Note:: >>>> + >>>> + The ethdev library use above options to wrap debug code to trace invalid >>>> parameters >>>> + on data path APIs, so performance downgrade is expected when enabling >>>> those options. >>>> + Each PMD can decide to reuse them to wrap their own debug code in the >>>> Rx/Tx path. >>>> + >>> >>> Following drivers are other users of the PMD specific compile flag for the Rx/Tx >>> datapath debug logs [1], maintainers of those PMDs cc'ed, can you please plan >>> switching to the RTE_ETHDEV_DEBUG_RX / RTE_ETHDEV_DEBUG_TX macros? >>> >>> [1]: >>> - bnx2x: RTE_LIBRTE_BNX2X_DEBUG_RX / RTE_LIBRTE_BNX2X_DEBUG_TX >>> - qede: RTE_LIBRTE_QEDE_DEBUG_RX / RTE_LIBRTE_QEDE_DEBUG_TX >>> - virtio: RTE_LIBRTE_VIRTIO_DEBUG_RX / RTE_LIBRTE_VIRTIO_DEBUG_TX >>> - netvsc: RTE_LIBRTE_NETVSC_DEBUG_RX / RTE_LIBRTE_NETVSC_DEBUG_TX >>> - avp: RTE_LIBRTE_AVP_DEBUG_RX / RTE_LIBRTE_AVP_DEBUG_TX >>> - thunderx: RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX / >>> RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX >>> - vmxnet3: RTE_LIBRTE_VMXNET3_DEBUG_RX / RTE_LIBRTE_VMXNET3_DEBUG_TX >>> - nfp: RTE_LIBRTE_NFP_NET_DEBUG_RX / RTE_LIBRTE_NFP_NET_DEBUG_TX >>> - liquidio: RTE_LIBRTE_LIO_DEBUG_RX / RTE_LIBRTE_LIO_DEBUG_TX >>> - txgbe: RTE_LIBRTE_TXGBE_DEBUG_RX / RTE_LIBRTE_TXGBE_DEBUG_TX >>> - ena: RTE_LIBRTE_ENA_DEBUG_RX / RTE_LIBRTE_ENA_DEBUG_TX >>> >>> >> Reminder of this one. >> >> Can it be possible to schedule this task for v20.08? > > Hi Ferruh, > > we'll schedule this task for v20.08 for the ENA PMD. > Oops, I mean v21.08 obviously.