From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67864A10DA for ; Wed, 31 Jul 2019 11:10:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7302C1BF62; Wed, 31 Jul 2019 11:10:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5D7DC1BF57 for ; Wed, 31 Jul 2019 11:10:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 02:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,329,1559545200"; d="scan'208";a="200674669" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.92]) ([10.237.220.92]) by fmsmga002.fm.intel.com with ESMTP; 31 Jul 2019 02:10:24 -0700 To: Takeshi Yoshimura , dev@dpdk.org References: <20190731033523.2482-1-tyos@jp.ibm.com> From: "Burakov, Anatoly" Message-ID: <512a6b81-7891-bc66-257a-31a9bb8e1789@intel.com> Date: Wed, 31 Jul 2019 10:10:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190731033523.2482-1-tyos@jp.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31-Jul-19 4:35 AM, Takeshi Yoshimura wrote: > Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI > drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC) > because of the inconsistency of user's request and the result of > device capability for IOVA mode. I updated the code to force IOVA as > PA in ppc as before because current ppc driver does not support VA > mode. > > Theoretically, ppc can support VA mode, but I suspect that ppc with > VA mode may have performance issues to create a big DMA window > (VA often uses higher addresses than PA). So, I didn't change the > code to check device capability in ppc. > > Signed-off-by: Takeshi Yoshimura > --- > lib/librte_eal/linux/eal/eal.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > index 946222ccd..db2dec922 100644 > --- a/lib/librte_eal/linux/eal/eal.c > +++ b/lib/librte_eal/linux/eal/eal.c > @@ -1121,6 +1121,12 @@ rte_eal_init(int argc, char **argv) > RTE_LOG(DEBUG, EAL, "KNI can not work since physical addresses are unavailable\n"); > } > } > +#endif > +#ifdef RTE_ARCH_PPC_64 > + if (iova_mode == RTE_IOVA_VA) { > + iova_mode = RTE_IOVA_PA; > + RTE_LOG(WARNING, EAL, "Forcing IOVA as 'PA' because PPC uses PA mode.\n"); > + } > #endif I would have preferred a space between #endif and a new #ifdef, but otherwise Acked-by: Anatoly Burakov -- Thanks, Anatoly